brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.9k stars 2.34k forks source link

Fix padding for NTP top sites and favorites #25669

Open urbenlegend opened 2 years ago

urbenlegend commented 2 years ago

Description

Padding should be added to the left of the top sites/favorites list in the NTP.

  1. Not enough padding between the first top site and the edge of the gray container box.
  2. The first icon of the top sites list should align with the left edge of the adblock statistics.

Steps to Reproduce

  1. Open NTP.
  2. Click on the 3-dot menu to show the gray container box.

Actual result:

image

Expected result:

  1. There should be more padding between the top sites icons and the gray container box. Currently it looks too shifted to the left.
  2. The first icon should line up with the ad block stats above it.

Reproduces how often:

Every time

Brave version (brave://version info)

1.44.101 Chromium: 106.0.5249.65 (Official Build) (64-bit)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

rebron commented 2 years ago

cc: @aguscruiz @fallaciousreasoning

aguscruiz commented 2 years ago

Agreed on that solution, should go from here

image

to here

image
rebron commented 5 months ago

Should be fixed with https://github.com/brave/brave-browser/issues/38183

Image