Esc keypress closes private window when trying to dismiss brave message box

[u5r0]

I don't know if it relates to #14077 or not.

Description

This bug is new (current version 1.44), when I press Ctrl-H in (private window) to open history -which typically opens in normal window-, this message box appears. And pressing Esc to dismiss it, closes private window immediately. You lose your tabs and you don't get your history.

Steps to Reproduce

1. Press Ctrl-H, message box appears
2. Press Esc
3. However, clicking on the web page to dismiss it, won't close the window!

Actual result:

Private window closes

Expected result:

In previous brave versions it opens history in normal window

Reproduces how often:

Always

Brave version (brave://version info)

Brave	1.44.105 Chromium: 106.0.5249.91 (Official Build) (64-bit)
Revision	fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS	Linux
JavaScript	V8 10.6.194.17
User Agent	Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36

Version/Channel Information:

• Can you reproduce this issue with the current release? yes

• Can you reproduce this issue with the beta channel? haven't tried

• Can you reproduce this issue with the nightly channel? haven't tried

• Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? no

• Does the issue resolve itself when disabling Brave Rewards? haven't tried

• Is the issue reproducible on the latest version of Chrome? haven't tried

Miscellaneous Information:

[Crusaderz]

This is the most annoying bug in the browser, why does pressing Esc serve as the “close private” button in this message box?

[trianglPixl]

I ran into this recently on version 1.68.131 Chromium: 127.0.6533.73 (Official Build) (64-bit) under Windows 10. Can we get any word on this? The equivalent popup in Chrome doesn't have this issue.

[fmorroni]

This has been happening for years and it's super annoying, please fix it. As @trianglPixl said chrome doesn't have this bug...