brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.9k stars 2.34k forks source link

Include "Capture Screenshot" option in the context menu #25816

Open lukemulks opened 2 years ago

lukemulks commented 2 years ago

Description

We have received two separate feature requests from the Community for Brave to include a screenshot feature for desktop users this week.

One of the requests was pretty thorough, and included some good detail.

One user from the Community mentioned that they were observing the Firefox vs Brave comparison table from this page https://www.mozilla.org/en-US/firefox/browsers/compare/brave/, and noticed that the Screenshot feature was an item Firefox included, that Brave didn't.

Screenshot of the table Screenshot_20221005_085710_Brave

Did a little bit of digging, and it appears that Chromium ships with built-in screenshot capture options in the Dev Tools. (https://www.businessinsider.com/guides/tech/how-to-screenshot-on-google-chrome)

Screenshot_20221005_090442_Brave

Screenshot_20221005_090524_Brave

I queried the Chromium source code for references to screenshots, in case this is helpful.

https://source.chromium.org/search?q=Screenshot%20&sq=&ss=chromium%2Fchromium%2Fsrc

Steps to Reproduce

Ideally, similar to how we provide additional features in the context menu, I'm proposing that we add an option to the context menu when a user right clicks within the page DOM

  1. User right clicks in page
  2. User selects "capture screenshot"
  3. Brave captures and saves image of visible page area on screen to download folder.

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

lukemulks commented 2 years ago

Screenshot_20221005_095343_Brave

lukemulks commented 2 years ago

Screenshot_20221005_095600_Brave

lukemulks commented 2 years ago

Screenshot_20221005_095633_Brave

lukemulks commented 2 years ago

Screenshot_20221005_100352_Brave

lukemulks commented 2 years ago

Screenshot_20221005_101743_Brave

rebron commented 2 years ago

There's a flag for a screenshot tool now in beta/nightly. It's a screenshot tool for the current window via selection. brave://flags/#sharing-desktop-screenshots

Screenshot 2022-10-05 at 11 47 55 AM Screenshot 2022-10-05 at 11 48 41 AM
lukemulks commented 2 years ago

Excellent!

Saoiray commented 2 years ago

There's a flag for a screenshot tool now in beta/nightly. It's a screenshot tool for the current window via selection.

Awesome to see. One thing I'd like to add though, would it be possible to add an option for a shortcut for it? Not sure how difficult it would be to add in the coding for it, but can guarantee would be much appreciated instead of always having to click multiple times to get a screenshot. (I really need to start using Nightly. Been hesitant though. Need to learn how that works if have Release and Nightly, in terms of Rewards/Ads. Been afraid it would decrease earnings or somehow get me flagged)

SalahAdDin commented 1 year ago

Is it on the road map? It is funny we can do it with the developer tools, but we don't have a button for doing it from the toolbar itself.

bsclifton commented 1 year ago

We should be able to add something a little more accessible soon - @fallaciousreasoning has a prototype of adding a command palette to the omnibox. We could potentially add the devtools items for screenshotting as a source

Definitely would be nice to have as a context menu too, though!

fallaciousreasoning commented 1 year ago

We can probably get a shortcut set up too, after https://github.com/brave/brave-core/pull/17296 lands :smile: We'll just need to add a command for it.

jonathansampson commented 1 year ago

Users have also requested that such a feature offer optional full-size screenshots (i.e. screenshots of the entire document, which is presently available via the developer tools).