Closed stephendonner closed 1 year ago
@stephendonner — are you thinking an error message something like "Failed to create support ticket. Check your email address." or similar?
@stephendonner — are you thinking an error message something like "Failed to create support ticket. Check your email address." or similar?
@rmcfadden3 was thinking we should validate the email address first, and throw an error message specific to its validation, before even trying to submit, actually.
@stephendonner — are you thinking an error message something like "Failed to create support ticket. Check your email address." or similar?
@rmcfadden3 was thinking we should validate the email address first, and throw an error message specific to its validation, before even trying to submit, actually.
@stephendonner — so maybe something more like "Could not validate your email address. Please try again." or "Could not verify your email address. Please try again." instead?
@stephendonner — are you thinking an error message something like "Failed to create support ticket. Check your email address." or similar?
@rmcfadden3 was thinking we should validate the email address first, and throw an error message specific to its validation, before even trying to submit, actually.
@stephendonner — so maybe something more like "Could not validate your email address. Please try again." or "Could not verify your email address. Please try again." instead?
Sorry for the delay in responding; what @petemill implemented with the red error text (inline) LGMT 👍
The above requires 1.46.87
or higher for 1.46.x
verification. However, I believe we can verify the above without the need for the SKU SDK v2 to land on the server side.
Verification PASSED
using
Brave | 1.46.96 Chromium: 107.0.5304.91 (Official Build) beta (64-bit)
-- | --
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS | Windows 11 Version 21H2 (Build 22000.1098)
Verified using original STR from the description
VPN
button in the toolbarGears
iconContact technical support
Your email address
text field shows correct validation message Please enter a valid email address
for invalid email addressPlease choose a reason
returned for not choosing a Subject
This field is required
returned for empty body
Invalid email address | Not choosing a subject ` | Empty body |
---|---|---|
PASSED
usingBrave | 1.46.133 Chromium: 108.0.5359.71 (Official Build) (x86_64) |
---|---|
Revision | 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016} |
OS | macOS Version 13.1 (Build 22C5050e) |
1.46.133
Brave VPN
connection via account.bravesoftware.com
VPN
button in the toolbarGears
iconContact technical support
Your email address
text field shows correct validation message Please enter a valid email address for invalid email address
Please choose a reason
returned for not choosing a Subject
This field is required
returned for empty bodyexample | example | example | example |
---|---|---|---|
Description
Your email address
textfield needs validationKudos to @MadhaviSeelam for the find!
Steps to Reproduce
1.45.90
Brave VPN
connectionVPN
button in the toolbarGears
iconContact technical support
aaaa
into theYour email address
fieldSubmit
Actual result:
Failed to create support ticket, check your connection.
Expected result:
Should balk at the non-email-address text
aaaa
and throw an error saying so, with theYour email address
textfield highlighted in redReproduces how often:
100%
Brave version (brave://version info)
Version/Channel Information:
N/A
Yes
Yes
Other Additional Information:
Miscellaneous Information:
cc @MadhaviSeelam @aguscruiz @bsclifton @spylogsster @rmcfadden3