brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.54k stars 2.27k forks source link

Add unstoppable domains and ENS support to send UI on mobile #26032

Closed HEagle18 closed 4 months ago

HEagle18 commented 1 year ago

Description

https://github.com/brave/brave-core/pull/10529 PR for how its done on desktop

From @Douglashdaniel on desktop

Wired up UnstoppableDomains and ENS Resolution to UI

Refactored/Moved Send methods into a reusable hook useSend, will also clear toAddress and sendAmount after creating transaction. If a url ends with .eth it will call the ensGetEthAddr method, if the url is registered it will return an address that we will use to send, if the url is not registered will return a Domain is not registered error. If a url ends with .crypto it will call the unstoppableDomainsGetEthAddr method, if the url is registered it will return an address that we will use to send, if the url is not registered will return a Domain is not registered error. If the address starts with 0x, it will check if its a valid address, if not it will return a Not a valid ETH address error If the input value is not recognized it will return a Not a valid address error

Steps to reproduce

Actual result

Expected result

Issue reproduces how often

Version/Channel Information:

Device details

Brave version

Website problems only

Additional information

yrliou commented 7 months ago

@simoarpe Is this now supported due to WebUI migration?

simoarpe commented 7 months ago

Android fully relies on WebUI, so most likely it's a feature that is now supported. @srirambv can you please give it a quick check just to be extra sure?

srirambv commented 4 months ago

This now works on Android.

image image image
image image image

closing the issue