Closed rebron closed 1 year ago
Maybe we also want NTP search promotion to these new regions https://github.com/brave/brave-variations/blob/main/seed/seed.json#L1185
We probably need to re-open this for Android as I'm not sure if the work is done yet. cc @timchilds & @deeppandya
@anthonypkeane setting brave as default should be good but we need to change the onboarding behaviour for android.
This issue was closed incorrectly as the work on Android was not completed.
Reopening, adding the correct Android project and assigning to @deeppandya & @timchilds
@anthonypkeane the issue has an associated PR so it should not be reopened. If we need we can add an Android specific issue and mark this one as Desktop only
The above requires 1.45.121
or higher for 1.45.x
verification 👍
This issue was closed incorrectly as the work on Android was not completed.
Reopening, adding the correct Android project and assigning to @deeppandya & @timchilds
This particular PR can be verified on Android
as well but the onboarding portion will be done via https://github.com/brave/brave-browser/issues/26318 as per https://github.com/brave/brave-browser/issues/26318#issuecomment-1299587680. @brave/qa-team when verifying the above, you can use the STR/Cases outlined via https://github.com/brave/brave-core/pull/15669#issuecomment-1299023358 & https://github.com/brave/brave-core/pull/15669#issuecomment-1299634053. However, rather than going through all the cases I did, each platform should:
BR
or AR
(the new ones added)Brave
as default (CA
/ DE
/ FR
/ GB
/ US
/ AT
/ ES
/ MX
)Brave
as the default SE (example: Japan
or Poland
)Yandex
set as the default SEPASSED
usingBrave | 1.45.121 Chromium: 107.0.5304.91 (Official version) (x86_64) |
---|---|
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097} |
OS | macOS Version 11.7.1 (Compiled 20G918) |
BR (Brazilian) locale
(new addition)Case #1
- https://github.com/brave/brave-browser/issues/26182Case #2
- https://github.com/brave/brave-browser/issues/26181DE (German) locale
(existing locale with Brave Search as default)Case #1
- https://github.com/brave/brave-browser/issues/26182Case #2
- https://github.com/brave/brave-browser/issues/26181JP (Japan) locale
(doesn't have Brave Search as default)Case #1
- https://github.com/brave/brave-browser/issues/26182Case #2
- https://github.com/brave/brave-browser/issues/26181RU (Russia) locale
(Yandex as the default SE)Case #1
- https://github.com/brave/brave-browser/issues/26182Case #2
- https://github.com/brave/brave-browser/issues/26181Verification PASSED on
Brave | 1.45.121 Chromium: 107.0.5304.91 (Official Build) (64-bit)
-- | --
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS | Windows 10 Version 21H2 (Build 19044.2130)
AR (Argentina) locale
(new addition)Case #1
- https://github.com/brave/brave-browser/issues/26182Case #2
- https://github.com/brave/brave-browser/issues/26181FR (France) locale
(existing locale with Brave Search as default)Case #1
- https://github.com/brave/brave-browser/issues/26182Case #2
- https://github.com/brave/brave-browser/issues/26181IN (India) locale
(doesn't have Brave Search as default)Case #1
- https://github.com/brave/brave-browser/issues/26182Case #2
- https://github.com/brave/brave-browser/issues/26181RU (Russia) locale
(Yandex as the default SE)Case #1
- https://github.com/brave/brave-browser/issues/26182Case #2
- https://github.com/brave/brave-browser/issues/26181Verification passed on
Brave | 1.45.121 Chromium: 107.0.5304.91 (Official Build) (64-bit) |
---|---|
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097} |
OS | Ubuntu 18.04 LTS |
BR (Brazilian) locale
(new addition)Case #1
- https://github.com/brave/brave-browser/issues/26182Case #2
- https://github.com/brave/brave-browser/issues/26181en_GB locale
(existing locale with Brave Search as default)Case #1
- https://github.com/brave/brave-browser/issues/26182Case #2
- https://github.com/brave/brave-browser/issues/26181PL (Poland) locale
(doesn't have Brave Search as default)Case #1
- https://github.com/brave/brave-browser/issues/26182Case #2
- https://github.com/brave/brave-browser/issues/26181RU (Russia) locale
(Yandex as the default SE)Case #1
- https://github.com/brave/brave-browser/issues/26182Case #2
- https://github.com/brave/brave-browser/issues/26181Verified on Samsung Galaxy S21
& Samsung Galaxy Tab S7
using:
Brave 1.45.125 Chromium: 107.0.5304.110 (Official Build) (64-bit)
Revision 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS Android 12;
BR (Brazil) Locale
FR (France) Locale
PL (Poland) Locale
RU (Russia) Locale
Description
Update search engine defaults for:
Brave should be at the top of drop down list at brave://settings/search
Related: https://github.com/brave/brave-browser/issues/18331 and https://github.com/brave/brave-browser/issues/23814
Test plan
Region set to BR / AR
Default search engines
listRegion set to anything else (excluding CA / DE / FR / GB / US / AT / ES / MX)
Default search engines
list - unless you're in a region where Yandex is default (AM, AZ, BY, KG, KZ, MD, RU, TJ, TM, UZ). In that case it will be second.Notes for test plan
https://github.com/brave/brave-browser/issues/23814#issuecomment-1195841652