brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.57k stars 2.28k forks source link

Find dialog should not move as window scrolls through results #26242

Open mikeritter opened 1 year ago

mikeritter commented 1 year ago

Description

When pressing 'previous' or 'next' button in find dialog the dialog moves X position.

Steps to Reproduce

  1. Open URL with text content
  2. Open find dialog
  3. Type common string (i.e., 's ')
  4. Using mouse click 'next' button several times
  5. Using mouse click 'previous' button several times

Actual result:

Find dialog changes X position as result is highlighted.

Expected result:

Find dialog maintains X position so moving mouse over new button position not necessary

Reproduces how often:

Brave version (brave://version info)

Version 1.44.112 Chromium: 106.0.5249.119 (Official Build) (x86_64)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

rebron commented 1 year ago

Hi @mikeritter. What operating system are you using?

mikeritter commented 1 year ago

osx

mikeritter commented 1 year ago

Recommendation: Instead of displaying in an overlapping dialog, perhaps a search ribbon can expand down from above so the find controls never obscure the content thus never have to move out of the way.