brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.84k stars 2.33k forks source link

Support for Partial-Translate flag [Feature Request] #26382

Open ghost opened 2 years ago

ghost commented 2 years ago

I don't know if you are aware of brave://flags/#desktop-partial-translate

Desktop Partial Translate Enables the Partial Translate feature on Desktop, which allows users to translate text selections on the page through the right click context menu. – Mac, Windows, Linux, ChromeOS, Fuchsia, Lacros

desktop-partial-translate

Seems like it could help bringing the the feature of translating selected text to Desktop users easier and faster, even if you plan to do something to bring an universal native solution that works for Desktop and Mobile.

I found this screenshots of Chrome showing how it would look, simple but hooked to Brave Translate, should be great for Desktop users, at least for now.

This is an image

This is an image

Thank you and have a good day.

2084x commented 1 year ago

Would love this feature as well. I often come across English pages with just a few lines of foreign text and brave translate can rarely pick them up, so I'm stuck using the google translate extension for now.

geekyBoogiepop commented 1 year ago

I'm currently using DeepL translate extension to get the same result. I would really appreciate it if you can implement it, in fact, it is the most common way I use a translator, it helps me to learn a foreign language. Firefox already implemented it with an extension.

https://www.ghacks.net/2022/11/28/firefox-translations-1-2-free-text-translate-option-and-usability-improvements/