Closed kjozwiak closed 1 year ago
@kjozwiak would you be able to verify it ? i think it should be resolved.
@kjozwiak would you be able to verify it ? i think it should be resolved.
@deeppandya yup, lets close this off. Using 1.46.154 Chromium: 108.0.5359.128
, I went through the same STR/Cases mentioned above via the following locales:
Brazil
- now has Brave
as the default SE but tried a few time either way and ensured that tapping on the omnibox several times doesn't initiate the SE onboarding nor crash BravePoland
- went through the STR several times re: selecting Qwant
as the default (went through all other choices as well)Japan
- went through the STR several times re: selecting Qwant
as the default (went through all other choices as well)Portugal
- went through the STR several times re: selecting Qwant
as the default (went through all other choices as well)While running through the above, never experience a crash. It used to be pretty reproducible using Brazil
which isn't a valid case anymore as mentioned above.
Description
Looks like there's an intermediate crash when selecting specific search engines from the SE onboarding screen. Basically ran into this crash while running through https://github.com/brave/brave-core/pull/15669. For my particular case, it's crashing when selecting
Qwant
.Steps to reproduce
Brazil
and install1.47.20 Chromium: 107.0.5304.68
Qwant
from the modalYou'll notice that Brave crashes intermediately.
Actual result
https://user-images.githubusercontent.com/2602313/199414878-06f854d7-cbfc-44df-9d8a-32ebe7de4828.mp4
Expected result
Brave shouldn't be crashing when selecting a default SE via the SE onboarding modal.
Issue reproduces how often
It's pretty easy to reproduce using the STR/Cases mentioned above. I would say ~80% reproduction rate.
Version/Channel Information:
Yes
Yes
Yes
Device details
ARM
Samsung Galaxy S10+
Android 12
Brave version
Website problems only
N/A
N/A
N/A
Additional information
CCing @bsclifton @Uni-verse @timchilds @anthonypkeane @deeppandya