Autofill not working without Google Services installed

ghost commented 1 year ago

Description

When using a phone that doesn't have Google Play Services installed most password managers won't autofill, such as Bitwarden or 1Password. This doesn't only apply to Brave but also other chromium-based browsers. This issue causes a major inconvenience because the pop-up for most password managers doesn't show up.

Although most password managers also have the option to use Accessibility services, which does work, but it introduces many other issues caused by the huge amount of extra permissions granted to the password manager.

There is another privacy/security focussed browser that developed a patch for this, see this. If something like this can be adjusted and merged to fit in Brave it would fix the issue.

Steps to reproduce

Make sure that the device doesn't have Google Play Services installed (ROMs like GrapheneOS/CalyxOS/LineageOS don't come with these preinstalled)
Install a password manager such as bitwarden, login and create a dummy password (for Amazon let's say)
Enable the autofill option in Android under settings > Passwords and Accounts > Service for autofill
Use brave (or any other chromium browser) and try to login to the desired website. You will notice no autofill pop-up will show.

In Fenix based browsers, such as Firefox, this does work as they use another rendering engine

Actual result

Autofill pop-up doesn't show

Expected result

Autofill pop-up should show and allow the user to login easily

Issue reproduces how often

Every time the user wants to login to a website which is stored in their password manager

Version/Channel Information:

Happens on every channel I have tested since chromium v100 (and likely before that)

Can you reproduce this issue with the current Play Store version? Yes.
Can you reproduce this issue with the current Play Store Beta version? Yes.
Can you reproduce this issue with the current Play Store Nightly version?Yes. Note that the browser is installed from an APK directly, not through Google play becouse that requires Google Services.

Device details

Install type (ARM, x86): ARM
Device type (Phone, Tablet, Phablet): Phone
Android version: 13

Brave version

1.45.123 (Android)

Website problems only

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Additional information

None.

zhongkechen commented 1 year ago

Firefox/Bromite works fine without google framework

ghost commented 1 year ago

I know that. Bromite includes a patch that enables autofill, so that's why I was hoping this could be ported to brave aswell.

ghost commented 1 year ago

To add,

this is the patch I mentioned https://github.com/bromite/bromite/blob/master/build/patches/Enable-native-Android-autofill.patch

It enables autofill through the webview of the system

zhongkechen commented 1 year ago

This feature is now working on CalyxOS. They ported bromite patches to chromium on CalyxOS.

hostops commented 1 year ago

Still not working on microg version of lineage os.

rhee876527 commented 1 year ago

Bump. @bsclifton any way to bump priority for this pending card? I don't fancy using the accessibility mode autofill which is too permissive.

m0byn commented 1 year ago

I have exactly the same problem, and it is very inconvenient! Actually, auto-fill does work when logging into apps. However, with Brave it does not work. In my opinion, this is a high priority issue!

m0byn commented 1 year ago

I have exactly the same problem, and it is very inconvenient! Actually, auto-fill does work when logging into apps. However, with Brave it does not work. In my opinion, this is a high priority issue!

hoo84 commented 1 year ago

Please fix this issue by integrating the patch.

VegArchie commented 1 year ago

Still doesn't work.

Anyone found a work around?

hostops commented 1 year ago

By using firefox?

gogogohub commented 1 year ago

Wow I thought this was just a brave thing not related to play services. This would be amazing to see the patch added to brave.

m0byn commented 10 months ago

Seriously, it still does not work and it appears the patch is not added yet. Also, there is not even a single comment from a developer or from support here. What can we do to promote the issue to gain some momentum in fixing this issue? It is insanely annoying without auto-fill, but otherwise Brave is amazing!

ported-pw commented 9 months ago

Vanadium from GrapheneOS also has a fix for this: https://github.com/GrapheneOS/Vanadium/blob/main/patches/0116-Support-native-Android-autofill-at-browser.patch

As a heavy password manager user, this is severely impacting my willingness to continue using Brave on my phone.

Repowave commented 9 months ago

It's also worth mentioning that the successor to Bromite, Cromite, works fine as well. For those looking for an alternative to Brave until this gets resolved, that's probably your best bet since it also has AdBlocking.

m0byn commented 9 months ago

An information of a developer would be appropriate whether this will be fixed or not. If not, I am going to switch to a different browser.

abdulocracy commented 9 months ago

I've already switched to Vanadium. Brave claims to care about privacy but is the only browser that won't fix this critical bug for their most privacy-conscious users who don't want to use Google services on their phones, or give apps complete accessibility service access.

bschnei commented 8 months ago

@bsclifton please consider relabeling this a bug and prioritizing accordingly. Despite the old title, users are reporting (and I can confirm) that this issue persists even with sandboxed Global Play installed which means it affects a larger subset of users than the title implies. Bitwarden and GrapheneOS support teams have been responsive to this issue being reported in their respective communities, and the fix (adding support for native auto-fill) has long been known and integrated into competing browsers. Thank you!

BluePixel4k commented 7 months ago

Hi @deeppandya, are you working on this bug? :) Will we see a fix in the near future?

deeppandya commented 7 months ago

Hi @deeppandya, are you working on this bug? :) Will we see a fix in the near future?

I will check if we can prioritize it based on the changes. I am going to include the issue for internal discussion.

m0byn commented 6 months ago

Do I interpret it correctly, that there will not be any solution for this issue soon due to adding the priority/P5 label? Please let us know, so we can act accordingly.

Thank you.

Repowave commented 6 months ago

For anyone following this, I'd like to report that - at least for me - it has been resolved in the latest Brave update (1.65.114) which patch notes include:

Upgraded to Chromium 124.
Registered Brave as the autofill service for addresses.
Added an option to disable autofill in private browsing mode.

To reiterate, I'm on a custom Android ROM and I've tested with multiple password managers that hadn't worked prior to this update - no Accessibility Mode needed. :)

Note: This does require the brave://flags #enable-autofill-virtual-view-structure to be Enabled and the resulting "Autofill Options" set to "Use other providers" in order to function. Semi-related, you might want to also enable #web-authentication-android-credential-management to use PassKeys if your password manager supports them.

deeppandya commented 6 months ago

For anyone following this, I'd like to report that - at least for me - it has been resolved in the latest Brave update (1.65.114) which patch notes include:

Upgraded to Chromium 124.

Registered Brave as the autofill service for addresses.

Added an option to disable autofill in private browsing mode.

To reiterate, I'm on a custom Android ROM and I've tested with multiple password managers that hadn't worked prior to this update - no Accessibility Mode needed. :)

Thank you @TwilitWave for your acknowledgment. @tapanmodh has done some amazing work for autofill

VegArchie commented 6 months ago

For anyone following this, I'd like to report that - at least for me - it has been resolved in the latest Brave update (1.65.114) which patch notes include:

This is NOT working for me. Brave updated today, GrapheneOS upgraded today, using Roboform.

BluePixel4k commented 6 months ago

Note: This does require the brave://flags #enable-autofill-virtual-view-structure to be Enabled and the resulting "Autofill Options" set to "Use other providers" in order to function. Semi-related, you might want to also enable #web-authentication-android-credential-management to use PassKeys if your password manager supports them.

Thank you for the hint! After enabling the flag and changing the setting in Brave, it's working for me on GrapheneOS now. 🎉

@deeppandya @tapanmodh Thank you! But one question, will this feature be enabled by default in the future?

m0byn commented 6 months ago

I have to say a BIG & HUGE THANK YOU! Very funny I installed Mull browser yesterday because I was tired of manually pasting the login credentials. Now, I can switch back to Brave - yeiii

hoo84 commented 6 months ago

This works for me on Android 15, Brave Nightly 1.67.18. I can even use my Passkey to login in to GitHub. What doesn't work is autofill my password on eBay, but overall it's a big improvement.

Anvil5465 commented 2 months ago

For some reason, when I enable both of these flags at once, passkeys break (upon clicking the option to login with a passkey, brave just crashes). I find this strange because the flag to enable passkeys works fine as long as #enable-autofill-virtual-view-structure is disabled and #web-authentication-android-credential-management is enabled. I'm on Android 14 with brave 1.67.136 and bitwarden. It's been like this for months now.

brave / brave-browser