Search History appearing on the Address Bar

[krish-98]

I don't know why my previous search histories are appearing on the address bar

It shouldn't appear there in the first place

[bE7rwls]

Same problem when using google search engine. And it doesnt matter if suggestions and autocomplete are disabled or not

[CQ-0]

Yeah, #12292 was closed as a dupe of #22948, which supposedly fixed the issue, but it is still present. I just moved over from Edge which is also Chromium based and noticed this immediately, and it's holding me back from migrating completely.

[need-4-sleep]

Same problem even after configuring all settings relating to search. This extension fixes it for now.

[bsclifton]

@krish-98 can you confirm it doesn't show when you go under brave://settings/appearance and uncheck Browsing History under Show autocomplete suggestions in address bar (or just disable the whole top level Show autocomplete suggestions in address bar)

@CQ-0 which version of Brave did you try this on? The default setting is having it checked. After you change it, you might try restarting the browser and see if it still happens on reload

[krish-98]

@bsclifton Show autocomplete suggestions in address bar is turned off yet browser histories are still appearing on the address bar

My Brave is up to date Version 1.46.144 Chromium: 108.0.5359.128 (Official Build) (64-bit)

[CQ-0]

@bsclifton I'm on the latest version of Brave: Version 1.46.144 Chromium: 108.0.5359.128 (Official Build) (64-bit)

I have unchecked all 4 options under Show autocomplete suggestions in address bar in brave://settings/appearance, and disabled the whole top level Show autocomplete suggestions in address bar. Additionally, I have also unchecked Auto-complete searches and URLs under brave://settings/privacy. Re-enabled them, restarted, disabled, restarted again, and it still behaves the same.

Going to brave://omnibox/ and checking Connect window omnibox, then clicking the omnibox on a new tab shows that the "Provider" for the suggestions is "LocalHistoryZeroSuggest". Changing the #omnibox-max-zero-suggest-matches in flags to Enabled 5 limits the suggestions to only 5. Therefore, there should should definitely be a fix for this issue that has been bugging users for years if another Chromium browser doesn't behave this way.

[CQ-0]

Same problem even after configuring all settings relating to search. This extension fixes it for now.

Unfortunately this doesn't work for me for some reason.

[rebron]

cc: @fallaciousreasoning

[rebron]

@krish-98 and @bE7rwls Both of you are using Google search engine as the default correct? I can reproduce with just Google but not any other search engine.

[rebron]

I can reproduce on 1.46.144 Chromium: 108.0.5359.128 (Official Build) (arm64) but looks like it's fixed in 1.47.x and higher. 1.47.x is targetted for release next week.

[ZeroCool940711]

@krish-98 and @bE7rwls Both of you are using Google search engine as the default correct? I can reproduce with just Google but not any other search engine.

I also have this issue and think google is the only search engine having this issue on brave, the others work properly but when you set google as your default search engine you can't disable the search history and it's always shown on the address bar, no matter if it was a search made directly from the address bad that sent you to google or a search made after you manually went to google and searched for something, it will always show up on the address bar, even if you have disabled google's own search history and made it so its not saving anything for you, it will still show up on the brave's address bar which is really concerning.

[bsclifton]

Huge thanks for confirming it's fixed in 1.47 and newer @rebron 😄 If it was a regression upstream it may have been fixed with the Chromium upgrade (as 1.47 upgrades us to Chromium 109)

[bsclifton]

This should be closed now as 1.47 was released today 😄

[bE7rwls]

1.47.171 cleared cache, same problem

[rebron]

@bE7rwls Are these your settings in brave://settings/appearance?

[rebron]

@bE7rwls Below is what I'm getting in 1.47.171. Can you provide the OS, maybe platform specific?

[bE7rwls]

Windows 10 22h2 19045.2486, Autocomplete suggestions - off, Auto-complete searches and URLs - off. Btw, could this have something to do with having multiple profiles in Brave? Upd: yeah, fresh browser with 1 profile - this problem remains

[ZeroCool940711]

Windows 10 22h2 19045.2486, Autocomplete suggestions - off, Auto-complete searches and URLs - off. Btw, could this have something to do with having multiple profiles in Brave?

I'm pretty sure the issue is specific with Google being the default search engine, this issue only happens when you have Google set as your default search engine, if you use any other search engine the search history is gone from the address bar correctly if you disable the options for it and you have your privacy back. I still don't understand how something like this that compromises your privacy no matter how you look at it, still hasn't being fixed in such a long time, it's practically an issue that has being around for years, every couple of releases it gets patched and temporarily fixed but it always comes back.

[rebron]

@bE7rwls Are you also in the US region or are you somewhere else? The google search is different per region.

[rebron]

@bE7rwls Can you also tell me what you have here in brave://settings/searchEngines

In any case, it's really this setting here https://github.com/brave/brave-browser/issues/26894#issuecomment-1386009117 that effects whether browsing history and therefore search history shows.

[rebron]

@bE7rwls Thanks for helping us with this issue. I wanted to ask if you had sync enabled.

[bE7rwls]

EU region, sync enabled

[MadhaviSeelam]

Reproduced the issue in Win 11 x64. This issue was reproduced in Win 10 and macOS as well. @GeetaSarvadnya @stephendonner, please feel free to add your test results.

cc: @rebron @fallaciousreasoning

Brave | 1.47.171 Chromium: 109.0.5414.87 (Official Build) (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 11 Version 21H2 (Build 22000.1455)

1. new profile
2. launch Brave
3. open brave://settings/search
4. select Google
5. open brave://settings/appearance
6. Unselect Browsing History, Top sites, and Suggested Sites
7. open brave://settings/privacy
8. disable Autocomplete searches and URLs
9. open a new tab enter few search terms in the URL bar (eg. clouds, rains)
10. open a new tab and click in the URL bar (do not enter anything)

Actual results: Search history shows up Expected results: Search results shouldn't autocomplete

[stephendonner]

I was also able to reproduce this using 1.47.171 on macOS:

example	example	example

[stephendonner]

Verified PASSED using

Brave	1.49.89 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision	65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS	macOS Version 11.7.3 (Build 20G1116)

Followed the steps to reproduce from https://github.com/brave/brave-browser/issues/26894#issuecomment-1387342514.

Confirmed I didn't see anything, at all, autocompleted/present in the URL bar, pressing down, spacebar, etc.

example	example	example	example	example

[fallaciousreasoning]

For those who want the fix, it's available in the latest Nightly - should be in stable in the next couple of months.

[stephendonner]

For those who want the fix, it's available in the latest Nightly - should be in stable in the next couple of months.

Around March 7th: https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule#release-channel-dates

[MadhaviSeelam]

Verification PASSED using

Brave | 1.49.106 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
-- | --
Revision | 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS | Windows 11 Version 21H2 (Build 22000.1574)

Followed STR from https://github.com/brave/brave-browser/issues/26894#issuecomment-1387342514

Example	Example	Example	Example	Example

[LaurenWags]

Verified with

Brave   1.49.114 Chromium: 110.0.5481.177 (Official Build) beta (64-bit) 
Revision    f34f7ab2d4ca4ad498ef42aeba4f4eb2c1392d63-refs/branch-heads/5481@{#1239}
OS  Linux

Reproduced the issue using steps from https://github.com/brave/brave-browser/issues/26894#issuecomment-1387342514 and 1.48.171 Chromium: 110.0.5481.177

Step 4	Step 6	Step 8	Step 10

Upgrade Profile - PASSED

Took profile from 1.48.171 where the issue had reproduced and upgraded it to 1.49.114. Confirmed that search history did not show: New tab | Search History ---- | ---- |

Clean Profile - PASSED

Verified steps from https://github.com/brave/brave-browser/issues/26894#issuecomment-1387342514 on a clean 1.49.x profile. Confirmed that search history did not show: Step 4 | Step 6 | Step 8 | Step 10 ---- | ---- | ---- | ---- | | |

[bE7rwls]

Hello, updated to v1.49.120. The results are still showing up on the adress bar. Or the fix is gonna be in future updates? (Autocomplete suggestions - off, Auto-complete searches and URLs - off, cache cleared)

[fallaciousreasoning]

@bE7rwls could you send me a screenshot of your settings from Step 6 in this comment? https://github.com/brave/brave-browser/issues/26894#issuecomment-1450834549

[krish-98]

I don't know how they closed this issue which hasn't even been solved yet.

[fallaciousreasoning]

@krish-98 & @bE7rwls I think I reproduced the issue and I might have a workaround while we wait for the new fix to get to stable. Do you have Show autocomplete suggestions in address bar turned off like this?

As a workaround, turn it on and uncheck the Browsing History item

Then, you can turn Show autocomplete suggestions in address bar off again. I'm going to put together another fix. Sorry about that, sometimes turning off Chromium functionality is a bit fiddly.

I've filed a new issue https://github.com/brave/brave-browser/issues/29043 so you can track the progress

[bE7rwls]

But the initial problem is that it should only show suggestions from the browser history when I start typing something, not when I just click on the address bar. It only works correctly using any other search engine than Google. Is it possible to fix?

1.open brave://settings/search 2.select Google 3.open brave://settings/appearance

4. show autocomplete suggestions in address bar - on
5. select Browsing History, Top sites, and Suggested Sites 6.open a new tab enter few search terms in the URL bar (eg. clouds, rains)
6. open a new tab and click in the URL bar (do not enter anything)

Expected results: Google search history is not showing up Actual results: Google search history shows up

1.open brave://settings/search 2.select any other search engine, e.g. Bing 3.open brave://settings/appearance

4. show autocomplete suggestions in address bar - on
5. select Browsing History, Top sites, and Suggested Sites 6.open a new tab enter few search terms in the URL bar (eg. clouds, rains)
6. open a new tab and click in the URL bar (do not enter anything)

Expected results: Bing search history is not showing up Actual results: Bing search history is not showing up