LaurenWags
commented
1 year ago @brave/qa-team Will fully test this on Windows and macOS, limited/regression checks on Linux.
Closed Miyayes closed 1 year ago
LaurenWags
commented
1 year ago @brave/qa-team Will fully test this on Windows and macOS, limited/regression checks on Linux.
LaurenWags
commented
1 year ago Verified with
Brave | 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (x86_64)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | macOS Version 12.6.2 (Build 21G320)Notes:
| 
| 
| 
| 
| 
| 
| 
| 
| 
1.3 Do not connect to the custodian at the end of onboarding
1.4 Check if non-connected state Rewards panel & NTP Widget appear as expected
Panel initially | Widget initially | Panel after visiting some sites | Widget after visiting some sites
---- | ---- | ---- | ----
| 
| 
| 
1.5 Check brave://rewards settings page to see if it matches designs
Note - see https://github.com/brave/brave-browser/issues/27619 for updated text for first paragraph, as figma does not match this.
1.6 Check brave://settings/rewards to see if it makes sense with non-connected state
1.7 Toggle Brave Private Ads ON/OFF and observe if ON/OFF state of Rewards panel corresponds
Example | Example
---- | ----
| 
1.8 Toggle non-connected Rewards panel ON/OFF and observe if ON/OFF state of Brave Private Ads component in brave://rewards corresponds
Example | Example
---- | ----
| 
1.9 Use an in-line tipping button to check the tipping banner, and ensure the tipping banner matches design spec for non-connected state users (i.e., is “locked”)
Twitter (unverified) | Twitter (verified) | GitHub (unverified) | GitHub (verified) | Reddit (unverified) | Reddit (verified)
---- | ---- | ---- | ---- | ---- | ----
| 
| 
| 
| 
| 
1.10 Navigate to a couple verified sites/channels and check the Rewards panel for count of them. (This is finicky and we have a follow-up issue to make this more reliable - see https://github.com/brave/brave-browser/issues/27907)
Example | Example | Example | Example
---- | ---- | ---- | ----
| 
| 
| 
1.11 Connect to a custodian and verify that user is now in connected state with full Rewards experience
Example | Example
---- | ----
| 
1.12 Try to make a tip to a website to check if tipping banner is now unlocked and that tips are working
Example | Example | Example | Example
---- | ---- | ---- | ----
| 
| 
| 
1.13 Try to trigger an Auto-Contribute
Example | Example | Example | Example
---- | ---- | ---- | ----
| 
| 
| 
1.14 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
Example | Example
---- | ----
| 
1.15 After everything works, reset Brave Rewards
Example | Example | Example
---- | ---- | ----
| 
| 
1.16 Check if Brave Rewards starts from the beginning again. Enable Brave Rewards and check if the Rewards panel looks normal. Don’t need to check anything else.
Example | Example | Example
---- | ---- | ----
| 
| 
| 
| 
2.3 User should now be in full connected state
Example | Example
---- | ----
| 
2.4 Try to make a tip to a website to check if tipping banner is now unlocked and that tips are working
Example | Example | Example | Example
---- | ---- | ---- | ----
| 
| 
| 
2.5 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
Example | Example | Example
---- | ---- | ----
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
3.3 Do not connect to the custodian at the end of onboarding
3.4 Check if non-connected state Rewards panel & NTP Widget appear as expected. Note, after visiting some sites, panel/widget don't display any messaging about supporting creators as in non-JP case. Per discussion via slack with Chris this is expected for now, and he has logged https://github.com/brave/brave-browser/issues/27936 to determine how to handle this.
Panel | Widget
---- | ----
| 
3.5 Check brave://rewards settings page to see if it matches designs
3.6 Check brave://settings/rewards to see if it makes sense with non-connected state
3.7 Toggle Brave Private Ads ON/OFF and observe if ON/OFF state of Rewards panel corresponds
Example | Example
---- | ----
| 
3.8 Toggle non-connected Rewards panel ON/OFF and observe if ON/OFF state of Brave Private Ads component in brave://rewards corresponds
Example | Example
---- | ----
| 
3.9 Use an in-line tipping button to check the tipping banner, and ensure the tipping banner matches design spec for non-connected state users (i.e., is “locked”)
Twitter (unverified) | Twitter (verified) | GitHub (unverified) | GitHub (verified) | Reddit (unverified) | Reddit (verified)
---- | ---- | ---- | ---- | ---- | ----
| 
| 
| 
| 
| 
3.10 Navigate to a couple verified sites/channels and check the Rewards panel for count of them. (This is finicky and we have a follow-up issue to make this more reliable.) - does not work in JP region, see https://github.com/brave/brave-browser/issues/27936
3.11 Connect to a custodian and verify that user is now in connected state with full Rewards experience
3.12 Try to make a tip to a website to check if tipping banner is now unlocked and that tips are working
Example | Example | Example | Example | Example
---- | ---- | ---- | ---- | ----
| 
| 
| 
| 
3.13 Go to brave://rewards page and make sure there is no Auto-Contribute section, since this is Japan.
3.14 Go to brave://settings/rewards and make sure there is no Auto-Contribute section.
3.15 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
Example | Example | Example
---- | ---- | ----
| 
| 
| 
| 
4.4 User should now be in the full connected state.
4.5 Check brave://rewards settings page to see if there’s Auto-Contribute. There should be no A-C since this is Japan.
4.6 Check brave://settings/rewards for anything odd (e.g., check for presence of A-C)
4.7 Try to make a tip to a website to check if tipping banner is now unlocked and that tips are working
Example | Example | Example | Example | Example
---- | ---- | ---- | ---- | ----
| 
| 
| 
| 
4.8 Go to brave://rewards page and make sure there is no Auto-Contribute section, since this is Japan.
4.9 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
Example | Example | Example
---- | ---- | ----
| 
| 
| 
| 
5.3 Don’t complete connecting to custodian and cancel out
5.4 Check if user is in non-connected state
| 
Logs:
```
[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET
........
[ RESPONSE - OnResponse ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.296067,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB"],"block":[]},"uphold":{"allow":["AU","AT","BE","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","unverified":"complete","uphold":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]}}
```
6.3 Check if user is in no-custodian non-connected state (corresponds to row “Custodial services not available in your location” in Figma)
Example | Example | Example
---- | ---- | ----
| 
| 
6.4 Update the Charles Proxy rule to enable US at /parameters for a custodian
6.5 Try to trigger/wait for new /parameters to be fetched by the browser
Logs:
```
[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET
..........
[ RESPONSE - OnResponse ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.296067,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB"],"block":[]},"uphold":{"allow":["AU","AT","BE","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","unverified":"complete","uphold":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]}}
[2489:259:0120/164852.383253:VERBOSE1:api_parameters.cc(90)] Params timer set for 10999 s
```
6.6 Once new /parameters fetched, check to see if user has evolved into the non-connected state with available custodians and matches spec (“Connect your account prompt” row in Figma)
Example | Example | Example | Example
---- | ---- | ---- | ----
| 
| 
| 
6.7 Go and connect a custodian and check if it is successfully linked
Example | Example | Example | Example
---- | ---- | ---- | ----
| 
| 
| 
| 
| 
| 
| 
| 
| 
7.4 Update the Charles Proxy rule to disable US at `/parameters` for all custodians.
7.5 Try to trigger/wait for new `/parameters` to be fetched by the browser
Logs:
```
[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET
.........
[ RESPONSE - OnResponse ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.296067,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB"],"block":[]},"uphold":{"allow":["AU","AT","BE","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","unverified":"complete","uphold":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]}}
```
7.6 Once new `/parameters` are fetched, check to see if the user has evolved into the non-connected state with no available custodians (corresponding to “Custodial services not available in your location row” in Figma).
Example | Example | Example
---- | ---- | ----
| 
| 
| 
| 
| 
| 
8.4 Upgrade Brave to version with Rewards 2.5 Phase 3.
8.5 Check if you’re in the grandfathered-unverified state and that your vBAT balance is still correct.
Example | Example | Example | Example
---- | ---- | ---- | ----
| 
| 
| 
8.6 Send vBAT tip and make a vBAT A-C to check if it still works
Tip:
Example | Example | Example | Example | Example
---- | ---- | ---- | ---- | ----
| 
| 
| 
| 
A-C:
Example | Example | Example | Example | Example | Example | Example
---- | ---- | ---- | ---- | ---- | ---- | ----
| 
| 
| 
| 
| 
| 
8.7 Verify/connect a custodian
8.8 Confirm your vBAT was userdrained to custodial account
Logs:
```
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/bb00bd23-e4ef-519e-9415-4a46f7330dfa/claim
> Method: POST
> Content: {"signedLinkingRequest":"eyJib2R5..........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/bb00bd23-e4ef-519e-9415-4a46f7330dfa/claim
> Result: Success
> HTTP Code: 200
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Method: POST
> Content: {"credentials":[{"publicKey":"aLVWW/utUlOuva9kpzsdb6pah6z0/ubNUWqbacGCEFo=","signature":"FALTjIS..........
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Method: POST
> Content: {"credentials":[{"publicKey":"aLVWW/utUlOuva9kpzsdb6pah6z0/ubNUWqbacGCEFo=","signature":"FALTjISnUJ......
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"4932fa9d-d990-4022-9ff1-32e9225679e8"}
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"ef939eba-4941-4bf1-b332-d1109956ebac"}
```
Example | Example
---- | ----
| 
8.9 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
Example | Example
---- | ----
| 
8.10 Now that you’re verified/connected to a custodian, make a tip and see if it works
Example | Example | Example | Example | Example | Example
---- | ---- | ---- | ---- | ---- | ----
| 
| 
| 
| 
| 
8.11 After everything works, reset Brave Rewards
Example | Example | Example
---- | ---- | ----
| 
| 
8.12 Check if Brave Rewards starts from the beginning again. Enable Brave Rewards and check if the Rewards panel is now the new non-connected state (not grandfathered-unverified). After this point, you don’t need to check anything else.
Example | Example | Example | Example | Example | Example
---- | ---- | ---- | ---- | ---- | ----
| 
| 
| 
| 
| 
| 
9.2 Upgrade your browser to a version containing Rewards 2.5 Phase 3 changes.
Example | Example
---- | ----
| 
9.3 Ensure that you remain in the connected state and that things are working properly (e.g., try a tip and an A-C)
Tip:
Example | Example | Example | Example | Example
---- | ---- | ---- | ---- | ----
| 
| 
| 
| 
A-C:
Example | Example | Example | Example | Example | Example
---- | ---- | ---- | ---- | ---- | ----
| 
| 
| 
| 
| 
9.4 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
Example | Example
---- | ----
| 
9.5 After everything works, reset Brave Rewards
Example | Example | Example
---- | ---- | ----
| 
| 
9.6 Check if Brave Rewards starts from the beginning again. Enable Brave Rewards and check if the Rewards panel is now the new non-connected state. After this point, you don’t need to check anything else.
Example | Example | Example | Example
---- | ---- | ---- | ----
| 
| 
| 
| 
10.4 Upgrade your browser to a version containing Rewards 2.5 Phase 3 changes.
10.5 Ensure that you remain in logged out state (can also check brave://rewards-internals for confirmation)
Example | Example | Example
---- | ---- | ----
| 
| 
10.6 Check if the tipping banner is unlocked (it should be)
Example | Example
---- | ----
| 
10.7 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu.
Example | Example
---- | ----
| 
10.8 Log into your custodian again and make sure you’re properly transitioned to the connected state
Example | Example | Example
---- | ---- | ----
| 
| 
10.9 Once connected again, make a tip to see if it works.
Example | Example | Example | Example | Example | Example
---- | ---- | ---- | ---- | ---- | ----
| 
| 
| 
| 
| 
| 
11.2 Don’t accept UGP grant (just to avoid confusion)
11.3 Upgrade Brave to version with Rewards 2.5 Phase 3.
11.4 Check if you’re in the grandfathered-unverified state
11.5 A-C should not appear in brave://rewards
Example | Example
---- | ----
| 
11.6 A-C should not appear in brave://settings/rewards
11.7 Verify/connect a custodian (bitFlyer)
Example | Example | Example
---- | ---- | ----
| 
| 
11.8 After everything works, reset Brave Rewards
Example | Example | Example
---- | ---- | ----
| 
| 
11.9 Check if Brave Rewards starts from the beginning again. Enable Brave Rewards and check if the Rewards panel is now the new non-connected state (not grandfathered-unverified). After this point, you don’t need to check anything else.
Example | Example | Example | Example
---- | ---- | ---- | ----
| 
| 
| 
| 
| 
12.2 Don’t accept UGP grant (just to avoid confusion)
12.3 Upgrade Brave to version with Rewards 2.5 Phase 3.
12.4 Check if you’re in the new connected state.
Example | Example
---- | ----
| 
12.5 A-C should not appear in brave://rewards
12.6 A-C should not appear in brave://settings/rewards
12.7 After everything works, reset Brave Rewards
Example | Example | Example
---- | ---- | ----
| 
| 
12.8 Check if Brave Rewards starts from the beginning again. Enable Brave Rewards and check if the Rewards panel is now the new non-connected state. After this point, you don’t need to check anything else.
Example | Example | Example | Example
---- | ---- | ---- | ----
| 
| 
| 
| 
13.2 Disable Brave Private Ads.
13.3 Disable Auto-Contribute.
13.4 Upgrade to a version of Brave with Rewards 2.5 Phase 3.
13.5 Ensure that you’re in the grandfathered-unverified state.
13.6 Open tipping banner and make sure that it’s unlocked (since you’re in the grandfathered-unverified state)
Example | Example | Example | Example
---- | ---- | ---- | ----
| 
| 
| 
13.7 Ensure that Brave Private Ads and Auto-Contribute are still disabled and weren’t turned on
14.5 Restart Brave browser
14.6 Go into brave://rewards page, go into settings of individual components and see if things generally seem to appear as working like they used to.
- Logged https://github.com/brave/brave-browser/issues/27990, "Allow contributions for videos" setting does not work any more, but is also not working on previous version, so not related to these changes
- confirmed changes made on brave://rewards are reflected on brave://settings/rewards
14.7 General regression testing of the brave://settings/rewards page and its various toggles.
- confirmed changes made on brave://settings/rewards are reflected on brave://rewards
- confirmed in-line tip buttons can be toggled off from brave://settings/rewards
14.8 Generally keep an eye out for anything that is out of the ordinary based on past Rewards experience.
14.9 After everything works, reset Brave Rewards
14.10 Check if Brave Rewards starts from the beginning again. Enable Brave Rewards and check if the Rewards panel is now the new non-connected state. After this point, you don’t need to check anything else.
Example | Example | Example | Example
---- | ---- | ---- | ----
| 
| 
| 
| 
| 
15.5 Advance your clock to the 8th or later and then relaunch the browser.
15.6 Ask someone on server team, or use Charles Proxy to set the payout status at the staging /parameters endpoint to “processing” for unverified users.
15.7 Make sure that the browser has picked up this new /parameters value.
Logs:
```
[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET
......
[ RESPONSE - OnResponse ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.296067,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB"],"block":[]},"uphold":{"allow":["AU","AT","BE","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","unverified":"processing","uphold":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]}}
```
15.8 Make sure no “processing” banner appears in the Rewards panel, NTP widget, or brave://rewards page.
Example | Example | Example
---- | ---- | ----
| 
| 
15.9 Ask someone on server team, or use Charles Proxy to set the payout status at the staging /parameters endpoint to “complete” for unverified users.
15.10 Make sure that the browser has picked up this new /parameters value.
Logs:
```
[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET
[2903:259:0208/085341.441117:VERBOSE6:logging_util.cc(134)]
[ RESPONSE - OnResponse ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.261167,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US"],"block":[]},"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US","IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"complete","uphold":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-01-19T00:00:00Z","vbatExpired":true}
```
15.11 Make sure no “complete” banner appears in the Rewards panel, NTP widget, or brave://rewards page.
Example | Example | Example
---- | ---- | ----
| 
| 
15.12 Bring your clock back to the current month to 9th or later, and then relaunch the browser, and make sure you also don’t see anything then either.
Example | Example | Example
---- | ---- | ----
| 
| 
| 
| 
16.5 Advance your clock to the 8th or later and then relaunch the browser.
16.6 Ask someone on server team, or use Charles Proxy to set the payout status at the staging /parameters endpoint to “processing” for unverified users.
16.7 Make sure that the browser has picked up this new /parameters value.
Logs:
```
[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET
......
[ RESPONSE - OnResponse ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.261167,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US"],"block":[]},"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US","IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"processing","uphold":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-01-19T00:00:00Z","vbatExpired":true}
```
16.8 Make sure the “processing” banner APPEARS in the Rewards panel, NTP widget, and brave://rewards page. - FAILED, banner does not appear as expected:
Example | Example | Example
---- | ---- | ----
| 
| 
16.9 Ask someone on server team, or use Charles Proxy to set the payout status at the staging /parameters endpoint to “complete” for unverified users.
16.10 Make sure that the browser has picked up this new /parameters value.
Logs:
```
[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET
[3896:259:0208/093501.525166:VERBOSE6:logging_util.cc(134)]
[ RESPONSE - OnResponse ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.260985,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US"],"block":[]},"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US","IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"complete","uphold":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-01-19T00:00:00Z","vbatExpired":true}
```
16.11 Make sure the “complete” banner APPEARS in the Rewards panel, NTP widget, or brave://rewards page. - FAILED, does not show as expected:
Example | Example | Example
---- | ---- | ----
| 
| 
16.12 Bring your clock back to the current month to 9th or later, and then relaunch the browser, and make sure you don’t see the banners (because it’s the wrong month)
Example | Example | Example
---- | ---- | ----
| 
| 
Logs:
```
[4687:259:0124/101421.320639:VERBOSE1:redeem_unblinded_payment_tokens.cc(139)] OnRedeemUnblindedPaymentTokens
[4687:259:0124/101421.320744:VERBOSE6:redeem_unblinded_payment_tokens.cc(141)] URL Response:
URL: https://mywallet.ads.bravesoftware.com/v3/confirmation/payment/9e1fb591-488f-513c-9db7-c9d0d3cd41d4
Response Status Code: 200
Response: {"message":"Ok","status":200}
```
17.4 Advance clock to the next month to the 2nd (or between 1st and 7th), and then relaunch the browser, to see if you see any “Payout will arrive in x days” banner”. You SHOULD SEE this banner. Close browser.
Example | Example | Example
---- | ---- | ----
| 
| 
17.5 Advance your clock to the 8th or later and then relaunch the browser.
17.6 Ask someone on server team, or use Charles Proxy to set the payout status at the staging /parameters endpoint to “processing” for Uphold users/payout status.
17.7 Make sure that the browser has picked up this new /parameters value.
Logs:
```
[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET
[4991:259:0208/101914.132505:VERBOSE6:logging_util.cc(134)]
[ RESPONSE - OnResponse ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.261167,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US"],"block":[]},"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US","IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"complete","uphold":"processing"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-01-19T00:00:00Z","vbatExpired":true}
```
17.8 Make sure the “processing” banner APPEARS in the Rewards panel, NTP widget, and brave://rewards page. - FAILED, appears on panel and rewards page, but not NTP widget. Logged follow up issue https://github.com/brave/brave-browser/issues/28006.
Example | Example | Example
---- | ---- | ----
| 
| 
17.9 Ask someone on server team, or use Charles Proxy to set the payout status at the staging /parameters endpoint to “complete” for Uphold users/payout status.
17.10 Make sure that the browser has picked up this new /parameters value.
Logs:
```
[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET
[5119:259:0208/102136.827925:VERBOSE6:logging_util.cc(134)]
[ RESPONSE - OnResponse ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.26234,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US"],"block":[]},"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US","IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"complete","uphold":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-01-19T00:00:00Z","vbatExpired":true}
```
17.11 Make sure the “complete” banner APPEARS in the Rewards panel, NTP widget, or brave://rewards page. - FAILED, appears on panel and rewards page, but not NTP widget. Logged follow up issue https://github.com/brave/brave-browser/issues/28006.
Example | Example | Example
---- | ---- | ----
| 
| 
17.12 Bring your clock back to the current month to 9th or later, and then relaunch the browser, and make sure you don’t see the banners (because it’s the wrong month)
Example | Example | Example
---- | ---- | ----
| 
| 
Logs (just a few to show how the failure worked):
```
[6035:259:0124/111017.933120:VERBOSE1:redeem_unblinded_token.cc(136)] OnFetchPaymentToken
[6035:259:0124/111017.933211:VERBOSE6:redeem_unblinded_token.cc(138)] URL Response:
URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/f270f275-cc77-4b86-87ab-d72329c3ad80/paymentToken
Response Status Code: 500
Response: {}
.....
[6035:259:0124/111017.933409:VERBOSE1:redeem_unblinded_token.cc(167)] Failed to fetch payment token
[6035:259:0124/111017.933475:VERBOSE1:redeem_unblinded_token.cc(382)] Failed to redeem unblinded token view confirmation for ad_notification with transaction id f270f275-cc77-4b86-87ab-d72329c3ad80 and creative instance id 40f9f892-2eee-4b8f-8bde-45915ae2fd88
[6035:259:0124/111017.933535:VERBOSE9:confirmation_state_manager.cc(359)] Saving confirmations state
[6035:259:0124/111017.933665:VERBOSE1:confirmations.cc(42)] Added view confirmation for ad_notification with transaction id f270f275-cc77-4b86-87ab-d72329c3ad80 and creative instance id 40f9f892-2eee-4b8f-8bde-45915ae2fd88 to the confirmations queue
[6035:259:0124/111017.934550:VERBOSE1:refill_unblinded_tokens.cc(99)] No need to refill unblinded tokens as we already have 49 unblinded tokens which is above the minimum threshold of 20
[6035:259:0124/111017.935315:VERBOSE1:confirmations.cc(135)] Retry sending failed confirmations in 0 hours, 0 minutes, 3 seconds at 11:10:20.934
......
[6035:259:0124/111021.038943:VERBOSE1:redeem_unblinded_token.cc(136)] OnFetchPaymentToken
[6035:259:0124/111021.039034:VERBOSE6:redeem_unblinded_token.cc(138)] URL Response:
URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/f270f275-cc77-4b86-87ab-d72329c3ad80/paymentToken
Response Status Code: 500
Response: {}
......
[6035:259:0124/111021.039108:VERBOSE1:redeem_unblinded_token.cc(167)] Failed to fetch payment token
[6035:259:0124/111021.039129:VERBOSE1:redeem_unblinded_token.cc(382)] Failed to redeem unblinded token view confirmation for ad_notification with transaction id f270f275-cc77-4b86-87ab-d72329c3ad80 and creative instance id 40f9f892-2eee-4b8f-8bde-45915ae2fd88
[6035:259:0124/111021.039202:VERBOSE9:confirmation_state_manager.cc(359)] Saving confirmations state
[6035:259:0124/111021.039307:VERBOSE1:confirmations.cc(42)] Added view confirmation for ad_notification with transaction id f270f275-cc77-4b86-87ab-d72329c3ad80 and creative instance id 40f9f892-2eee-4b8f-8bde-45915ae2fd88 to the confirmations queue
[6035:259:0124/111021.040023:VERBOSE1:refill_unblinded_tokens.cc(99)] No need to refill unblinded tokens as we already have 49 unblinded tokens which is above the minimum threshold of 20
[6035:259:0124/111021.040604:VERBOSE1:confirmations.cc(135)] Retry sending failed confirmations in 0 hours, 1 minute, 3 seconds at 11:11:24.039
....
etc
```
18.3 Set the API payout status to "Complete" through Charles or ask server team
Logs:
```
[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET
........
[ RESPONSE - OnResponse ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.264416,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US"],"block":[]},"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US","IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"complete","uphold":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-01-19T00:00:00Z","vbatExpired":true}
```
18.4 Advance the system clock to the next month (sometime 1st to 7th) and relaunch the browser.
18.5 Countdown banner should NOT show.
Example | Example | Example
---- | ---- | ----
| 
| 
18.6 Move clock to 8th or later (only change the day, not the month – keep month as the one set in step 18.4) and relaunch the browser. Payout arrived (“complete”) message should NOT be shown to the user.
Example | Example | Example
---- | ---- | ----
| 
| 
Brave | 1.48.139 Chromium: 109.0.5414.87 (Official Build) beta (x86_64)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | macOS Version 12.6.3 (Build 21G419
| 
3. connect to a US Uphold account
4. make sure:
- kNotConnected ==> kConnected (uphold) appears in brave://rewards-internals / Event logs
- Rewards state: Verified appears in brave://rewards-internals / General info
Example | Example
---- | ----
| 
5. go to your Uphold account and expire the access token (i.e. remove the Brave Browser integration)
6. make sure:
- kConnected ==> kLoggedOut (uphold) appears in brave://rewards-internals / Event logs
- Rewards state: Disconnected (Verified) appears in brave://rewards-internals / General info
Example | Example
---- | ----
| 
7. reconnect to your Uphold account
8. make sure:
- kLoggedOut ==> kConnected (uphold) appears in brave://rewards-internals / Event logs
- Rewards state: Verified appears in brave://rewards-internals / General info
Example | Example
---- | ----
| 
9. change the Uphold GET /v0/me endpoint’s response with Charles proxy, so that currencies does not contain BAT
10. wait ~15 minutes for toast notification to appear
11. make sure:
- kConnected ==> kLoggedOut (uphold) appears in brave://rewards-internals / Event logs
- Rewards state: Disconnected (Verified) appears in brave://rewards-internals / General info
Example | Example
---- | ----
| 
12. Remove Charles Proxy rewrite rule and reconnect to your Uphold account
13. make sure:
- kNotConnected ==> kConnected (uphold) appears in brave://rewards-internals / Event logs
- Rewards state: Verified appears in brave://rewards-internals / General info
Example | Example
---- | ----
| 
14. change the GET /v0/me/capabilities endpoint’s response with Charles proxy, so that "enabled": false for either "key": "receives", or "key": "sends" (or both).
Here's the snippet I modified (note, this is _not_ the entire snippet, just the part I changed. The _whole_ body must be in your Charles Proxy rewrite):
```
{
"category": "permissions",
"enabled": false,
"key": "receives",
"name": "Receives",
"requirements": [],
"restrictions": []
},
```
15. wait ~15 minutes for the toast notification to appear:
16. make sure:
- kConnected ==> kLoggedOut (uphold) appears in brave://rewards-internals / Event logs
- Rewards state: Disconnected (Verified) appears in brave://rewards-internals / General info
Example | Example
---- | ----
| 
| 
3. connect to a US Gemini account
4. make sure:
- kNotConnected ==> kConnected (gemini) appears in brave://rewards-internals / Event logs
- Rewards state: Verified appears in brave://rewards-internals / General info
Example | Example
---- | ----
| 
5. go to your Gemini account and expire the access token (i.e. remove the Brave Browser integration)
6. make sure:
- kConnected ==> kLoggedOut (gemini) appears in brave://rewards-internals / Event logs
- Rewards state: Disconnected (Verified) appears in brave://rewards-internals / General info
Example | Example
---- | ----
| 
7. reconnect to your Gemini account
8. make sure:
- kLoggedOut ==> kConnected (gemini) appears in brave://rewards-internals / Event logs
- Rewards state: Verified appears in brave://rewards-internals / General info
Example | Example
---- | ----
| 
| 
3. connect to a JP bitFlyer account (note time)
4. make sure:
- kNotConnected ==> kConnected (bitflyer) appears in brave://rewards-internals / Event logs
- Rewards state: Verified appears in brave://rewards-internals / General info
Example | Example
---- | ----
| 
5. Wait at least 7 minutes since step 3, then attempt to tip a bitFlyer verified creator
6. make sure:
- kConnected ==> kLoggedOut (bitflyer) appears in brave://rewards-internals / Event logs
- Rewards state: Disconnected (Verified) appears in brave://rewards-internals / General info
Example | Example
---- | ----
| 
7. reconnect to your bitFlyer account
8. make sure:
- kLoggedOut ==> kConnected (bitflyer) appears in brave://rewards-internals / Event logs
- Rewards state: Verified appears in brave://rewards-internals / General info
Example | Example
---- | ----
| 
--------
Option 2:
1. Clean profile, staging env
2. Close and relaunch to get griffin seed
3. Enable Rewards, choose a country that does not match your Gemini account (I have a US account, so chose Canada as my country)
4. Link KYC'd US Gemini account
5. Confirm expected error modal is shown
```
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/gemini/8de38f4d-d591-50b3-944d-9425c2085b3c/claim
> Method: POST
> Content: {"linking_info":"eyJ0eX.............
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/gemini/8de38f4d-d591-50b3-944d-9425c2085b3c/claim
> Result: Failure
> HTTP Code: 400
> Body: {"code":400,"message":"error linking wallet: mismatched provider account regions: geo reset is different"}
```
GeetaSarvadnya
commented
1 year ago Verification PASSED on
Brave | 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 10 Version 21H2 (Build 19044.2486)
Verification INPROGRESS on Samsung Galaxy Verion 12 running Bravemonoarm64.apk_1.48.141
LaurenWags
commented
1 year ago note - Android has its own issue, https://github.com/brave/brave-browser/issues/27055, so we will be putting verification notes there 👍🏻
MadhaviSeelam
commented
1 year ago Verification PASSED using
Brave 1.48.152 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS LinuxLimited QA verification has been done in Linux for this issue as below:
btlechowski
commented
1 year ago Verification passed on
| Brave | 1.48.149 Chromium: 109.0.5414.119 (Official Build) beta (64-bit) |
|---|---|
| Revision | 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458} |
| OS | Ubuntu 18.04 LTS |
Ads testing
Description
Update Rewards states