supermassive
commented
1 year ago @ShivanKaul, please adjust wording
Closed supermassive closed 1 year ago
supermassive
commented
1 year ago @ShivanKaul, please adjust wording
ShivanKaul
commented
1 year ago UD:
Brave will be using Infura to resolve .crypto (and also .x, .coin, .nft, .dao, .wallet, .blockchain, .bitcoin, .zil) domain names that are on Unstoppable Domains. Brave hides your IP address. If you enable this, Infura will see that someone is trying to visit these domains but nothing else. See Infura's <ph name="BEGIN_INFURA_TOU_LINK"><a target="_blank" href="$1"></ph>terms of use<ph name="END_INFURA_TOU_LINK"></a></ph> and <ph name="BEGIN_INFURA_PRIVACY_LINK"><a target="_blank" href="$2"></ph>privacy policy<ph name="END_INFURA_PRIVACY_LINK"></a></ph>.
ENS:
Brave will be using Infura to resolve .eth domain names that are on Ethereum Name Service (ENS). Brave hides your IP address. If you enable this, Infura will see that someone is trying to visit these .eth domains but nothing else. See Infura's <ph name="BEGIN_INFURA_TOU_LINK"><a target="_blank" href="$1"></ph>terms of use<ph name="END_INFURA_TOU_LINK"></a></ph> and <ph name="BEGIN_INFURA_PRIVACY_LINK"><a target="_blank" href="$2"></ph>privacy policy<ph name="END_INFURA_PRIVACY_LINK"></a></ph>.
ENS L2:
This .eth domain name is stored offchain and will be resolved by a third party gateway. If you enable ENS offchain lookup, the third party gateway will see that you're trying to visit the .eth domain. <ph name="BEGIN_BRAVE_LEARN_MORE_LINK"><a target="_blank" href="$1"></ph>Learn more<ph name="END_BRAVE_LEARN_MORE_LINK"></a></ph>.
SNS:
Brave will be using Coinbase Cloud to resolve .sol domain names. Brave hides your IP address. If you enable this, Coinbase will see that someone is trying to visit these .sol domains but nothing else. See Coinbase Cloud's <ph name="BEGIN_COINBASE_TOU_LINK"><a target="_blank" href="$1"></ph>terms of use<ph name="END_COINBASE_TOU_LINK"></a></ph> and <ph name="BEGIN_COINBASE_PRIVACY_LINK"><a target="_blank" href="$2"></ph>privacy policy<ph name="END_COINBASE_PRIVACY_LINK"></a></ph>.
ShivanKaul
commented
1 year ago @PrivacyMatters can you take a look here as well. I haven't reviewed the boilerplate around privacy policy or Learn More URLs, I'm guessing that's the same as before (which is fine by me).
ShivanKaul
commented
1 year ago @diracdeltas if you could take a quick look as well, given that you'd reviewed some of the original Web3 domain resolution PRs.
PrivacyMatters
commented
1 year ago Hi @ShivanKaul we should only say 'Brave protects your IP address' if it is proxied and isn't passed to the third parties.
As for whether we need to say Terms - if it's not an issue to leave it in. I am not sure if the contracts require it.
ShivanKaul
commented
1 year ago @supermassive this should be good to ship!
srirambv
commented
1 year ago Verification passed on
| Brave | 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (64-bit) |
|---|---|
| Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241} |
| OS | Linux |
| UD | ENS | ENS L2 | SNS |
|---|---|---|---|
 |
 |
 |
 |
Verification passed on
| Brave | 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (64-bit) |
|---|---|
| Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241} |
| OS | Windows 11 Version 22H2 (Build 22621.755) |
| UD | ENS | ENS L2 | SNS |
|---|---|---|---|
 |
 |
 |
 |
Verification passed on
| Brave | 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (arm64) |
|---|---|
| Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241} |
| OS | macOS Version 13.0 (Build 22A380) |
| UD | ENS | ENS L2 | SNS |
|---|---|---|---|
 |
 |
 |
 |
Per https://github.com/brave/security/issues/1099#issuecomment-1334698536
Current wording for interstitials is:
UD:
Brave will be using Infura to issue Ethereum JSON-RPC calls to the smart contract from Unstoppable Domains to resolve .crypto (and also .x, .coin, .nft, .dao, .wallet, .blockchain, .bitcoin, .zil) domain name lookup requests. If you enable this, Infura will see those specific domains that you're trying to visit but they will not be able to see other domains. See Infura's <ph name="BEGIN_INFURA_TOU_LINK"><a target="_blank" href="$1"></ph>terms of use<ph name="END_INFURA_TOU_LINK"></a></ph> and <ph name="BEGIN_INFURA_PRIVACY_LINK"><a target="_blank" href="$2"></ph>privacy policy<ph name="END_INFURA_PRIVACY_LINK"></a></ph>.ENS:
Brave will be using Infura to issue Ethereum JSON-RPC calls to the smart contract from Ethereum Name Service to resolve .eth domain name lookup requests. If you enable this, Infura will see the .eth domain that you're trying to visit but they will not be able to see other domains. See Infura's <ph name="BEGIN_INFURA_TOU_LINK"><a target="_blank" href="$1"></ph>terms of use<ph name="END_INFURA_TOU_LINK"></a></ph> and <ph name="BEGIN_INFURA_PRIVACY_LINK"><a target="_blank" href="$2"></ph>privacy policy<ph name="END_INFURA_PRIVACY_LINK"></a></ph>.ENS L2:
Brave will be using offchain gateways to resolve .eth domain name lookup requests. If you enable this, third party gateways will see the .eth domain that you're trying to visit but they will not be able to see other domains. <ph name="BEGIN_BRAVE_LEARN_MORE_LINK"><a target="_blank" href="$1"></ph>Learn more<ph name="END_BRAVE_LEARN_MORE_LINK"></a></ph>.SNS:
Brave will be using Coinbase Cloud to issue Solana JSON-RPC calls to the program from Solana Name Service to resolve .sol domain name lookup requests. If you enable this, Coinbase Cloud will see the .sol domain that you're trying to visit but they will not be able to see other domains. See Coinbase Cloud's <ph name="BEGIN_COINBASE_TOU_LINK"><a target="_blank" href="$1"></ph>terms of use<ph name="END_COINBASE_TOU_LINK"></a></ph> and <ph name="BEGIN_COINBASE_PRIVACY_LINK"><a target="_blank" href="$2"></ph>privacy policy<ph name="END_COINBASE_PRIVACY_LINK"></a></ph>.