search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.92k stars 2.34k forks source link

Geo declaration country selection dropdown is empty #27147

Open Miyayes opened 1 year ago

Miyayes commented 1 year ago

Description

Report: https://www.reddit.com/r/BATProject/comments/zaoe4m/rewards_asking_me_to_select_my_country_but_the/

  • Windows 10 Home
  • 1.46.133
  • I didn't do anything, must've been an auto update

Another case says:

I'm having the same issue. 1.) Windows 2.) Most up-to-date Version 1.46.133 Chromium: 108.0.5359.71 (Official Build) (64-bit) 3.) Auto-update I do use a vpn btw (issue persists with it off)

image

Another screenshot, but this time contains "Select country" string but no countries:

image

A handful of other cases were on old versions of Windows that aren't supported anymore (like Win 7). But users in cases above said they are on Win 10.

szilardszaloki commented 1 year ago

I haven't been able to find anything that would explain what we see on the screenshot above. If we were populating the country codes incorrectly, at least the placeholder text ("Select country") would be shown as the first <option> of the <select>:

image1 image2

This might also be an upstream bug: Version 108 breaks html select behavior. The reported version there is Chromium 108.0.5359.72 and while we shipped v1.46.133 with Chromium 108.0.5359.71, it was verified that https://chromium-review.googlesource.com/c/chromium/src/+/3792529 (from late September) caused the regression.

Miyayes commented 1 year ago

@szilardszaloki Other users do see "Select country" string but no countries, such as this case: https://community.brave.com/t/unable-to-select-your-country-with-brave-rewards/451282 image

Miyayes commented 1 year ago

For users suffering from this issue, please try updating to version 1.47.x of Brave.

Geiseku commented 1 year ago

Same issue is still present for me on Version 1.47.171 Chromium: 109.0.5414.87 (Official Build) (64-bit)

Miyayes commented 1 year ago

@Geiseku Can you try creating a new browser profile and seeing if the declaration works there?

Also, on your current profile, can you go into brave://rewards-internals (general info tab)? Does it say "Rewards profile not yet created", or anything like "invalid"? Or does everything look normal? Thanks.

Geiseku commented 1 year ago

@Miyayes on my current profile when going to brave://rewards-internals it says "Rewards profile not yet created"

I created a new profile and everything worked properly on that.

Miyayes commented 1 year ago

@Geiseku Okay, so that's the issue. Do you have any significant balance on your main profile? If not, I recommend just resetting your Brave Rewards profile and starting anew. Your existing profile must be corrupted in some way. Question: Did you ever copy-paste profile folders around between installations? Just trying to figure out how the corruption could have happened.

cc: @brave/rewards-client

Geiseku commented 1 year ago

@Miyayes I had a trivial balance on my previous profile so just running on the new one now. I haven't touched the profile folders at all since building this PC in Oct 2019. The only significant change was an in-place upgrade to Windows 11 in June 2022.

Miyayes commented 1 year ago

@Geiseku Thank you for the investigation. If you haven a Uphold or Gemini account, please let us know. We'd be happy to send you some BAT as a refund.

in-place upgrade to Windows 11 in June 2022.

This is actually very telling, plus the fact that maybe your profile is quite old (and maybe you didn't launch Brave for a long time)? There was a known issue in the past where upgrading Windows could corrupt the Rewards profile. In old versions of Brave, Rewards profile data was encrypted by OS encryption. Updating Windows in some cases would change the OS encryption key, so would basically render the Rewards profile corrupt.

Geiseku commented 1 year ago

@Miyayes I do have an Uphold account but having issues verifying it at the moment. I've been using Brave daily since before this PC was built, so the profile was definitely regularly in use when I did the Windows 11 upgrade in June. I didn't notice the issue with rewards until some time later, although I did move house in July and could have missed it. It's interesting that the corruption presents as an inability to list the countries for selection.

rvanee10 commented 1 year ago

@Miyayes I have the same problem on my current profile, with no country list presented in the pulldown. The page brave://rewards-internals says "Rewards profile not yet created". Similar diagnostic.....I created another profile and the country list does show when turning rewards on. However, I have a significant amount in my original profile (or should have), as I have been on Brave rewards for multiple years. Is there a way out of this?

Miyayes commented 1 year ago

@rvanee10 Thanks for confirming. Do you have an Uphold or Gemini account?

rvanee10 commented 1 year ago

I should have mentioned that i do have an Uphold account, but it is unverified.

Miyayes commented 1 year ago

Let's take this to email if that's OK, since it's specific to your case @rvanee10. My email is christopher@brave.com.

lguyaux commented 1 year ago

Hello, I have the same issue. So, only option is to reset the account ?

Miyayes commented 1 year ago

Hello, I have the same issue. So, only option is to reset the account ?

Create a different browser profile and try in there first. If it works there, then it's probably just a profile-level issue. But yes, in general, it seems like this issue is due to some kind of profile corruption, so you'll need to reset your Brave Rewards profile by going to brave://rewards > Manage.

lguyaux commented 1 year ago

Hello, I have the same issue. So, only option is to reset the account ?

Create a different browser profile and try in there first. If it works there, then it's probably just a profile-level issue. But yes, in general, it seems like this issue is due to some kind of profile corruption, so you'll need to reset your Brave Rewards profile by going to brave://rewards > Manage.

Ok thanks, it does work now !

Is there any way to recover old funds? I didn't have much but have been using since the beginning of Brave so quite sad to lose everything :/

Miyayes commented 1 year ago

Hello, I have the same issue. So, only option is to reset the account ?

Create a different browser profile and try in there first. If it works there, then it's probably just a profile-level issue. But yes, in general, it seems like this issue is due to some kind of profile corruption, so you'll need to reset your Brave Rewards profile by going to brave://rewards > Manage.

Ok thanks, it does work now !

Is there any way to recover old funds? I didn't have much but have been using since the beginning of Brave so quite sad to lose everything :/

Do you have an Uphold or Gemini or bitFlyer account?