Implement NFT Details screen

srirambv commented 1 year ago

Description

Can't open NFT's added via token registry

Steps to reproduce

Install 1.4.125 build
Add a CryptoKitties NFT or Punks Comic NFT's
Go back to portfolio and click on the NFT added in step 2, doesn't load the NFT details view

Actual result

Can't open NFT's added via token registry

Expected result

Should open NFT details view

Issue reproduces how often

Easy

Version/Channel Information:

Can you reproduce this issue with the current Play Store version? NA
Can you reproduce this issue with the current Play Store Beta version? Yes
Can you reproduce this issue with the current Play Store Nightly version? Not checked

Device details

Install type (ARM, x86): ARM
Device type (Phone, Tablet, Phablet): All
Android version: 12

Brave version

1.47.125 x64 Beta

Website problems only

Does the issue resolve itself when disabling Brave Shields? NA
Does the issue resolve itself when disabling Brave Rewards?NA
Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @wchen342 @Pavneet-Sing

srirambv commented 1 year ago

This seems to be an issue for other tokens as well

https://user-images.githubusercontent.com/17010094/207064978-9afbb8f0-2e4a-4d3d-b844-3616ac9388f1.mp4

wchen342 commented 1 year ago

Isn't that what supposed to happen because of https://github.com/brave/brave-browser/issues/23507? Disable NFT details until portfolio page is implemented.

srirambv commented 1 year ago

Ok yes I hadn't checked the test plan for #23507. Do I keep the issue open and we can use this for NFT details view or do we have an open issue in which case I can close this one as invalid

wchen342 commented 1 year ago

I don't think there is another issue for this so please keep it open. Maybe change the title to something like "implement NFT portfolio page"?

Pavneet-Sing commented 1 year ago

Likely a dupe of NFT asset details screen

brave / brave-browser