search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.9k stars 2.34k forks source link

[Shields] Please rename right click - Block Element to Element Picker or something better. #27313

Open ghost opened 1 year ago

ghost commented 1 year ago

Hi,

I suggest Element Picker or Enter Element Picker mode (like uBlock's extension panel) or Create Cosmetic filter or Create Element Hiding filter or anything like that would reflect the reality of what it is doing.

This is because "Block Element" only does Cosmetic Filtering, and Cosmetic Filtering doesn't block anything, it doesn't do anything privacy wise and all Cosmetic filters do you may know, it is only visually removing a DOM element by applying a css property display: none !important to the selected element, which means, if it is an image, the image got downloaded anyway, but it is hidden in the end, so nothing was blocked. Many pages even have some Generic cosmetic that will show when the page loads and then get hidden afterwards, because elements are only being hidden from people's eyes.

I think the main problem is that when people report issues with the Adblock or compare it to other adblocker they use the "Brave doesn't Block X or Y ad" when in most cases it will be a clearly cosmetic filter's problem, and a button with the text Block Element on it, doesn't help and actually mislead people from truly understand Adblock or give better feedback about it. Like Procedural Cosmetics, they are not available in Brave but people keep saying how "uBlock is better because it blocks more ads" but the reality is that 99% of the times people say that, they are referring to Cosmetics. And I hate to see that.

And yes, I see the same mistake in uBlock and Adguard, because while uBlock can do some basic network filters with their element picker, these features are meant for creating Cosmetic filters 99.9999% of the time, which means they never block anything even if they wrongly still use that term, and even if uBlock has a wiki page just to talk how Cosmetics don't block and only hides them.

But Blocking is Blocking and Hiding is Hiding, so I think the text should be changed to something that reflects the reality of the features instead of following the wrong doings from other adblockers, especially on Brave where the "Block Element" is doing cosmetic filters only.

Thank you.

antonok-edm commented 1 year ago

Fair points. Although "element picker" and "cosmetic filter" are maybe too technical to be useful for some users.

@rebron do you think "Hide element" would work better here?