lukemulks
commented
1 year ago Hi all - just made a swap with COMP from the screenshot above in Nightly
1.49.27 Chromium: 109.0.5414.87 (Official Build) nightly (64-bit)
Confirming that the issue with no notional USD value displaying still persists.
Unable to repro any longer as COMP was the only asset where this was observed, but wanted to note that the issue still persisted with this version in case we see others reporting on it.
cc'ing @onyb && @Douglashdaniel in case either of you all are seeing similar or are looking for visibility.
Douglashdaniel
Please let me know if this is fixed for you!
Description
This issue may possibly be related / duplicate of https://github.com/brave/brave-browser/issues/23029, but am opening an issue here with more detail specific to what I've encountered as #23029 lacks some of the same detail that I'm observing directly.
I've been encountering this on: Windows 10 Brave Nightly 1.48.61 Chromium: 109.0.5414.46 (Official Build) nightly (64-bit)
Two parts to this particular issue (which could potentially be split into 2 separate issues, but will let the team determine if that's best for this case).
Part 1: Some asset quantities and values take ~10-15 seconds to display in Portfolio view; noticeably longer than the rest of the assets that load quantity and value quickly.
When I load
brave://walletand authenticate into portfolio view, more than one asset will have the quantity and value display in the loading state (gray box, when in dark mode).Typically, the assets where I observe this are multichain, from L1s and EVMs (most often, I see this with MATIC, but also observe with Solana assets - both native SOL and wormhole/portal wrapped assets, and other SPLs).
That said, after ~10-15 seconds, those assets that had been attempting to load the values and quantities will eventually populate in portfolio view.
Suspect this could be either a lag with multichain lookups, or potentially too many API requests to populate from Coingecko (there are 27 assets that display in portfolio view in my instance). Those are shots in the dark on my part, but hopefully context helps.
Part 2: This is the worse of two parts of this issue - The notional USD value for $COMP never loads in my Portfolio view, and does not display in the aggregate view when I drill down into the asset from the main portfolio view.
I added $COMP to my wallet account around November 8th, IIRC, and the notional USD value has not loaded after adding the asset to my Wallet (manual addition, as it was not auto-discovered in early Nov).
The notional USD value for COMP appears to be in a permanently "loading" state; I've re-authed, and kept Wallet in active state for a very long time. Neither attempts resulted in the asset displaying the notional USD value in the main Portfolio view.
The most alarming byproduct of this issue occurs when drilling down into the individual asset view. The topline aggregate info that displays for the asset displays as a 0 value and %-change, with a flat green line to the user. This is very alarming for a user who knows they have an asset at their address (because they may have confirmed it on-chain, or elsewhere). Within the individual asset view, the sub-view broken out per account does display the accurate quantity but does not display the notional USD value of COMP for the appropriate account in the account list; however, that quantity displays below the chart, with smaller font and is not reflected in the prominent aggregate value that displays at the top with the chart. This is one of those bugs that's likely to challenge a user's faith in their wallet, as they may be less likely to transact with a wallet that does not accurately display their assets as expected.
I'm only observing this with the $COMP asset, which again, was added manually to my wallet in early Nov. That said, I don't suspect this is user error, as the appropriate notional values display within the account asset subview noted above, and the quantity persists accurately across different portfolio views.
Aside from Portfolio views above, it's noteworthy that the COMP notional USD values and quantity do display as expected within the Swap view in the UI. This only appears to be impacting my Wallet from the Portfolio, and from the individual Asset view within Portfolio.
Steps to Reproduce
Actual result:
$COMP notional USD value in persistent loading state (brave://wallet/crypto/portfolio)
From brave://wallet/crypto/portfolio, click to drill down into the individual asset view for $COMP (brave://wallet/crypto/portfolio/0xc00e94Cb662C3520282E6f5717214004A7f26888)
Expected result:
Part 1: Assets should load quickly, and together; the delay for some assets introduces a subpar UX that our competitors do not replicate.
Part 2: Even with some initial delay, assets should notional USD (or other inferred local native notional value for user country) notional value within portfolio aggregate and individual asset views, and should not be stuck in persistent loading state.
Reproduces how often:
100% for me, since beginning of November. Was out of sight (below the fold) so had assumed that it eventually loaded, until I re-tested after observing persistent loading state late last week.
Brave version (brave://version info)
Brave Nightly 1.48.61 Chromium: 109.0.5414.46 (Official Build) nightly (64-bit)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @husobee @jamesmudgett