search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.87k stars 2.34k forks source link

cant start browser after successful npm run build #27552

Open NaaeemMalik opened 1 year ago

NaaeemMalik commented 1 year ago

Description

whenever I do npm start or manually run brave.exe on windows 11, it opens but unresponsive and just closes itsself without me doing anything. it prints this on screen:

brave-core@1.48.90 start node ./build/commands/scripts/commands.js start

F:\Turkeye\src\out\Component\brave.exe --enable-logging --v=0 --disable-brave-update [10772:18076:1228/103708.902:FATAL:request_sender.cc(89)] Check failed: cururl->is_valid(). Backtrace: base::debug::CollectStackTrace [0x00007FFD185395F2+18] (F:\Turkeye\src\base\debug\stack_trace_win.cc:329) base::debug::StackTrace::StackTrace [0x00007FFD183E9E82+18] (F:\Turkeye\src\base\debug\stack_trace.cc:218) logging::LogMessage::~LogMessage [0x00007FFD1840B9E2+178] (F:\Turkeye\src\base\logging.cc:719) logging::LogMessage::~LogMessage [0x00007FFD1840D210+16] (F:\Turkeye\src\base\logging.cc:712) update_client::RequestSender::SendInternal [0x00007FFD0BAF26A9+1417] (F:\Turkeye\src\components\update_client\request_sender.cc:89) update_client::RequestSender::Send [0x00007FFD0BAF1F05+283] (F:\Turkeye\src\components\update_client\request_sender.cc:84) update_client::anonymous namespace'::UpdateCheckerImpl::CheckForUpdatesHelper [0x00007FFD0ADAE650+4048] (F:\Turkeye\src\components\update_client\update_checker.cc:227) base::internal::Invoker<base::internal::BindState<void (update_client::(anonymous namespace)::UpdateCheckerImpl::*)(scoped_refptr<update_client::UpdateContext>, const std::Cr::vector<GURL,std::Cr::allocator<GURL> > &, const base::flat_map<std::Cr::basic_s [0x00007FFD0ADAEA9A+58] (F:\Turkeye\src\base\functional\bind_internal.h:874) base::OnceCallback<void (const base::flat_map<std::Cr::basic_string<char,std::Cr::char_traits<char>,std::Cr::allocator<char> >,std::Cr::basic_string<char,std::Cr::char_traits<char>,std::Cr::allocator<char> >,std::Cr::less<void>,std::Cr::vector<std::Cr::pa [0x00007FFD0ADB0513+73] (F:\Turkeye\src\base\functional\callback.h:175) base::internal::FunctorTraits<base::OnceCallback<void (const base::flat_map<std::Cr::basic_string<char,std::Cr::char_traits<char>,std::Cr::allocator<char> >,std::Cr::basic_string<char,std::Cr::char_traits<char>,std::Cr::allocator<char> >,std::Cr::less<voi [0x00007FFD0ADB0485+53] (F:\Turkeye\src\base\functional\bind_internal.h:749) base::OnceCallback<void (const std::Cr::set<std::Cr::basic_string<char,std::Cr::char_traits<char>,std::Cr::allocator<char> >,std::Cr::less<std::Cr::basic_string<char,std::Cr::char_traits<char>,std::Cr::allocator<char> > >,std::Cr::allocator<std::Cr::basic [0x00007FFD0A71DF70+66] (F:\Turkeye\src\base\functional\callback.h:175) base::internal::FunctorTraits<base::OnceCallback<void (const std::Cr::set<std::Cr::basic_string<char,std::Cr::char_traits<char>,std::Cr::allocator<char> >,std::Cr::less<std::Cr::basic_string<char,std::Cr::char_traits<char>,std::Cr::allocator<char> > >,std [0x00007FFD0A71DEEB+45] (F:\Turkeye\src\base\functional\bind_internal.h:749) base::TaskAnnotator::RunTaskImpl [0x00007FFD1849D49F+335] (F:\Turkeye\src\base\task\common\task_annotator.cc:154) base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl [0x00007FFD184D0807+1623] (F:\Turkeye\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:449) base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork [0x00007FFD184CFB2A+186] (F:\Turkeye\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:301) base::MessagePumpForUI::DoRunLoop [0x00007FFD18544FE3+307] (F:\Turkeye\src\base\message_loop\message_pump_win.cc:215) base::MessagePumpWin::Run [0x00007FFD18544118+136] (F:\Turkeye\src\base\message_loop\message_pump_win.cc:79) base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run [0x00007FFD184D1C6D+557] (F:\Turkeye\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:612) base::RunLoop::Run [0x00007FFD18467D43+627] (F:\Turkeye\src\base\run_loop.cc:143) content::BrowserMainLoop::RunMainMessageLoop [0x00007FFD062D0AA2+162] (F:\Turkeye\src\content\browser\browser_main_loop.cc:1050) content::BrowserMainRunnerImpl::Run [0x00007FFD062D370D+45] (F:\Turkeye\src\content\browser\browser_main_runner_impl.cc:164) content::BrowserMain [0x00007FFD062CD90D+225] (F:\Turkeye\src\content\browser\browser_main.cc:30) content::RunBrowserProcessMain [0x00007FFD0718AD8A+322] (F:\Turkeye\src\content\app\content_main_runner_impl.cc:691) content::ContentMainRunnerImpl::RunBrowser [0x00007FFD0718C475+751] (F:\Turkeye\src\content\app\content_main_runner_impl.cc:1228) content::ContentMainRunnerImpl::Run [0x00007FFD0718C05A+938] (F:\Turkeye\src\content\app\content_main_runner_impl.cc:1087) content::RunContentProcess [0x00007FFD0718A435+1509] (F:\Turkeye\src\content\app\content_main.cc:342) content::ContentMain [0x00007FFD0718A614+100] (F:\Turkeye\src\content\app\content_main.cc:370) ChromeMain [0x00007FFD08131273+467] (F:\Turkeye\src\chrome\app\chrome_main.cc:174) MainDllLoader::Launch [0x00007FF7D9562A18+830] (F:\Turkeye\src\chrome\app\main_dll_loader_win.cc:166) wWinMain [0x00007FF7D9561B87+2920] (F:\Turkeye\src\chrome\app\chrome_exe_main_win.cc:391) __scrt_common_main_seh [0x00007FF7D965BC96+262] (D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288) BaseThreadInitThunk [0x00007FFD9B4526BD+29] RtlUserThreadStart [0x00007FFD9C7CDFB8+40] Task trace: Backtrace: extensions::anonymous namespace'::ExtensionActivityDataService::GetActiveBits [0x00007FFD0A71DC4C+188] (F:\Turkeye\src\chrome\browser\extensions\updater\chrome_update_client_config.cc:107) update_client::anonymous namespace'::UpdateCheckerImpl::CheckForUpdates [0x00007FFD0ADAD593+499] (F:\Turkeye\src\components\update_client\update_checker.cc:109) update_client::anonymous namespace'::UpdateCheckerImpl::CheckForUpdates [0x00007FFD0ADAD593+499] (F:\Turkeye\src\components\update_client\update_checker.cc:109) update_client::UpdateEngine::Update [0x00007FFD0ADA63BD+1809] (F:\Turkeye\src\components\update_client\update_engine.cc:194) update_client::UpdateClientImpl::RunTask [0x00007FFD0A2FA531+149] (F:\Turkeye\src\components\update_client\update_client.cc:134) Task trace buffer limit hit, update PendingTask::kTaskBacktraceLength to increase. Crash keys: "ui_scheduler_async_stack" = "0x7FFD0A71DC4C 0x7FFD0ADAD593" "num-extensions" = "0" "is-enterprise-managed" = "no" "io_scheduler_async_stack" = "0x7FFD79B597D0 0x0" "switch-8" = "--variations-insecure-server-url" "switch-7" = "--variations-server-url" "switch-6" = "--lso-url=https://no-thanks.invalid" "switch-5" = "--sync-url" "switch-4" = "--origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld" "switch-3" = "--enable-dom-distiller" "switch-2" = "--disable-domain-reliability" "switch-1" = "--disable-brave-update" "num-switches" = "12"

null null`

Steps to Reproduce

  1. npm run build
  2. npm start
  3. starts and just crashes

Actual result:

crash

Expected result:

start responding and doesnt crash

Reproduces how often:

switch to commit 2aece1dd244e49578dc82523410b8524214e894d ( 1.48.90) and try new component build I have also tried switching tag to 1.46.144 (supposed to be current stable code) and 1.46.146 but I face same problem on both of them as well.

Brave version (brave://version info)

on all of these versions 1.48.90 1.46.144 1.46.146

Other Additional Information:

Miscellaneous Information:

NaaeemMalik commented 1 year ago

just added

return; on components/update_client/request_sender.cc(89) and it worked even though its not solution that can submitted here in a commit bcz it disables update check permanently