brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.52k stars 2.27k forks source link

Is it possible to have search suggestion without autocomplete? #27600

Closed DableUTeeF closed 1 year ago

DableUTeeF commented 1 year ago

Description

I moved from Chrome to Firefox to get away from address bar autocomplete. Now that I'm planning to move from Firefox to Brave, is it possible to set the browser to suggest what I type but not autocomplete it?

Steps to Reproduce

  1. Disable "Show autocomplete suggestions in address bar"
  2. Type a word in address bar
  3. Enable "Show autocomplete suggestions in address bar"
  4. Type a word in address bar

Actual result:

  1. No autocomplete but also no suggestion when "Show autocomplete suggestions in address bar" is disabled.
  2. Both autocomplete and suggestion were used when "Show autocomplete suggestions in address bar" is enabled.
  3. No setting for something in-between

Expected result:

I'd like to have a setting where I can enable suggestion but disable autocomplete. For example, if I type "mail" I want it to suggest "mail.google.com" but if I press enter it just search with the word "mail".

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.46.144 Chromium: 108.0.5359.128 (Official Build) (64-bit)
Revision 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS Linux
rebron commented 1 year ago

If you go to brave://settings/appearance and uncheck everything but keep the main toggle on

Screenshot 2023-01-06 at 8 17 25 AM

And then go to brave://settings/privacy and turn autocomplete on

Screenshot 2023-01-06 at 8 17 59 AM

I think that should do it.

rebron commented 1 year ago

@DableUTeeF I'm going to close this one out. Please re-open if that didn't work for you.

DableUTeeF commented 1 year ago

I tried that but that will just autocomplete my search as per Actual Result number 2.

Without Autocomplete searches and URLs and without ticking anything under Show autocomplete suggestions in address bar it'll not suggest anything (Actual result: 1).

Without Autocomplete searches and URLs and ticking Browsing History under Show autocomplete suggestions in address bar it'll suggest but also autocomplete (Actual result: 2).

DableUTeeF commented 1 year ago

@rebron I don't think I can re-open this myself.

DableUTeeF commented 1 year ago

OK I think I figured out what you meant.

What I need "isn't" suggestion from the search engine, but rather the history.

The solution you provided will not autocomplete if the search engine is brave, but it doesn't give me the sites I visited similar to how Show autocomplete suggestions in address bar does.

XavierJDN commented 1 year ago

hey, I'd like to fix this issue. I create a new preferences to be able to manage the inline and the suggestion. the problem is: OmniboxController::StartAutocomplete is responsible to fetch and after render( by invoke event) for the inline and dropbox suggestions. So, I need to take the responsability of the dropdown suggestions out. Am I right? Annexe documentation on omnibox: https://docs.google.com/document/d/1Dk_U-zXiMFynKOYYKrS6VKUXrON_ta2mYnAyHa-Uvc0/edit#

DableUTeeF commented 1 year ago

@XavierJDN Can you also re-open this thread? As it clearly isn't solved but I can't do it.

XavierJDN commented 1 year ago

I can't do it too. @rebron can you do it? If you can answer my question or tell me some people that have the knowledge to answer my questions. It'll be appriciate.