brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.54k stars 2.27k forks source link

[CR109] Custom Filters styling not applied for Filter lists and Add custom filter lists #27647

Closed rebron closed 1 week ago

rebron commented 1 year ago

Description

Styling is not applied for Filter lists and Add custom filter lists. Follow-up to https://github.com/brave/brave-browser/issues/27450

Steps to Reproduce

  1. Visit brave://settings/shields/filters in 1.47.61 with CR 109
  2. Notice styling is off for Custom lists, lacking borders and background fill see screenshot in Expected result.

Actual result:

Screenshot 2023-01-04 at 2 14 18 PM Screenshot 2023-01-04 at 2 20 11 PM

Expected result:

Screenshot 2023-01-04 at 2 14 45 PM Screenshot 2023-01-04 at 2 22 05 PM

Reproduces how often:

Easily.

Brave version (brave://version info)

1.47 with CR 109

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

ParagGhatage commented 1 month ago

@rebron I would love to work on this issue. Will you assign it to me?

jagadeshjai commented 1 month ago

Hey @ParagGhatage!

Are you still interested in fixing this bug? If so, just mention it here, and you can get started right away!

ParagGhatage commented 1 month ago

Hey @ParagGhatage!

Are you still interested in fixing this bug? If so, just mention it here, and you can get started right away!

Thank you for reaching out. I’m currently focused on another issue, but I will begin working on this bug as soon as I’ve completed that task.