Closed kjozwiak closed 1 year ago
I guess we're using this method on several modals so I guess it's fine? @anthonypkeane @timchilds thoughts?
@kjozwiak looks ok to me. I think it's standard UX to make the CTA you want the user to tap more noticeable than the cancel/not now/etc.
@kjozwiak looks ok to me. I think it's standard UX to make the CTA you want the user to tap more noticeable than the cancel/not now/etc.
@timchilds feel free to close this one off in that case 👍
Description
This is more of a suggestion rather than a bug. Even though it was design [1] this way, I think it would look cleaner if we make
Not now
look like a button alongsideAdd widget
. It looks a bit off seeingNot now
just flaot in a white background alongside the other button. At first I thought it might have been a bug so took a look at the design and seems itentional. Created issue so we could at least have a conversation to see if we might want to improve/change the design. I think making it look more like a button will make it easier to understand thatNow now
can be tapped on as well.We're also not being consistent as the tablet(s) look like they're using some form of a button even though it looks really bad as per https://github.com/brave/brave-browser/issues/27850.
Steps to reproduce
1.47.175 Chromium: 109.0.5414.87
widget
onboarding to appearActual result
Expected result
I think it should look similar to the
Add widget
button soNot now
also looks like a button.Issue reproduces how often
100% reproducible using the STR/Cases outlined above.
Version/Channel Information:
Yes
Yes
Yes
Device details
ARM
Pixel 6
(Phone)Android 13
Brave version
Website problems only
N/A
N/A
N/A
Additional information
@deeppandya @timchilds @Uni-verse