making `Not now` under the `widget` onboarding look like a button

kjozwiak commented 1 year ago

Description

This is more of a suggestion rather than a bug. Even though it was design [1] this way, I think it would look cleaner if we make Not now look like a button alongside Add widget. It looks a bit off seeing Not now just flaot in a white background alongside the other button. At first I thought it might have been a bug so took a look at the design and seems itentional. Created issue so we could at least have a conversation to see if we might want to improve/change the design. I think making it look more like a button will make it easier to understand that Now now can be tapped on as well.

We're also not being consistent as the tablet(s) look like they're using some form of a button even though it looks really bad as per https://github.com/brave/brave-browser/issues/27850.

Steps to reproduce

launch 1.47.175 Chromium: 109.0.5414.87
run through the initial onboarding and tap on the omnibox to get the widget onboarding to appear

Actual result

Expected result

I think it should look similar to the Add widget button so Not now also looks like a button.

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

Can you reproduce this issue with the current Play Store version? Yes
Can you reproduce this issue with the current Play Store Beta version? Yes
Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

Install type (ARM, x86): ARM
Device type (Phone, Tablet, Phablet): Pixel 6 (Phone)
Android version: Android 13

Brave version

Brave | 1.47.175 Chromium: 109.0.5414.87 (Official Build) (32-bit)
--- |  ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/T2B2.221216.006

Website problems only

Does the issue resolve itself when disabling Brave Shields? N/A
Does the issue resolve itself when disabling Brave Rewards? N/A
Is the issue reproducible on the latest version of Chrome? N/A

Additional information

@deeppandya @timchilds @Uni-verse

kjozwiak commented 1 year ago

I guess we're using this method on several modals so I guess it's fine? @anthonypkeane @timchilds thoughts?

timchilds commented 1 year ago

@kjozwiak looks ok to me. I think it's standard UX to make the CTA you want the user to tap more noticeable than the cancel/not now/etc.

kjozwiak commented 1 year ago

@kjozwiak looks ok to me. I think it's standard UX to make the CTA you want the user to tap more noticeable than the cancel/not now/etc.

@timchilds feel free to close this one off in that case 👍

brave / brave-browser