search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.92k stars 2.34k forks source link

[Android] Implement payout status banner in Rewards dropdown panel #28052

Closed Miyayes closed 1 year ago

Miyayes commented 1 year ago

Description

See: https://github.com/brave/brave-browser/issues/31480

GeetaSarvadnya commented 1 year ago

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.59.86

Payout begin banner_FAILED_#33088 1. Clean profile 1.59.x 2. Enable rewards and connect a custodian 3. View a couple of Ads and confirm ads are cashed in with the server 4. Close the browser 5. Advance the sys clock to any date between 1st to 7th of next month (I have set date as 1st Oct) 6. Use Charles Proxy to simulate pending message being returned from the `/parameter` endpoint (I have set empty string for the uphold custodian) 7. Relaunch the browser 8. Confirmed that “The payout for [previous month] rewards will begin processing by [payment date]” message is shown in the rewards settings page. But payout begin message is not displayed in the BR panel **_Brave rewards ads section:_** ![Screenshot_20231001_145941](https://github.com/brave/brave-browser/assets/38657976/cad10f28-72de-4ab4-beed-609dce86b88a) 13. Confirmed that empty string payout status is returned from the `/parameters` endpoint ``` [ REQUEST ] > URL: https://api.rewards.bravesoftware.com/v1/parameters > Method: GET 2023-10-28 14:58:21.309 25539-25539/? V/chromium: [VERBOSE6:logging_util.cc(120)] ------ [ RESPONSE - OnResponse ] > Url: https://api.rewards.bravesoftware.com/v1/parameters > Result: Success > HTTP Code: 200 > Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.170927,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","CA","SG","GB"],"block":[]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"complete","uphold":"","zebpay":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-01-25T04:00:00Z","vbatExpired":false} 2023-10-28 14:58:21.709 25539-25539/? V/chromium: [VERBOSE1:api_parameters.cc(88)] Params timer set for 11059 s ````
Processing banner_Logged #33087 1. Clean profile 1.59.x 2. Enable rewards and connect a custodian 3. View a couple of Ads and confirm ads are cashed in with the server 4. Close the browser 5. Advance the sys clock to any date in the next month (I set date to 30th Oct) 6. Use Charles Proxy to simulate "Processing" message being returned from the `/parameter` endpoint 7. Relaunch the browser 8. Confirmed that “The payout for [previous month] rewards is in progress. Check status” message is shown in the rewards settings page as expected but the processing payout banner shown in the BR panel shows the incorrect month hence logged #33087 **_Brave rewards ads section:_** ![Screenshot_20231028_145559](https://github.com/brave/brave-browser/assets/38657976/92ff1e57-6c61-47de-baf8-8bfef3856d69) 10. Confirmed that “processing” payout status is returned from the `/parameters` endpoint ``` [ REQUEST ] > URL: https://api.rewards.bravesoftware.com/v1/parameters > Method: GET ------ [ RESPONSE - OnResponse ] > Url: https://api.rewards.bravesoftware.com/v1/parameters > Result: Success > HTTP Code: 200 > Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.170927,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","CA","SG","GB"],"block":[]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"complete","uphold":"processing","zebpay":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-01-25T04:00:00Z","vbatExpired":false} ```
Complete banner_Logged #33087 1. Clean profile 1.58.x 2. Enable rewards and connect a custodian 3. View a couple of Ads and confirm ads are cashed in with the server 4. Close the browser 5. Advance the sys clock to any date in the next month (I set date to 28th Oct) 6. Use Charles Proxy to simulate "Complete" message being returned from the `/parameter` endpoint 7. Relaunch the browser 8. Confirmed that “The payout for [previous month] rewards has completed. Support” message is shown with the support link in the rewards settings page. But the payout banner shown in the BR panel shows the incorrect month hence logged #33087 **_Brave rewards ads section:_** ![Screenshot_20231028_144937](https://github.com/brave/brave-browser/assets/38657976/65d9a78c-4c4f-49d6-9424-2088d58f4969) 10.Confirmed that “complete” payout status is returned from the `/parameters` endpoint ``` [ REQUEST ] > URL: https://api.rewards.bravesoftware.com/v1/parameters > Method: GET ------ [ RESPONSE - OnResponse ] > Url: https://api.rewards.bravesoftware.com/v1/parameters > Result: Success > HTTP Code: 200 > Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.170927,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","CA","SG","GB"],"block":[]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"complete","uphold":"complete","zebpay":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-01-25T04:00:00Z","vbatExpired":false} 2023-09-20 14:46:42.046 13660-13660/? V/chromium: [VERBOSE1:api_parameters.cc(88)] Params timer set for 11210 s ```