brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.89k stars 2.34k forks source link

Brave crashed when clicked Wallet icon on the sidebar in the Guest window #28107

Open MadhaviSeelam opened 1 year ago

MadhaviSeelam commented 1 year ago

Description

Found while testing https://github.com/brave/brave-browser/issues/27221. Brave crashed when clicked Wallet icon in the Guest window sidebar. Couldn't reproduce the issue with Normal window, Private window and Tor window. This is not related to Chromium 110 as it is reproducible in current release 1.47.186

Steps to Reproduce

  1. Install 1.49.69
  2. launch Brave
  3. skip onboarding
  4. open a Guest window (sidebar enabled)
  5. click on Wallet icon in the sidebar

Actual result:

Brave crashed

Status: | Uploaded
-- | --
Uploaded Crash Report ID: | c9a60200-668b-8709-0000-000000000000
Upload Time: | Wednesday, January 25, 2023 at 1:19:08 PM
[ 0 ] mojo::ReceiverSetState::Add(std::Cr::unique_ptr<mojo::ReceiverSetState::ReceiverState,std::Cr::default_delete<mojo::ReceiverSetState::ReceiverState> >,std::Cr::unique_ptr<mojo::MessageFilter,std::Cr::default_delete<mojo::MessageFilter> >) ( receiver_set.cc:104 )
[ 1 ] malloc ( allocator_shim_override_ucrt_symbols_win.h:71 )
[ 2 ] mojo::ReceiverSetBase<mojo::Receiver<brave_wallet::mojom::BraveWalletService,mojo::RawPtrImplRefTraits<brave_wallet::mojom::BraveWalletService> >,void>::AddImpl(brave_wallet::mojom::BraveWalletService *,mojo::PendingReceiver<brave_wallet::mojom::BraveWalletService>,bool,scoped_refptr<base::SequencedTaskRunner>,std::Cr::unique_ptr<mojo::MessageFilter,std::Cr::default_delete<mojo::MessageFilter> >) ( receiver_set.h:437 )
[ 3 ] brave_wallet::BraveWalletService::Bind(mojo::PendingReceiver<brave_wallet::mojom::BraveWalletService>) ( brave_wallet_service.cc:230 )
[ 4 ] WalletPageUI::CreatePageHandler(mojo::PendingRemote<brave_wallet::mojom::Page>,mojo::PendingReceiver<brave_wallet::mojom::PageHandler>,mojo::PendingReceiver<brave_wallet::mojom::WalletHandler>,mojo::PendingReceiver<brave_wallet::mojom::JsonRpcService>,mojo::PendingReceiver<brave_wallet::mojom::SwapService>,mojo::PendingReceiver<brave_wallet::mojom::AssetRatioService>,mojo::PendingReceiver<brave_wallet::mojom::KeyringService>,mojo::PendingReceiver<brave_wallet::mojom::BlockchainRegistry>,mojo::PendingReceiver<brave_wallet::mojom::TxService>,mojo::PendingReceiver<brave_wallet::mojom::EthTxManagerProxy>,mojo::PendingReceiver<brave_wallet::mojom::SolanaTxManagerProxy>,mojo::PendingReceiver<brave_wallet::mojom::FilTxManagerProxy>,mojo::PendingReceiver<brave_wallet::mojom::BraveWalletService>,mojo::PendingReceiver<brave_wallet::mojom::BraveWalletP3A>,mojo::PendingReceiver<brave_wallet::mojom::WalletPinService>,mojo::PendingReceiver<brave_wallet::mojom::WalletAutoPinService>) ( wallet_page_ui.cc:152 )
[ 5 ] mojo::internal::BindingStateBase::BindInternal(mojo::internal::PendingReceiverState *,scoped_refptr<base::SequencedTaskRunner>,char const *,std::Cr::unique_ptr<mojo::MessageReceiver,std::Cr::default_delete<mojo::MessageReceiver> >,bool,base::span<unsigned int const ,-1>,mojo::MessageReceiverWithResponderStatus *,unsigned int,unsigned int (*(*)(mojo::Message &))(void),char const * (*)(mojo::Message &)) ( binding_state.cc:145 )
[ 6 ] _tailMerge_esent.dll

Expected result:

No crashes

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.49.69 Chromium: 110.0.5481.52 (Official Build) nightly (64-bit)
-- | --
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Windows 11 Version 22H2 (Build 22621.1105)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

@rebron cc: @srirambv
LaurenWags commented 1 year ago

Reproduced on 1.47.186, good find @MadhaviSeelam 👍🏻

Steps:

  1. clean profile 1.47.186
  2. close/relaunch to pull griffin seed
  3. Enable sidebar in brave://settings/appearance
  4. Open a guest window
  5. Go to hamburger menu in Guest window and select "Always"
  6. Click on wallet icon on sidebar
  7. Crash

Uploaded Crash Report ID: 21ba0200-668b-8709-0000-000000000000