brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.66k stars 2.3k forks source link

[Android] Include option to disable prior search results from autocomplete suggestions in address bar #28111

Open Brave-Matt opened 1 year ago

Brave-Matt commented 1 year ago

Description

On Android, the options

allow the user to cover and remove most suggestions that would appear in the address bar. However, previous searches will still appear in the address bar, regardless of how these options are configured. In the interested of privacy, I think it is worth considering adding an additional option (or including the function in existing options) that allows users to turn this particular function off.

Example thread: https://community.brave.com/t/search-history-retained-in-address-bar/465666/8

cc @AlexeyBarabash @SergeyZhukovsky

jakariyaa commented 1 year ago

+1 for this feature implementation.

Search history in address bar shouldn't be displayed by default if not turned on any option to do otherwise.

ShivanKaul commented 1 year ago

Perhaps we could rewrite the top-level setting Show autocomplete in address bar to instead be Show suggestions in address bar? That would cover both autocomplete and history, and then bundle the history functionality into this.

@SergeyZhukovsky @rmcfadden3 thoughts?

rmcfadden3 commented 1 year ago

Perhaps we could rewrite the top-level setting Show autocomplete in address bar to instead be Show suggestions in address bar? That would cover both autocomplete and history, and then bundle the history functionality into this.

@SergeyZhukovsky @rmcfadden3 thoughts?

@ShivanKaul — intuitively that makes sense to me. I guess the only consideration would be if we've built feature-name recognition (or people just have it from general browser / search familiarity) around the term "autocomplete." Would people have the same understanding of / familiarity with the term "Suggestions" ?

gac2288 commented 1 year ago

Hello, I honestly don't see how this could be such a big problem, as this "bug/feature" was only introduced lately - I personally see the search results among top sites in the last few days, and I use this feature daily, top useful to me - until lately, when random past search results began spamming this list. So plese, just revert whatever update caused this issue - a search result, especially a one time search result never should be among top sites! THX!

jacktpk22 commented 1 year ago

How about we don't clutter the search bar with any unnecessary garbage and just let us type what we want in the search bar ourselves? Would love to live in a world without machines telling me what I should be looking for.

LZeugirdor commented 10 months ago

This issue is pretty frustrating, I can type in google.com and get a previous search result even though I only typed in the domain name.

murban484 commented 10 months ago

+1 to this feature, hopefully it'll not be forgotten

specxml commented 8 months ago

Why does it take so long to solve this stupid problem???? It's obvious that if you disable history saving, it shouldn't be saved. Why the hell is it saved for gogole? Fix it! We've been waiting for a solution for years!

jazzlyno commented 7 months ago

+1 for this feature. Should be able to toggle whether we want our recent searches to immediately pop up when making the address bar active in a new/empty tab.

New user of Brave and surprised this wasn't an option already.

qaywsxedcrfvtgb commented 2 months ago

+1, Any update on this? It's huge privacy concern. You want to Google something for your friends while they are watching and they can see everything you were recently searching!

LZeugirdor commented 1 month ago

+1, Any update on this? It's huge privacy concern. You want to Google something for your friends while they are watching and they can see everything you were recently searching!

Auto suggestions can be turned off, this was already an option. In this case auto complete cannot be turned off, I'll try to simplify this. Imagine you turn off auto suggest, you will no longer see suggested websites when you type in the url bar. However since you cannot turn off autocomplete, you get hit with a hidden autofill that you can't see. so instead of going to google.com. You go to google.com/your-recent-or-most-revisted-search-url. I say most visited because you'll likely just press enter after typing google.com and repeatedly get sent to that last search and it will stick until the next time you clear your history. It's incredibly frustrating.