brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.5k stars 2.26k forks source link

Insufficient liquidity shown when swap quotes are shown #28249

Closed srirambv closed 1 year ago

srirambv commented 1 year ago

Description

Insufficient liquidity shown when swap quotes are shown

Steps to Reproduce

Possible steps not 100% accurate

  1. Select USDT as Swap from token
  2. Select a couple of tokens to swap to and get quotes
  3. Select yearn.finance from token list, shows quote but review order button changes to Insufficient liquidity

Also ran into the issue with USDT->MANA as well

Actual result:

image image

Expected result:

Not show quotes when insufficient liquidity error is shown

Reproduces how often:

Intermittent

Brave version (brave://version info)

Brave 1.48.151 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS Windows 11 Version 22H2 (Build 22621.755)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

cc: @onyb @Douglashdaniel

HEagle18 commented 1 year ago

this looks to be fixed to me .. agree @onyb @srirambv ?

HEagle18 commented 1 year ago

closing after messaging @srirambv

srirambv commented 1 year ago

Unable to repro the issue now.