brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.03k stars 2.22k forks source link

Upgrade from Chromium 110 to Chromium 111 #28288

Closed mkarolin closed 1 year ago

mkarolin commented 1 year ago

Upgrade from Chromium 110 to Chromium 111

https://chromium.googlesource.com/chromium/src/+log/110.0.5481.104..111.0.5563.33/?pretty=fuller&n=10000

QA tests: This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

iOS Affected areas:

Android Affected areas:

GeetaSarvadnya commented 1 year ago

Verification PASSED on

Brave | 1.50.61 Chromium: 111.0.5563.33 (Official Build) nightly (64-bit)
-- | --
Revision | 19bd6d0186b7912604e18191826dab9d1df00e2e-refs/branch-heads/5563@{#557}
OS | Windows 10 Version 21H2 (Build 19044.2604)

Logged https://github.com/brave/brave-browser/issues/28773 Logged https://github.com/brave/brave-browser/issues/28772

Verify functionality/UI for tabs and tab groups, in regular orientation and "vertical tabs" orientation_PASSED **_regular orientation:_** - Confirmed that user can create a new tab group via `Add tab to group` ->`New group` ![image](https://user-images.githubusercontent.com/38657976/221760285-045108ca-1dae-413d-9034-27bfc8d6ca60.png) - Confirmed that tabs can be added to existing/already created tab groups ![image](https://user-images.githubusercontent.com/38657976/221762825-5dfc15c1-c24d-4b00-9bae-cf6e599ce7f3.png) - Confired that click on the tab group name expands/list of all the tabs added in that group Example | Example ----------|---------- ![image](https://user-images.githubusercontent.com/38657976/221760601-5327f9ca-86de-4573-9335-49bc26dcff4c.png) | ![image](https://user-images.githubusercontent.com/38657976/221760668-f3583070-36f7-4e50-add0-e1bf487aac4e.png) - Confirmed that added tabs can be removed from the tab group via `Remove from group` ![image](https://user-images.githubusercontent.com/38657976/221761677-ba487623-6b48-4711-baae-08d42be89ef7.png) - Confirmed that user can ungroup the tabs via `Ungroup` ![image](https://user-images.githubusercontent.com/38657976/221763684-20a49a2c-8434-4de6-a3a1-f2d7c6fb021a.png) **_Vertical tabs orientation:_** - Confirmed that vertical tabs can be enabled via the flag `#brave-vertical-tabs` - After enabling the flag, right click on any tab and select `Use vertical tabs` option to view vertical tabs - Verified that sites can be added to vertical tab by clicking on the `+ New tab` - Right click on any site added in the vertical tab shows the tab `context menu` options - Verified that `reading list` and `vertical tabs` cab be enabled at the same time - Right click on any site and select `New tab to the right` context menu option and ensured new tab got added to the right - Right click on any site and select `Add tab to reading list` context menu option and ensured site can be added to the reading list - Right click on any site and select `Add a tab to new group` and ensured that the selected site can be added to new tab group - Right click on the sites in vertical tab and select `Add a tab to new group` and then created tab (e.g `test` which I have created in my testing) group and ensured that sites got added to the tab group `test` - Verified that created tab group can be collapsed/expanded, when the group is expanded sites added in tab groups are shown - Right click on any site in vertical tab and select `Move tab to another window` and ensured that tab is opened in an new window - When a tab is moved to the new window, if user try to move another tab to new window, user get option to move the tab to the existing (2nd window) or new window, ensured both options works fine - Right click on any site in vertical tab and select `Reload` context menu option and ensured site gets reloaded/refreshed - Right click on any site in vertical tab and select `Duplicate` context menu option and ensured duplicate tab got added to the tab group - Right click on any site in vertical tab and select `Pin` context menu option and ensured site pinned in the tab group and right clicked on the pinned tab and ensured `Unpin` option is shown - Ensured that pinned site can be unpinned by clicking on the `Unpin` option - Right click on any YT site in vertical tab and select `mute` context menu option and ensured site is muted and mute option is shown in the URL bar and video is playing in an muted mode. - Ensured that YT videos can be unmuted by clicking on the `Unmute` option - Ensured that `Close`, `Close other tabs`, `Close tabs to the right` and `Reopen closed tabs` works as expected - Ensured that the tab `Bookmarls all` context menu works as expected - Ensured that tabs can be drag and drop in an vertical tab - Ensured that vertical tab cab be collapsed/expanded, when `vertical tabs` is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example ----------|----------|-----------|-----------|-----------|----------|-----------|----------|-----------|------------|---------- ![image](https://user-images.githubusercontent.com/38657976/221771620-df8616d4-bbd5-4219-83fd-2f3d5df60277.png) | ![image](https://user-images.githubusercontent.com/38657976/221771721-35930912-ba4e-40cf-a753-96704367a8c7.png) | ![image](https://user-images.githubusercontent.com/38657976/221772534-1d7b2aa2-dd25-4a74-a0bc-3eca4f203b6e.png) | ![image](https://user-images.githubusercontent.com/38657976/221772679-1a65f0a2-72da-45fa-bd40-d0e25e5172bb.png) | ![image](https://user-images.githubusercontent.com/38657976/221773005-dd6ed717-4c67-44d5-a89f-1a2d5542894c.png) | ![image](https://user-images.githubusercontent.com/38657976/221773301-299c3b44-1bbb-4933-97a6-6da34a351378.png) | ![image](https://user-images.githubusercontent.com/38657976/221773884-43abe81f-8f2d-41b1-90a3-e19501639290.png) | ![image](https://user-images.githubusercontent.com/38657976/221773959-84689fa7-ff86-4738-b249-52ddd9c6e206.png) | ![image](https://user-images.githubusercontent.com/38657976/221774442-3c9f1d5b-da48-43e4-af62-409352df1966.png) | ![image](https://user-images.githubusercontent.com/38657976/221774685-232c1133-cec4-4751-9d18-78cf8d8e3362.png) | ![image](https://user-images.githubusercontent.com/38657976/221774935-26c2fcdd-b0d6-4c60-bf31-9cf83a18ea90.png)
brave://settings_PASSED - Ensured that no new settings are added as part of CR 111 - Verified that click on each settings in brave://settings redirected to the intended page - Verified the brave://settings UI and ensured UI looks good - Verified the icons in the brave://settings page and ensured icons are shown as expected in each settings page - Additional testing on settings is covered in "Settings comparison" section
PDF extension_PASSED - Ensured that PDF loaded over HTTPS at https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf - Ensured that PDF loaded over HTTP at http://www.pdf995.com/samples/pdf.pdf - Ensured that the PDF's can be downloaded - Ensured taht the downloaded PDF's can be opened from system local file path Example | Example | Example | Example | Example ---------|-----------|-----------|----------|--------- ![image](https://user-images.githubusercontent.com/38657976/221796858-79c1f8fe-49ea-412f-a15c-97f730f1eff4.png) | ![image](https://user-images.githubusercontent.com/38657976/221796916-f9a670bd-6535-4d4c-837c-e32a9e43a12d.png) | ![image](https://user-images.githubusercontent.com/38657976/221796985-da040a17-38cd-49b1-9709-21af7ab1ccf7.png) | ![image](https://user-images.githubusercontent.com/38657976/221797032-6ab3410c-0ad8-498a-9f3e-5b5e28044011.png) | ![image](https://user-images.githubusercontent.com/38657976/221797138-8fb7eca3-b204-4fa9-81ea-205333b2f8de.png)
Sidebar_PASSED - Confirmed that sidebar is shown by default in the nightly channel - Confirmed that `Reading list` icon is added to the sidebar menu - Confirmed that reading list panel is shown when user click on the `Reading list` icon in the sidebar menu - Confirmed that user can add the `list of websites` to the reading list by clicking on the `+Add current tab` - Confirmed that user can add the `list of websites` to the reading list by right clicking on the tab and choose the option `Add tab to the reading list` - Confirmed that `reading list panel can be hidden` by clicking on the `Reading list` icon in the sidebar menu - Confirmed that reading list icon is shown in the URL bar, next to wallet icon - Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar) - Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window) - Websites can't be added to reading list in Guest, encountered https://github.com/brave/brave-browser/issues/24930 - Confirmed that sites can be segregated to `Read` and `Unread` list - Confirmed that sites can be deleted from the reading list Example | Example | Example | Example ----------|-----------|----------|---------- ![image](https://user-images.githubusercontent.com/38657976/221608716-fa0d1fda-650a-4966-8b06-2c833e54d37c.png) | ![image](https://user-images.githubusercontent.com/38657976/221608850-949f5887-02ef-4cdb-8d68-f868e66eee87.png) | ![image](https://user-images.githubusercontent.com/38657976/221609107-61d9107a-d543-4951-8905-b28b04b80bc0.png) | ![image](https://user-images.githubusercontent.com/38657976/221611569-760c9dad-5d74-4600-b188-73300813e724.png)
Ephemeral storage and cookie/content settings in general_PASSED **_Ephemeral storage_**
Ephemeral storage _PASSED Step 1: Encountered #26817 - Test results are not same as the test page results, encountered https://github.com/brave/brave-browser/issues/26817, looks like this is expected as per https://github.com/brave/brave-browser/issues/26817#issuecomment-1319332581 ![image](https://user-images.githubusercontent.com/38657976/221814014-44dc9259-1e15-49c8-91ae-c4c220482e29.png) Step 2: works as expected ![image](https://user-images.githubusercontent.com/38657976/221814576-2a48fa9c-c1c3-4959-a9c0-719f19aec7dc.png) Step 3: works as expected ![image](https://user-images.githubusercontent.com/38657976/221814819-d30d2ea9-beb5-4c85-b940-365721496a20.png) Step 4: works as expected ![image](https://user-images.githubusercontent.com/38657976/221815015-d961182d-43a8-4cd3-b461-0e56a91c0958.png) Step 5: works as expected ![image](https://user-images.githubusercontent.com/38657976/221815280-c1146ea7-b9d5-4984-913a-5925207a5c6b.png) Step 6: works as expected ![image](https://user-images.githubusercontent.com/38657976/221813572-1bfbdd2f-d189-4f82-b2ba-82f9c1cabe59.png)
**_Content settings:_**
Content settings_PASSED - Confirmed that `Shields settings` is been added in brave://settings/content (more info: https://github.com/brave/brave-browser/issues/12782) - Added few sites to shields up and shields down list and ensured sites got added to shield settings list - Open the sites (which are added in shield down list) in PT/TOR tab windows and ensured shields are down as expected - Confirmed content settings are working as expected - Confirmed cookies settings are working as expected **_1. Block cookies content settings_** - Open a site cnn.com - Open content settings for cnn.com - Block content settings for `Location` and `Window management` - Reload cnn.com - Ensured that `Location` and `Window management` permission are blocked for cnn.com - Open brave://settings/cookies and `Block all cookies` - Reload cnn.com and ensured that all cookies are blocked on cnn.com Example | Example | Example | Example | Example | Example -- | -- | -- | -- | --|--- ![image](https://user-images.githubusercontent.com/38657976/221631736-62e9e6b2-3139-4055-b002-b6c078adc55c.png) | ![image](https://user-images.githubusercontent.com/38657976/221631888-c5a5d99c-fa3b-4de0-8b15-ccbdeb726201.png) | ![image](https://user-images.githubusercontent.com/38657976/221632085-e0760e59-12fd-4834-9155-c1f902faae7c.png) | ![image](https://user-images.githubusercontent.com/38657976/221631956-3bc1b1a1-98cd-4558-9591-3f876c53f78e.png) | ![image](https://user-images.githubusercontent.com/38657976/221632189-3725f76c-4548-40ea-85f0-8e3e55159475.png) | ![image](https://user-images.githubusercontent.com/38657976/221632522-29577b4b-633f-400b-bcef-14945f27a66e.png) **_2. Block scripts content settings_** - Block the java scripts for a site via brave://settings/content/javascript - Open the site ensured Java scripts blocked for the site - Open a bunch of websited and ensured java script is not blocked Example | Example | Example | Example -- | -- | -- | --- ![image](https://user-images.githubusercontent.com/38657976/221633118-a8abbe25-a6b2-4f73-8c38-9ba1e4f354b7.png) | ![image](https://user-images.githubusercontent.com/38657976/221633186-a7c2a5ef-e1ef-4e87-8697-3d1c9ebd46c5.png) | ![image](https://user-images.githubusercontent.com/38657976/221633234-121962a7-b048-4520-b660-48a712c8c246.png) | ![image](https://user-images.githubusercontent.com/38657976/221633328-b271e81c-8aee-4603-aada-74a7ccc949a6.png) **_3. Block autoplay global settings_** - Block the youtube.com autoplay content global settings via brave://settings/content/autoplay - Open youtube.com and ensured no videos are autoplayed - Click on a video and play the video manully, wait till the 1st video ends - Ensured 2nd video is not autoplayed Example | Example ----------|--------- ![image](https://user-images.githubusercontent.com/38657976/221634067-0063ec1f-3878-441c-a28b-cad110e0819d.png) | ![image](https://user-images.githubusercontent.com/38657976/221634146-a4517bd9-2356-4a72-a29e-b8b1c250c950.png)
Verify that Brave policies (such as TorDisabled) work correctly when set_PASSED 1. Open REGEDIT with admin rights, look for `Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Policies` (for macOS and Linux keys, please refer the instructions in https://github.com/brave/brave-browser/issues/25151) 2. Create the keys `BraveSoftware\Brave` 3. Create a DWORD value at this path called `TorDisabled` and set the value as `1` 4. Close the REGEDIT 5. Open brave `1.50.67`, open brave://policy and ensure `TorDisabled` value is `true` under brave://policy/ 6. Tap on the 3 dot menu/settings menu, ensure that there is no `New Private window with Tor` option 7. Open a Private window and ensure there is no `New Private window with Tor` option in 3 dot menu 8. Create a new profile and ensure there is no `New Private window with Tor` option in 3 dot menu Example | Example | Example | Example | Example ----------|-----------|------------|----------|---------- ![image](https://user-images.githubusercontent.com/38657976/221782698-8affb627-85dd-434d-a345-399291fd91f7.png) | ![image](https://user-images.githubusercontent.com/38657976/221782966-ed6dfeac-72ff-4bb9-8dd5-1ffe61d2f4f7.png) | ![image](https://user-images.githubusercontent.com/38657976/221783099-859e96a2-2996-4c72-a19f-af29226d159c.png) | ![image](https://user-images.githubusercontent.com/38657976/221783178-b9f9006a-3fc4-4e83-b7f7-570f84b3e4ac.png) | ![image](https://user-images.githubusercontent.com/38657976/221783321-b54c6d69-4323-4bc5-bf0f-9cca81bf0842.png)

Settings comparison

  1. Show bookmarks with three dropdown items 1. Always 2. Never 3. Only on the new tab page is been added as part of 1.49.x (https://github.com/brave/brave-browser/issues/26072) and which works as expected image

  2. Always show bookmarks on the new tab page setting is removed on behalf of the above option Show bookmarks with three dropdown items

  3. Disable mute function in tab speakers icon settings under brave://settings/appearance is added below the Show Tab search button settings image

  4. The Social media blocking button Allow Google login buttons on third party sites is renamed to Allow use of third-party cookies for legacy Google Sign-In (for info https://github.com/brave/brave-browser/issues/28177) image

  5. The new settings Current Private session only checkbox is been added in add shield status block under brave://settings/content/braveShields as part of Brave, when user select the checkbox, the added site shield is blocked in the private session only and shield is enabled in Normal window types. image

  6. The download icon in the URL bar is inherited from CR 111 image

MadhaviSeelam commented 1 year ago

Verification PASSED using

Brave | 1.50.62 Chromium: 111.0.5563.33 (Official Build) nightly (64-bit)
-- | --
Revision | 19bd6d0186b7912604e18191826dab9d1df00e2e-refs/branch-heads/5563@{#557}
OS | Windows 11 Version 21H2 (Build 22000.1574)

Brave Sync - PASSED

- Verified Brave Sync in https://github.com/brave/brave-browser/issues/28714

Verify that welcome page continues to show when expected - PASSED

- Verified various supported browsers and the functionality is working as expected Example | Example | Example | Example ----- | ------- | -----|------ image|image|image|image

Verify that setting Brave as default browser continues to work as expected - PASSED

- Set Brave as default browser via onboarding `brave://welcome` page - Set Brave as default browser via `Set as a default` infobar in NTP - Set Brave as default browser via `Make default ` in `brave://settings Example | Example | Example | Example ------- | ------- | --------- | ------ image|image|image|image

Components - PASSED

- Verified Components in https://github.com/brave/brave-browser/issues/28714 - No new components are added as part of CR 111 1.50.62 Chromium: 111.0.5563.33 nightly | 1.48.171 Chromium: 110.0.5481.177 ------------ | -------------- image | image

Brave startup calls - PASSED

- Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile - Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile
Uni-verse commented 1 year ago

Verified on Samsung GS 21 using version:

Brave   1.50.67 Chromium: 111.0.5563.33 (Official Build) canary (64-bit) 
Revision    19bd6d0186b7912604e18191826dab9d1df00e2e-refs/branch-heads/5563@{#557}
OS  Android 13; Build/TP1A.220624.014

Ads notifications

Screen Shot 2023-02-28 at 5 33 32 PM

Web notifications

Example Example
screenshot-1677621166353 screenshot-1677621175500

Check that you can connect to Uphold

Logged: https://github.com/brave/brave-browser/issues/28791

NTP layout

Logged: https://github.com/brave/brave-browser/issues/28803

Example Example Example
screenshot-1677623255376 screenshot-1677626085535 screenshot-1677626114067

Bottom and top toolbars

Bottom toolbar Top toolbar Rewards icon hidden share menu
screenshot-1677621424631 screenshot-1677621457791 screenshot-1677621479195 screenshot-1677621494432

Brave Search Promo Banner

kjozwiak commented 1 year ago

Labelled as QA/No and release-notes/exclude in favour of https://github.com/brave/brave-browser/issues/28729#issuecomment-1450774513.