brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.62k stars 2.29k forks source link

Window scrolling issue when loading sandbox auth page (re-connecting to custodian) #28344

Open Uni-verse opened 1 year ago

Uni-verse commented 1 year ago

Description

In the case where the user is in logged out state, tapping on the login link in the brave://rewards page or the BR panel will bring up the authorize page for the custodian. Tapping authorize will load the 2FA element but places the container out of view (window scrolls to element height position)

Only impacts mobile

Steps to reproduce

  1. Install 1.48 on Android mobile device
  2. Enable staging environment for rewards in QA settings
  3. Relaunch browser, sign up for rewards
  4. Next, connect custodian account (Uphold sandbox)
  5. Once connected, open the dashboard page for the uphold sandbox account
  6. Proceed to revoke user access but deleting brave account under integrations tab on Uphold
  7. Close this page
  8. Open brave://rewards and tap on the link to log in to custodian account
  9. Authorize screen will be displayed, tap Authorize
  10. Observe

Actual result

https://user-images.githubusercontent.com/17885425/217294139-06979dd9-f2b7-4836-b240-eb6a86ff6486.mp4

Expected result

The 2FA fields should be positioned properly, scroll to top of web view

Issue reproduces how often

Easily

Version/Channel Information:

Device details

Brave version

1.48.157, Chromium 110.0.5481.77

Uni-verse commented 1 year ago

@deeppandya Does not impact Gemini counterpart flow. It displays fine.

0
deeppandya commented 1 year ago

@deeppandya Does not impact Gemini counterpart flow. It displays fine.

0

Thank you @Uni-verse for checking

deeppandya commented 1 year ago

@Miyayes i am removing my assignment for now as we don't need any action from android side.