brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.88k stars 2.34k forks source link

No sources card missing on NTP when user not following any sources [News v2] #28349

Closed Uni-verse closed 1 year ago

Uni-verse commented 1 year ago

Description

No sources card missing on NTP when user following 0 sources

Steps to reproduce

  1. Install 1.48
  2. Enabled Brave News v2 in brave://flags
  3. Enabled Brave News
  4. Unfollow all sources in the news settings

Actual result

Example Example
screenshot-1675794940556 screenshot-1675794950245

Expected result

Screen Shot 2023-02-07 at 1 53 01 PM

Issue reproduces how often

Always

Version/Channel Information:

Device details

Brave version

1.48.158, Chromium 110.0.5481.77

hffvld commented 1 year ago

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 UPB2.230407.019 release-keys]
Brave build: 1.53.83
Chromium: 114.0.5735.110 (Official Build) beta (64-bit)
Revision: 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}

STEPS:

  1. Launch Brave
  2. GO to brave://flags > Enable Enabled Brave News v2
  3. Enabled Brave News > See the content
  4. Three-dot Menu > Brave News > Unfollow all sources
  5. Return to NTP > Load new content > Verify
  6. Tap `Choose content sources > Add some news sources
  7. Return to NTP > Load new content > Verify

ACTUAL RESULTS:

1 2
1 2
kjozwiak commented 1 year ago

The above requires 1.52.130 or higher for 1.52.x verification 👍 Removing the QA Pass label as the above will need to be rechecked with 1.52.x.

Uni-verse commented 1 year ago

Verified on Samsung Galaxy S21 5G using version:

Brave   1.52.130 Chromium: 114.0.5735.198 (Official Build) (32-bit) 
Revision    c3029382d11c5f499e4fc317353a43d411a5ce1c-refs/branch-heads/5735@{#1394}
OS  Android 13; Build/TP1A.220624.014; 33; REL
Removing SourcesRe-adding sources
https://github.com/brave/brave-browser/assets/17885425/68cedeb6-567a-436b-857a-47f182c4e222 https://github.com/brave/brave-browser/assets/17885425/4bfcf415-24c9-4223-9743-a5e6295ae42d