brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.86k stars 2.33k forks source link

Manifest V2 Support for Select Extensions. [Part 1] #28367

Closed boocmp closed 1 year ago

boocmp commented 1 year ago

Description

SPEC: https://docs.google.com/document/d/1fyt_kQv51nkuPOOTz-zgshYq6gLlq2CayqcrZIKTh7k/edit#heading=h.ls63kcwg56s1

Part 1: Implement "Manifest V2 Extensions" section under the brave://settings/extensions Add NoScript, uBlock Origin, uMatrix, AdGuard extensions.

stephendonner commented 1 year ago

Verification PASSED using

Brave 1.51.77 Chromium: 112.0.5615.49 (Official Build) beta (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 11.7.5 (Build 20G1225)

Shared Steps:

1. installed `1.51.77` 2. launched Brave using `--enable-features=ExtensionsManifestV2` 3. opened `brave://settings/extensions` 4. clicked on `Manifest V2 extensions` 5. confirmed new listing of `Enable NoScript`, `Enable uBlock Origin`, `Enable uMatrix`, and `Enable AdGuard` panels with toggles 6. confirmed all V2 extensions were toggled, default, to `Off` / `Disabled/uninstalled` step 2 | step 3 | steps 5-6 -------|-------|-------- Screen Shot 2023-04-05 at 5 57 43 PM | Screen Shot 2023-04-05 at 5 49 01 PM | Screen Shot 2023-04-05 at 5 56 42 PM

Toggled an Extension On / Enabled - PASSED

* confirmed I was prompted to `Add extension` via a dialog * confirmed it showed the extension's logo * confirmed it had a disclaimer about Brave not reviewing third-party extensions * after clicking `Add extension`, confirmed I saw `uBlock Origin has been added to Brave` example | example | example | example ---------|----------|---------|--------- Screen Shot 2023-04-05 at 10 06 31 PM | Screen Shot 2023-04-05 at 10 06 35 PM | Screen Shot 2023-04-05 at 10 06 39 PM | Screen Shot 2023-04-05 at 10 06 57 PM

Toggled All On / Enabled - PASSED

* confirmed I could pin each extension to the URL bar * confirmed I could launch each * confirmed basic functionality (not pictured) for each `all enabled` | `all pinned` | `NoScript` | `uBlock Origin` | `uMatrix` | `AdGuard` ---------|---------|-----------|---------|---------|---------- Screen Shot 2023-04-05 at 8 08 24 PM | Screen Shot 2023-04-05 at 8 08 44 PM | Screen Shot 2023-04-05 at 8 09 13 PM | Screen Shot 2023-04-05 at 8 09 19 PM | Screen Shot 2023-04-05 at 8 09 26 PM | Screen Shot 2023-04-05 at 8 09 32 PM

Toggled All Off / Disabled - PASSED

example | example ---------|--------- Screen Shot 2023-04-05 at 9 38 28 PM | Screen Shot 2023-04-05 at 9 39 24 PM

Extensions folder within the profile - PASSED

* confirmed installed each adds their respective versioned sub-folders in the user's profile * confirmed removing (or toggling to `Disabled` / `Off`) removes the respective sub-folder in the user's profile `all installed` | `all uninstalled` ------------|----------------- Screen Shot 2023-04-05 at 9 44 18 PM | Screen Shot 2023-04-05 at 9 45 30 PM ``` stephendonner@Stephens-MBP ~ % cd /Users/stephendonner/Library/Application\ Support/BraveSoftware/Brave-Browser-Beta/Default/Extensions stephendonner@Stephens-MBP Extensions % ls -la total 24 drwx------@ 8 stephendonner staff 256 Apr 5 22:15 . drwx------@ 73 stephendonner staff 2336 Apr 5 22:15 .. -rw-r--r--@ 1 stephendonner staff 8196 Apr 5 21:45 .DS_Store drwx------@ 2 stephendonner staff 64 Apr 5 22:15 Temp drwx------@ 3 stephendonner staff 96 Apr 5 22:15 bgnkhhnnamicmpeenaelnjfhikgbkllg drwx------@ 3 stephendonner staff 96 Apr 5 22:06 cjpalhdlnbpafiamejdnhcphjbkeiagm drwx------@ 3 stephendonner staff 96 Apr 5 22:15 doojmbjmlfjjnbmnoijecmcbfeoakpjm drwx------@ 3 stephendonner staff 96 Apr 5 22:15 ogfcmafjalglgifnmanfmnieipoejdcf ```

brave://extensions - PASSED

* confirmed default view * confirmed `Developer mode` details are present * confirmed expanded `Details` view (`uBlock Origin` pictured) `default` | `Developer mode` | `Details` ---------|--------------------|---------- Screen Shot 2023-04-05 at 8 24 12 PM | Screen Shot 2023-04-05 at 8 24 17 PM | Screen Shot 2023-04-05 at 8 25 13 PM