search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.52k stars 2.27k forks source link

Remove obsolete HTTPS Everywhere list from Brave since it's no longer needed #28433

Closed Inasad closed 10 months ago

Inasad commented 1 year ago

https://www.eff.org/deeplinks/2021/09/https-actually-everywhere

https://www.eff.org/https-everywhere/set-https-default-your-browser

As of January 2023, the software has been sunset and will no longer receive updates because it is now redundant. Brave has HTTPS Everywhere built-in, but it no longer serves a purpose since you no longer need the extension to do what it was intended to do, as Chromium has a native setting to enable HTTPS-Only Mode. Are there plans to remove the extension from Brave and leave it up to native Chromium functionality?

antonok-edm commented 1 year ago

You might be interested in https://brave.com/privacy-updates/22-https-by-default 😄

I believe there are still a few HTTPS Everywhere remnants in the browser and our component server, but my understanding is that those will be removed soon.

cc @fmarier @arthuredelstein

stephendonner commented 10 months ago

Hi @arthuredelstein ! Mind adding a testplan here, when you get a chance? Thanks! Adding QA/Blocked and QA/Test-Plan-Required just until we've got that, and then we'll be fully unblocked 👍

arthuredelstein commented 10 months ago

Hi @stephendonner! My suggestion would be just to confirm that HTTPS Upgrades are still working. Probably a subset of past QA on https://github.com/brave/brave-browser/issues/27141 ?

stephendonner commented 10 months ago

Hi @stephendonner! My suggestion would be just to confirm that HTTPS Upgrades are still working. Probably a subset of past QA on #27141 ?

Thanks; I'll get it started, and perhaps you can review once I'm in a good place with it 👍

stephendonner commented 10 months ago

Verification PASSED using

Brave | 1.62.39 Chromium: 119.0.6045.134 (Official Build) nightly (x86_64)
-- | --
Revision | bca25a6d30376dbda1a5506d040dc49e6d30008b
OS | macOS Version 11.7.10 (Build 20G1427)
brave://version brave://flags
Screen Shot 2023-11-09 at 2 25 45 PM Screen Shot 2023-11-09 at 2 26 24 PM

Default - Upgrade connections to HTTPS, Standard - PASSED

1. installed `1.62.39` 8. launched Brave 9. confirmed `Upgrade connections to HTTPS` is set to `Standard` in `brave://settings/shields` 10. loaded `http://insecure.arthuredelstein.net` 11. loaded `http://http.badssl.com` 12. loaded `http://upgradable.arthuredelstein.net` 13. opened a `New Private Window with Tor` and loaded each of the above `default` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` ----------|-------------------------------|--------------------|--------------------------------- Screen Shot 2023-11-09 at 2 08 35 PM | Screen Shot 2023-11-09 at 2 09 38 PM | Screen Shot 2023-11-09 at 2 10 07 PM | Screen Shot 2023-11-09 at 2 10 43 PM #### Tor `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------|---------------------------------- Screen Shot 2023-11-09 at 2 13 03 PM | Screen Shot 2023-11-09 at 2 15 16 PM | Screen Shot 2023-11-09 at 2 15 35 PM

Upgrade connections to HTTPS, Strict - PASSED

1. installed `1.62.39` 2. launched Brave 3. changed `Upgrade connections to HTTPS` to `Strict` in `brave://settings/shields` 4. loaded `http://insecure.arthuredelstein.net` 5. loaded `http://http.badssl.com` 7. loaded `http://upgradable.arthuredelstein.net` 8. opened a `New Private Window with Tor` and loaded each of the above `Upgrade connections, Strict` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` ----------|-------------------------------|--------------------|--------------------------------- Screen Shot 2023-11-09 at 2 20 38 PM | Screen Shot 2023-11-09 at 2 21 58 PM | Screen Shot 2023-11-09 at 2 22 10 PM | Screen Shot 2023-11-09 at 2 22 26 PM #### Tor `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------|---------------------------------- Screen Shot 2023-11-09 at 2 24 19 PM | Screen Shot 2023-11-09 at 2 24 34 PM | Screen Shot 2023-11-09 at 2 24 52 PM

Upgrade connections to HTTPS, Disabled - PASSED

1. installed `1.62.39` 2. launched Brave 3. changed `Upgrade connections to HTTPS` to `Disabled` in `brave://settings/shields` 4. loaded `http://insecure.arthuredelstein.net` 5. loaded `http://http.badssl.com` 6. loaded `http://upgradable.arthuredelstein.net` 7. opened a `New Private Window with Tor` and loaded each of the above `Upgrade connections, Disabled` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------------------|--------------------|--------------------------------- Screen Shot 2023-11-09 at 2 31 14 PM | Screen Shot 2023-11-09 at 2 31 40 PM | Screen Shot 2023-11-09 at 2 31 53 PM | Screen Shot 2023-11-09 at 2 32 17 PM #### Tor `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------|---------------------------------- Screen Shot 2023-11-09 at 2 33 03 PM | Screen Shot 2023-11-09 at 2 33 42 PM | Screen Shot 2023-11-09 at 2 33 51 PM

Update from 1.60.114, Disabled - PASSED

1. installed `1.60.114` 2. launched Brave 3. changed `Upgrade connections to HTTPS` to `Disabled` in `brave://settings/shields` 4. upgraded to `1.62.39` 5. loaded `http://insecure.arthuredelstein.net` 6. loaded `http://http.badssl.com` 7. loaded `http://upgradable.arthuredelstein.net` 8. opened a `New Private Window with Tor` and loaded each of the above `1.60.114` | `Upgrade connections, Disabled` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -----------|-----------------------------------|-------------------------------|---------------------|----------------- Screen Shot 2023-11-09 at 4 39 44 PM | Screen Shot 2023-11-09 at 4 41 22 PM | Screen Shot 2023-11-09 at 4 47 01 PM | Screen Shot 2023-11-09 at 4 47 10 PM | Screen Shot 2023-11-09 at 4 47 24 PM ### Tor ### Confirmed all sites loaded, with the 1st two having interstitials and the last being automatically upgraded to `HTTPS` `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` ------------------------------|--------------------|---------------------------------- Screen Shot 2023-11-09 at 4 51 27 PM | Screen Shot 2023-11-09 at 4 52 54 PM | Screen Shot 2023-11-09 at 4 53 00 PM
stephendonner commented 9 months ago

Also confirmed the removal of the Brave HTTPS Everywhere Updater - Version: 1.0.170 component

1.60.118 1.62.73
Screen Shot 2023-11-22 at 11 25 54 AM Screen Shot 2023-11-22 at 11 27 17 AM
MadhaviSeelam commented 9 months ago

Verification PASSED using

Brave | 1.62.105 Chromium: 120.0.6099.71 (Official Build) beta (64-bit)
-- | --
Revision | f72c783bcd52110d026061575b4bef28ccb547f7
OS | Windows 11 Version 22H2 (Build 22621.2715)
brave://version brave://flags
image image

brave://components

Confirmed removal of the Brave HTTPS Everywhere Updater - Version: 1.0.170 component

1.61.101 1.62.105
image image

Default - Upgrade connections to HTTPS, Standard - PASSED

1. installed `1.62.105` 2. launched Brave 3. confirmed `Upgrade connections to HTTPS` is set to `Standard` in `brave://settings/shields` 4. loaded `http://insecure.arthuredelstein.net` 5. loaded `http://http.badssl.com` 6. loaded `http://upgradable.arthuredelstein.net` 7. opened a `New Private Window with Tor` and loaded each of the above `default` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` ----------|-------------------------------|--------------------|--------------------------------- image|image|image|image #### Tor `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------|---------------------------------- image|image|image

Upgrade connections to HTTPS, Strict - PASSED

1. installed `1.62.105` 2. launched Brave 3. changed `Upgrade connections to HTTPS` to `Strict` in `brave://settings/shields` 4. loaded `http://insecure.arthuredelstein.net` 5. loaded `http://http.badssl.com` 6. loaded `http://upgradable.arthuredelstein.net` 7. opened a `New Private Window with Tor` and loaded each of the above #### Confirmed Interstitial page for insecure websites (step 4 & 5). #### Confirmed site is upgraded to `https` in Step 6 `Interstitial page` |`Upgrade connections, Strict` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` ----------|-------------------------------|--------------------|-----------------|---------------- image|image|image|image|image ### Tor `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------|---------------------------------- image|image|image

Upgrade connections to HTTPS, Disabled - PASSED

1. installed `1.62.39` 2. launched Brave 3. changed `Upgrade connections to HTTPS` to `Disabled` in `brave://settings/shields` 4. loaded `http://insecure.arthuredelstein.net` 5. loaded `http://http.badssl.com` 6. loaded `http://upgradable.arthuredelstein.net` 7. opened a `New Private Window with Tor` and loaded each of the above `Upgrade connections, Disabled` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------------------|--------------------|--------------------------------- image|image|image|image ### Tor ### Confirmed Tor windows always use `Strict` mode though Normal window setting is Disabled #### Confirmed Interstitial page for insecure websites (step 4 & 5). #### Confirmed site is upgraded to `https` in step 6 `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------|---------------------------------- image|image|image

Update from 1.61.101, Disabled - PASSED

1. installed `1.61.101` 2. launched Brave 3. changed `Upgrade connections to HTTPS` to `Disabled` in `brave://settings/shields` 4. upgraded to `1.62.105` 5. loaded `http://insecure.arthuredelstein.net` 6. loaded `http://http.badssl.com` 7. loaded `http://upgradable.arthuredelstein.net` 8. opened a `New Private Window with Tor` and loaded each of the above `1.60.114` | `Upgrade connections, Disabled` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -----------|-----------------------------------|-------------------------------|---------------------|----------------- image|image|image|image|image #### Tor #### Confirmed all sites loaded, with the 1st two having interstitials and the last being automatically upgraded to `HTTPS` `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` ------------------------------|--------------------|---------------------------------- image|image|image
hffvld commented 8 months ago

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 13 TP1A.220624.014 release-keys
- Pixel 7 / panther_beta-user 14 AP11.231020.013.A1 release-keys
Brave build: 1.62.116
Chromium: 120.0.6099.144 (Official Build) beta (64-bit)
Pixel 7 / phone **STEPS:** 1. Launch Brave 2. Go to `brave://flags` > Verify that `https-by-default` is `enabled` 3. Go to `brave://components` > Verify that `Brave HTTPS Everywhere Updater` is removed **ACTUAL RESULTS:** - Verified that `https-by-default` is `enabled` by default - Verified that `Brave HTTPS Everywhere Updater` is removed --------------------------- |1|2|3|4| |:-:|:-:|:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/d31c3390-7e9d-4600-b28f-7dfd50d72273) | ![2](https://github.com/brave/brave-browser/assets/128532965/3e03a629-993e-4277-91bd-32fd03ca13d4) | ![3](https://github.com/brave/brave-browser/assets/128532965/bd92a0b2-a1dd-40f1-9258-763f7ae8cd53) | ![4](https://github.com/brave/brave-browser/assets/128532965/fbc738a6-1fb1-4e08-b018-c5c859cc0388) |
Upgrade to HTTPS whenever possible (default) **STEPS:** 1. Fresh install and launch Brave 2. Three-dot menu > Settings 3. Brave Shields & privacy > Upgrade connections to HTTPS > Verify that it set to `(default)` 4. Go back and open `http://insecure.arthuredelstein.net` > Verify 5. Open `http://http.badssl.com` > Verify 6. Open `http://upgradable.arthuredelstein.net` > Verify 7. Open `New Private tab` > Repeat steps 4 - 6 > Verify the same **ACTUAL RESULTS:** - Verified that `Upgrade connections to HTTPS` is set to `Upgrade to HTTPS whenever possible (default)` by `default` - Verified that `Upgrade to HTTPS whenever possible (default)` is working as expected in `Normal` and `Private` tabs --------------------------- |1|2|3|4| |:-:|:-:|:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/cacefe4f-c976-4918-97b3-c54ec318a61b) | ![2](https://github.com/brave/brave-browser/assets/128532965/b5dd85eb-b9d2-49b1-a259-c21c58764d00) | ![3](https://github.com/brave/brave-browser/assets/128532965/df28c6ca-37d1-44a2-a041-322338a43e4e) | ![4](https://github.com/brave/brave-browser/assets/128532965/ae930c13-831f-4779-897b-e8526d96d05c) | | ![1](https://github.com/brave/brave-browser/assets/128532965/140c76a9-4b03-4f69-b66e-f10515226ce4) | ![2](https://github.com/brave/brave-browser/assets/128532965/4ece914e-b6ce-43bc-9f17-b1739d8702d0) | ![3](https://github.com/brave/brave-browser/assets/128532965/0ed39d08-6aac-4ee9-b87a-e5f28eaceddf) | ![4](https://github.com/brave/brave-browser/assets/128532965/32030175-1bda-4d7d-a057-0251ce7f76d7) |
Don't upgrade connections to HTTPS (disabled) **STEPS:** 1. Fresh install and launch Brave 2. Three-dot menu > Settings 3. Brave Shields & privacy > Upgrade connections to HTTPS > Change it to `Don't upgrade connections to HTTPS (disabled)` 4. Go back and open `http://insecure.arthuredelstein.net` > Verify 5. Open `http://http.badssl.com` > Verify 6. Open `http://upgradable.arthuredelstein.net` > Verify 7. Open `New Private tab` > Repeat steps 4 - 6 > Verify the same **ACTUAL RESULTS:** - Verified that `Don't upgrade connections to HTTPS (disabled)` is working as expected in `Normal` and `Private` tabs --------------------------- |1|2|3|4| |:-:|:-:|:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/069ceb4a-95af-48d1-bd6a-80e74d516a70) | ![2](https://github.com/brave/brave-browser/assets/128532965/9ef70c37-47ff-443e-ba34-ac0d5abf3e47) | ![3](https://github.com/brave/brave-browser/assets/128532965/635e1e5c-9950-4205-bcfa-425f9c22fd69) | ![4](https://github.com/brave/brave-browser/assets/128532965/314b7f4e-c7c5-4025-a743-a5bd78aad873) | | ![1](https://github.com/brave/brave-browser/assets/128532965/9e197f54-1bb1-4951-be5c-5add325c51be) | ![2](https://github.com/brave/brave-browser/assets/128532965/f614f844-9c75-4048-aa3a-64791a5dc1e9) | ![3](https://github.com/brave/brave-browser/assets/128532965/ad2ed1ec-9056-4961-95ab-44e02d6930c6) | ![4](https://github.com/brave/brave-browser/assets/128532965/c65d0c19-ee24-4b02-b401-e069c15c838e) |
Require all connections to use HTTPS (strict) **STEPS:** 1. Fresh install and launch Brave 2. Three-dot menu > Settings 3. Brave Shields & privacy > Upgrade connections to HTTPS > Change it to `Require all connections to use HTTPS (strict)` 4. Go back and open `http://insecure.arthuredelstein.net` > Verify 5. Open `http://http.badssl.com` > Verify 6. Open `http://upgradable.arthuredelstein.net` > Verify 7. Open `New Private tab` > Repeat steps 4 - 6 > Verify the same **ACTUAL RESULTS:** - Verified that `Require all connections to use HTTPS (strict)` is working as expected in `Normal` and `Private` tabs --------------------------- |1|2|3|4| |:-:|:-:|:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/81a3bfdb-c206-4639-b029-c1c3dbc2edb5) | ![2](https://github.com/brave/brave-browser/assets/128532965/79c6bbce-d3c7-41bd-879d-855270ee11dd) | ![3](https://github.com/brave/brave-browser/assets/128532965/67c70c19-0a08-4e8f-8621-c10f5c641ba6) | ![4](https://github.com/brave/brave-browser/assets/128532965/8c27615e-d643-4f67-a3a7-ff5012ad3bb3) | | ![1](https://github.com/brave/brave-browser/assets/128532965/b226a01c-d762-43f9-b9d3-857efa4abc09) | ![2](https://github.com/brave/brave-browser/assets/128532965/c2f75e42-2600-41e4-baef-7239f7faeffd) | ![3](https://github.com/brave/brave-browser/assets/128532965/63e5d7f8-14d5-4a38-82ea-4db1c48887a1) | ![4](https://github.com/brave/brave-browser/assets/128532965/2b82245b-7592-4d58-ac7f-06e0d51693b5) |
Upgrade from `1.61.86` to `1.62.116` **STEPS:** 1. Fresh install `1.61.86` and launch Brave 2. Three-dot menu > Settings 3. Brave Shields & privacy > Upgrade connections to HTTPS > Change it to `Require all connections to use HTTPS (strict)` 4. Upgrade Brave to `1.62.116` and launch it 5. Open `http://insecure.arthuredelstein.net` > Verify 6. Open `http://http.badssl.com` > Verify 7. Open `http://upgradable.arthuredelstein.net` > Verify 8. Open `New Private tab` > Repeat steps 4 - 6 > Verify the same **ACTUAL RESULTS:** - Verified that `Upgrade connections to HTTPS` settings are working as expected in the `Normal` and `Private` tabs --------------------------- |1.61.86|1.62.116| |:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/5931c675-1845-473c-af0f-7d8a25252c90) | ![2](https://github.com/brave/brave-browser/assets/128532965/05f48650-46cf-4145-9261-b197f53a736b) | | ![1](https://github.com/brave/brave-browser/assets/128532965/a165d519-d02a-4aba-b513-fae04a705bfd) | ![2](https://github.com/brave/brave-browser/assets/128532965/1737166d-e743-45ec-9fa4-ac29fe708135) | |1|2|3|4| |:-:|:-:|:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/3fa4ce40-d7be-4fa4-aef1-b0c3b5ac24f6) | ![2](https://github.com/brave/brave-browser/assets/128532965/d2515dab-8394-45ed-91ab-80b401dbfe63) | ![3](https://github.com/brave/brave-browser/assets/128532965/a37cf805-8c28-43eb-a801-7443c646e965) | ![4](https://github.com/brave/brave-browser/assets/128532965/9c519fbb-347e-4a76-a368-49b9b1160b60) | | ![1](https://github.com/brave/brave-browser/assets/128532965/57ea171e-0321-43f7-afba-9aac5ffa267b) | ![2](https://github.com/brave/brave-browser/assets/128532965/8f501b06-114f-43e3-9e58-1bab875baf84) | ![3](https://github.com/brave/brave-browser/assets/128532965/4c134007-f752-41a1-9761-ebbc4f8d29ac) | ![4](https://github.com/brave/brave-browser/assets/128532965/daa34aed-e548-4309-80d8-cda63b1d1d61) |
Galaxy Tab S8 / tablet **STEPS:** 1. Launch Brave 2. Go to `brave://flags` > Verify that `https-by-default` is `enabled` 3. Go to `brave://components` > Verify that `Brave HTTPS Everywhere Updater` is removed **ACTUAL RESULTS:** - Verified that `https-by-default` is `enabled` by default - Verified that `Brave HTTPS Everywhere Updater` is removed --------------------------- |1|2|3|4| |:-:|:-:|:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/51c72934-90bd-46a3-9b4d-aef789d0d617) | ![2](https://github.com/brave/brave-browser/assets/128532965/8e46446d-6756-44a0-8a68-1a96a36272e9) | ![3](https://github.com/brave/brave-browser/assets/128532965/78cd426a-09e7-4d85-a69f-b9b64bf43885) | ![4](https://github.com/brave/brave-browser/assets/128532965/04d1fb14-70c5-4441-92fb-00dfdfe841da) |
Upgrade to HTTPS whenever possible (default) **STEPS:** 1. Fresh install and launch Brave 2. Three-dot menu > Settings 3. Brave Shields & privacy > Upgrade connections to HTTPS > Verify that it set to `(default)` 4. Go back and open `http://insecure.arthuredelstein.net` > Verify 5. Open `http://http.badssl.com` > Verify 6. Open `http://upgradable.arthuredelstein.net` > Verify 7. Open `New Private tab` > Repeat steps 4 - 6 > Verify the same **ACTUAL RESULTS:** - Verified that `Upgrade connections to HTTPS` is set to `Upgrade to HTTPS whenever possible (default)` by `default` - Verified that `Upgrade to HTTPS whenever possible (default)` is working as expected in `Normal` and `Private` tabs --------------------------- |1|2|3|4| |:-:|:-:|:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/860e3301-20c4-45dd-9649-23b764fe8c2a) | ![2](https://github.com/brave/brave-browser/assets/128532965/1059fd8e-a75e-4c87-ae98-647a6864a678) | ![3](https://github.com/brave/brave-browser/assets/128532965/ae1184ad-6c42-4597-9772-cabb366fcfe7) | ![4](https://github.com/brave/brave-browser/assets/128532965/dee0230f-2dd0-45f8-bc51-f595554025bb) | | ![1](https://github.com/brave/brave-browser/assets/128532965/327f621c-efb6-40f0-b075-33c1f339d367) | ![2](https://github.com/brave/brave-browser/assets/128532965/321438bc-5313-41c6-a8df-2c6a39d61768) | ![3](https://github.com/brave/brave-browser/assets/128532965/e70e5833-c52b-4799-b66a-527172f390aa) | ![4](https://github.com/brave/brave-browser/assets/128532965/31e67458-0fe8-48fe-90f5-80a9defe1996) |
Don't upgrade connections to HTTPS (disabled) **STEPS:** 1. Fresh install and launch Brave 2. Three-dot menu > Settings 3. Brave Shields & privacy > Upgrade connections to HTTPS > Change it to `Don't upgrade connections to HTTPS (disabled)` 4. Go back and open `http://insecure.arthuredelstein.net` > Verify 5. Open `http://http.badssl.com` > Verify 6. Open `http://upgradable.arthuredelstein.net` > Verify 7. Open `New Private tab` > Repeat steps 4 - 6 > Verify the same **ACTUAL RESULTS:** - Verified that `Don't upgrade connections to HTTPS (disabled)` is working as expected in `Normal` and `Private` tabs --------------------------- |1|2|3|4| |:-:|:-:|:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/b5dffd0b-fc24-46e3-8346-a869b8f07c79) | ![2](https://github.com/brave/brave-browser/assets/128532965/e508d77d-8088-469d-9ff1-52afdf20c396) | ![3](https://github.com/brave/brave-browser/assets/128532965/8d4d8671-c4ac-4beb-8bc0-7f0c7d6dbcf0) | ![4](https://github.com/brave/brave-browser/assets/128532965/ff58edfe-072c-450a-a095-15f8d265b8ad) | | ![1](https://github.com/brave/brave-browser/assets/128532965/561b5c97-4437-4f13-b183-472559ada08f) | ![2](https://github.com/brave/brave-browser/assets/128532965/2d906e93-969d-462f-b81d-07d7f8b675f5) | ![3](https://github.com/brave/brave-browser/assets/128532965/ed086f86-7016-4cac-96a1-a9510dfa6c8e) | ![4](https://github.com/brave/brave-browser/assets/128532965/995d3d95-9c05-486c-baf3-86e167ea9484) |
Require all connections to use HTTPS (strict) **STEPS:** 1. Fresh install and launch Brave 2. Three-dot menu > Settings 3. Brave Shields & privacy > Upgrade connections to HTTPS > Change it to `Require all connections to use HTTPS (strict)` 4. Go back and open `http://insecure.arthuredelstein.net` > Verify 5. Open `http://http.badssl.com` > Verify 6. Open `http://upgradable.arthuredelstein.net` > Verify 7. Open `New Private tab` > Repeat steps 4 - 6 > Verify the same **ACTUAL RESULTS:** - Verified that `Require all connections to use HTTPS (strict)` is working as expected in `Normal` and `Private` tabs --------------------------- |1|2|3|4| |:-:|:-:|:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/c469483d-73f9-4cf0-bf6d-cce70a9a790f) | ![2](https://github.com/brave/brave-browser/assets/128532965/e887a438-fd82-4613-ba0e-8c3781e6a9b9) | ![3](https://github.com/brave/brave-browser/assets/128532965/fcae7a9c-69f6-49c8-94c0-968867eafda6) | ![4](https://github.com/brave/brave-browser/assets/128532965/60bbd003-7bf2-48b7-ac51-44448b091c62) | | ![1](https://github.com/brave/brave-browser/assets/128532965/7a29cf65-338f-41bf-9f50-32ec7ff074f3) | ![2](https://github.com/brave/brave-browser/assets/128532965/e03adfc3-6ed8-4e64-91df-7f604a061ccd) | ![3](https://github.com/brave/brave-browser/assets/128532965/41393bc1-bdff-4674-a75a-a3055c9f644f) | ![4](https://github.com/brave/brave-browser/assets/128532965/8f37a83c-06cf-4878-8fa4-cb0a86788645) |
Upgrade from `1.61.86` to `1.62.116` **STEPS:** 1. Fresh install `1.61.86` and launch Brave 2. Three-dot menu > Settings 3. Brave Shields & privacy > Upgrade connections to HTTPS > Change it to `Require all connections to use HTTPS (strict)` 4. Upgrade Brave to `1.62.116` and launch it 5. Open `http://insecure.arthuredelstein.net` > Verify 6. Open `http://http.badssl.com` > Verify 7. Open `http://upgradable.arthuredelstein.net` > Verify 8. Open `New Private tab` > Repeat steps 4 - 6 > Verify the same **ACTUAL RESULTS:** - Verified that `Upgrade connections to HTTPS` settings are working as expected in the `Normal` and `Private` tabs --------------------------- |1.61.86|1.62.116| |:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/cb79160f-37f9-4211-bcd9-fb9a41bd73fe) | ![2](https://github.com/brave/brave-browser/assets/128532965/9f22ffe7-3324-4c78-bb5b-422170a0e3fb) | | ![1](https://github.com/brave/brave-browser/assets/128532965/38ae2260-e67b-4163-bdf0-8fbc06230470) | ![2](https://github.com/brave/brave-browser/assets/128532965/3a7364d4-c244-4be1-b706-e3e27b60fbd1) | |1|2|3|4| |:-:|:-:|:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/54391cbe-886e-42e1-abef-f54b102efc6a) | ![2](https://github.com/brave/brave-browser/assets/128532965/118f2453-1a88-488a-b8f0-2fc4b5245c98) | ![3](https://github.com/brave/brave-browser/assets/128532965/28619089-bffd-4e8a-8e57-de801126036b) | ![4](https://github.com/brave/brave-browser/assets/128532965/0aa3415c-b383-4a94-9a09-96c3f3bce41a) | | ![1](https://github.com/brave/brave-browser/assets/128532965/909753bf-eda6-45eb-a1db-c6204f9949d2) | ![2](https://github.com/brave/brave-browser/assets/128532965/1061c2bc-7545-4262-b112-11459edf5b19) | ![3](https://github.com/brave/brave-browser/assets/128532965/eaf68ebb-b128-45e8-84b5-c07bb91a240e) | ![4](https://github.com/brave/brave-browser/assets/128532965/2caa1948-7e7a-4cdf-987c-b9c0833d8b78) |
btlechowski commented 8 months ago

Verified with

Brave 1.62.122 Chromium: 120.0.6099.144 (Official Build) beta (64-bit)
Revision cfddebe77d394064c472fda64afcd9fbed34ceb4
OS Linux

brave://components

#### Confirmed removal of the `Brave HTTPS Everywhere Updater - Version: 1.0.170 component` 1.61.x | 1.62.x ---- | ---- ![image](https://github.com/brave/brave-browser/assets/34715963/4b82f160-124f-43fb-b73f-f59686f56eed)|![image](https://github.com/brave/brave-browser/assets/34715963/6b3a26be-cca2-442b-a391-67cad3552fb9)

Default - Upgrade connections to HTTPS, Standard - PASSED

1. installed `1.62.x` 2. launched Brave 3. confirmed `Upgrade connections to HTTPS` is set to `Standard` in `brave://settings/shields` 4. loaded `http://insecure.arthuredelstein.net` 5. loaded `http://http.badssl.com` 6. loaded `http://upgradable.arthuredelstein.net` 7. opened a `New Private Window with Tor` and loaded each of the above `default` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` ----------|-------------------------------|--------------------|--------------------------------- ![image](https://github.com/brave/brave-browser/assets/34715963/6912b07c-2e37-4199-af52-4471821d5734)|![image](https://github.com/brave/brave-browser/assets/34715963/a6e1482d-82e9-43b9-b61f-54904dbf0b1d)|![image](https://github.com/brave/brave-browser/assets/34715963/81b8e043-1ee7-4597-bd99-5b7f1a17a7c0)|![image](https://github.com/brave/brave-browser/assets/34715963/45c53036-fca3-443a-a7cf-df06991e76b3) #### Tor `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------|---------------------------------- ![image](https://github.com/brave/brave-browser/assets/34715963/496179ae-e0cd-4648-acf9-7aa99134a10e)|![image](https://github.com/brave/brave-browser/assets/34715963/f2d6f7ad-ca54-41c2-a12c-93d5247f6c72)|![image](https://github.com/brave/brave-browser/assets/34715963/1c94fa09-9a7b-498b-91aa-168398dc4d4d)

Upgrade connections to HTTPS, Strict - PASSED

1. installed `1.62.x` 2. launched Brave 3. changed `Upgrade connections to HTTPS` to `Strict` in `brave://settings/shields` 4. loaded `http://insecure.arthuredelstein.net` 5. loaded `http://http.badssl.com` 6. loaded `http://upgradable.arthuredelstein.net` 7. opened a `New Private Window with Tor` and loaded each of the above #### Confirmed Interstitial page for insecure websites (step 4 & 5). #### Confirmed site is upgraded to `https` in Step 6 `Upgrade connections, Strict` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` ----------|-------------------------------|--------------------|-----------------|---------------- ![image](https://github.com/brave/brave-browser/assets/34715963/ff5b8389-cca5-4c16-8589-bbba30d552b7)|![image](https://github.com/brave/brave-browser/assets/34715963/aa4994d2-0649-47f3-97f2-54b7e2700cac)|![image](https://github.com/brave/brave-browser/assets/34715963/d0034ff1-7eaf-4fde-ab9d-f3fc0fa91975)|![image](https://github.com/brave/brave-browser/assets/34715963/9aef9c2b-f072-4388-9d32-c4265a470b28) ### Tor `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------|---------------------------------- ![image](https://github.com/brave/brave-browser/assets/34715963/743a36af-3882-4411-a2b0-a3390c0a3e43)|![image](https://github.com/brave/brave-browser/assets/34715963/d9fd8ea1-4d62-4486-aba9-5621236ecf23)|![image](https://github.com/brave/brave-browser/assets/34715963/8c1509ca-609f-4ebe-9216-8a88c1feaf8e)

Upgrade connections to HTTPS, Disabled - PASSED

1. installed `1.62.x` 2. launched Brave 3. changed `Upgrade connections to HTTPS` to `Disabled` in `brave://settings/shields` 4. loaded `http://insecure.arthuredelstein.net` 5. loaded `http://http.badssl.com` 6. loaded `http://upgradable.arthuredelstein.net` 7. opened a `New Private Window with Tor` and loaded each of the above `Upgrade connections, Disabled` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------------------|--------------------|--------------------------------- ![image](https://github.com/brave/brave-browser/assets/34715963/b40ef6f8-894f-4874-890f-757c35f489d5)|![image](https://github.com/brave/brave-browser/assets/34715963/03598c08-228c-41ca-b8d4-40c6a60a5766)|![image](https://github.com/brave/brave-browser/assets/34715963/87fcb065-f64e-40ee-828a-f9738a8d0403)|![image](https://github.com/brave/brave-browser/assets/34715963/ca2cd899-bd67-4fce-9108-54a7c59ff0c6) ### Tor ### Confirmed Tor windows always use `Strict` mode though Normal window setting is Disabled #### Confirmed Interstitial page for insecure websites (step 4 & 5). #### Confirmed site is upgraded to `https` in step 6 `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------|---------------------------------- ![image](https://github.com/brave/brave-browser/assets/34715963/b6f5a0df-2de9-4cc3-8d97-56baecb908fa)|![image](https://github.com/brave/brave-browser/assets/34715963/da109b8e-3766-4fbd-a422-756ed2ad64ae)|![image](https://github.com/brave/brave-browser/assets/34715963/9b9223a1-a0d0-4360-bd20-9fff936a6566)

Update from 1.61.x, Disabled - PASSED

1. installed `1.61.101` 2. launched Brave 3. changed `Upgrade connections to HTTPS` to `Disabled` in `brave://settings/shields` 4. upgraded to `1.62.x` 5. loaded `http://insecure.arthuredelstein.net` 6. loaded `http://http.badssl.com` 7. loaded `http://upgradable.arthuredelstein.net` 8. opened a `New Private Window with Tor` and loaded each of the above ![image](https://github.com/brave/brave-browser/assets/34715963/ce3d98fb-f149-4c94-b126-9f0fad51360c)|![image](https://github.com/brave/brave-browser/assets/34715963/28639f18-f945-42e5-a3f7-14f6929e3371) --|-- `1.61.x` | `Upgrade connections, Disabled` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -----------|-----------------------------------|-------------------------------|---------------------|----------------- ![image](https://github.com/brave/brave-browser/assets/34715963/469330af-5c2e-4336-947b-ad53faf72f20)|![image](https://github.com/brave/brave-browser/assets/34715963/994024da-b53d-4700-8e45-66491853cb08)|![image](https://github.com/brave/brave-browser/assets/34715963/8178fc3a-3dfc-4e6f-8246-2b59631ca148)|![image](https://github.com/brave/brave-browser/assets/34715963/ea3eff2b-ffc3-46d9-aead-2e7d0ffe206f)|![image](https://github.com/brave/brave-browser/assets/34715963/084b366b-c9bf-4ec7-87a6-fd1c53ec87a3)