brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.83k stars 2.33k forks source link

Do not create default internal data structure for "Uphold wallet" #28558

Open Miyayes opened 1 year ago

Miyayes commented 1 year ago

Description

We currently create an Uphold wallet by default (even if there's no chosen wallet provider). "Create an Uphold wallet by default" means "Create the internal data structure in Preferences."

Likely stems from the default return here, which is Uphold.

Solution

We shouldn't have "default wallets" if the user doesn't choose a custodial account provider.

Per @szilardszaloki.

Miyayes commented 1 year ago

See: https://bravesoftware.slack.com/archives/CNH9Q6REV/p1695671470902699?thread_ts=1695052566.419869&cid=CNH9Q6REV