brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.81k stars 2.33k forks source link

support "Copy clean link" from macOS app menu when selecting text URL on page (not link from omnibox) - Follow up to #27676 #28880

Closed LaurenWags closed 1 year ago

LaurenWags commented 1 year ago

Description

Follow up to https://github.com/brave/brave-browser/issues/27676

Above issue requests "When users select URL on the web page, text editing menu items are enabled, such as "copy", and "paste" and etc. In this case, we might be able to insert "Copy clean link"".

This is specific to macOS and their app menu.

See discussion under https://bravesoftware.slack.com/archives/CKNHM4RTK/p1677768069627199.

Steps to Reproduce

  1. Using 1.49.117, clean profile
  2. Navigate to google.com
  3. In the search box, enter www.brave.com
  4. On resulting search page, highlight www.brave.com in the search box
  5. Click on the Edit menu item from macOS app menu ---> would like to see "Copy clean link" from Edit menu in this case, but it does not show.

Actual result:

1

Expected result:

to see "Copy clean link"

Screen Shot 2023-03-03 at 8 33 42 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.49.117 Chromium: 111.0.5563.50 (Official Build) (x86_64)
-- | --
Revision | 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS | macOS Version 12.6.3 (Build 21G419)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

cc @rebron @sangwoo108

spylogsster commented 1 year ago

we decided to close as wontfix because the implementation complexity not worth the issue

bsclifton commented 1 year ago

For more context / posterity - potential solution was shared with myself and @fmarier. Basically would involve at a minimum touching the following:

Touching these means we'd end up with patches and other difficult to review items. Thanks for investigating, @spylogsster! 😄