brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.52k stars 2.27k forks source link

Wallet address shows up as Contract address when set to Ethereum Mainnet #28886

Open srirambv opened 1 year ago

srirambv commented 1 year ago

Description

Wallet address shows up as Contract address when set to Ethereum Mainnet

Steps to Reproduce

  1. Setup eth-manual-test on localhost
  2. Set network to Ethereum Mainnet
  3. Create a second Ethereum Account
  4. Copy the main account address
  5. Paste the main account address in the text field next to eth_signTransaction and click on it
  6. Panel loads and shows account address as Contract address that's clickable but doesn't do anything

Actual result:

https://user-images.githubusercontent.com/17010094/222794002-c3619df1-eae6-45f7-b707-8b75eba30600.mp4

Expected result:

Should show address as is unless its a contract address

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Windows 11 Version 22H2 (Build 22621.1265)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

Related to #27188 cc: @Douglashdaniel @nvonpentz

srirambv commented 1 year ago

This happens to Filecoin transactions as well

https://user-images.githubusercontent.com/17010094/225868390-8c5b1146-db78-4129-8a0e-6b761345f3b0.mp4