brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.89k stars 2.34k forks source link

XHR requests canceled across a wide range of websites #2901

Closed Swader closed 5 years ago

Swader commented 5 years ago

Full discussion in Twitter here: https://twitter.com/bitfalls/status/1082896409299505152


Version 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit) Win10 x64.


On certain websites, ajax requests get canceled for no apparent reason (code -3, ERR_ABORT).

Examples are: https://www.diffbot.com/careers and https://gitcoin.co/explorer?network=mainnet&keywords=nimbus&order_by=-web3_created

Here is a HAR reproduction for Diffbot: https://gist.github.com/Swader/a994365480ee63927eb4045163133f89

Example screenshot:

capture

srirambv commented 5 years ago

This looks fixed on the new beta. Could have been the CORS issue which wasn't fixed in 0.59.20. screenshot from 2019-01-11 09-19-58

@Swader mind checking it on the new beta that went out yesterday?

Swader commented 5 years ago

Still happens, same conditions. All extensions and shields off. I recommend adding a debug output and a command line --debug flag to the executable before every ERR_ABORT emit so that we can find out when these canels are being triggered.

capture capture2

srirambv commented 5 years ago

Just to confirm you are still seeing this on 0.59.21 right?

Swader commented 5 years ago

Correct: Version 0.59.21 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)

srirambv commented 5 years ago

@btlechowski @GeetaSarvadnya could you guys give it a try on Windows?

cc: @iefremov @simonhong

iefremov commented 5 years ago

I don't think its the CORS issue, looks like smth different. Maybe check this behavior in Chrome?

srirambv commented 5 years ago

I can't reproduce the issue on Linux with the same build.

Swader commented 5 years ago

It works in latest Chrome and Opera. It does not happen on any other OS, or even in private mode on Win+Brave.

iefremov commented 5 years ago

Thanks for checking this. Probably it is also worth checking in Chrome version corresponding to the problematic Brave build (Chromium: 72.0.3626.28) @srirambv

Swader commented 5 years ago

Another example: https://prvikvadrat.hr/

Swader commented 5 years ago

Another example on Github. A few refreshes with cache off helped.

696bf552-c224-495d-9658-637a64c4cdce png

cndouglas commented 5 years ago

+1 from me (#2930).

bbondy commented 5 years ago

this seems serious and new based on ^, putting P1 and putting as release/blocking.

bsclifton commented 5 years ago

@Liunkae can you please update to latest? I'm curious if recent fixes resolve this problem for you (works for me!™)

For what it's worth, I'm on DEV channel (0.60.12)

iefremov commented 5 years ago

Can't reproduce on Dev/Beta on MacOS.

Anyone with a stable repro, please save a netlog. To do this:

  1. Open brave://net-export/
  2. Click "Start logging to disk"
  3. Reproduce the bug in some other tab
  4. Return to brave://net-export, click "Stop logging", attach the resulted file to this ticket :)

Thanks

Swader commented 5 years ago

Here's an older export from me. chrome-net-export-log.zip

cndouglas commented 5 years ago

Here's a netlog: chrome-net-export-log.json.zip

Still reproduces (100% of the time) for me with the following:

Brave | 0.60.13 Chromium: 72.0.3626.53 (Official Build) dev(64-bit) Revision | 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620} OS | Mac OS X macOS version 10.14.2

Steps to reproduce:

  1. Start with a fresh profile.
  2. Quit the browser.
  3. Start Brave again.
  4. Go to https://brave.com/jobs
  5. Notice that the job listings do not load, even with shields off:

The developer console shows that one of the resources was canceled:

bbondy commented 5 years ago

We tracked it down to some code for the DOM distiller. Working on a fix.

kjozwiak commented 5 years ago

Removed OS/Windows as this is affecting macOS as well.

srirambv commented 5 years ago

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta(64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 10

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X
Swader commented 5 years ago

Please update issue to ping us when this lands in beta on Win

bbondy commented 5 years ago

It's already updated on dev and beta

Swader commented 5 years ago

Indeed it seems to work now. Can you explain how, without an update process?

srirambv commented 5 years ago

@Swader your app should have been updated to 0.59.25. Could you check brave://version?

Swader commented 5 years ago

It did indeed, but I don't remember the update process having happened. Might have occurred between a PC restart. Anyway thanks looks good now!