[CR 112] "Autocomplete searches and URLs" settings is missing in brave://settings/privacy

GeetaSarvadnya commented 1 year ago

Description

"Autocomplete searches and URLs" settings is missing in brave://settings/privacy

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.51.46 Chromium: 112.0.5615.29 (Official Build) nightly (64-bit)
Revision	8a59304c62e066962363d2fd8edd8e7b459c42bd-refs/branch-heads/5615@{#497}
OS	Windows 10 Version 21H2 (Build 19044.2728)

Version/Channel Information:

Can you reproduce this issue with the current release? No
Can you reproduce this issue with the beta channel? No
Can you reproduce this issue with the nightly channel? No

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? NA
Does the issue resolve itself when disabling Brave Rewards? NA
Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @mkarolin @rebron

mkarolin commented 1 year ago

@GeetaSarvadnya, as you suggested on Slack, this setting got reworded to Improve search suggestions (and moved lower on the page). Chromium change: https://source.chromium.org/chromium/chromium/src/+/e152def0ed5414f72091d1d784f609f2ac646704

[omnibox] Rename omnibox autocomplete setting

Old:
Title - "Autocomplete searches and URLs"
Description - "Sends some cookies and searches from the address bar and search box to your default search engine"

New:
Title - "Improve search suggestions"
Description - "When you type in the address bar or search box, Chrome sends what you type to your default search engine to get better suggestions. This is off in Incognito."

Additionally, moves the setting lower in the list of settings in the UI so that on desktop it's next to the Drive suggest setting and on Android and iOS it's consistent with the new position on desktop.