URL is not shown in the address bar in vertical tab view if title bar is hidden in windows snap windows layout

MadhaviSeelam commented 1 year ago

Description

Found while testing https://github.com/brave/brave-browser/issues/29692 URL of a visited site is not visible in the address bar in split screen mode and in vertical tab view mode and title bar is hidden. (browser window dimensions are 756 x 676px). Address bar is adjusted when title bar is shown and in horizontal view to show complete URL as expected. Reproduced in 1.52.57 (Nightly)

Steps to Reproduce

Install 1.51.95
launch Brave
visit abcnews.com
enable vertical tabs in brave://flags
enable Use vertical tabs in context menu
enable split screen mode (Win + left/right arrow)

Actual result:

Expected result:

Address bar should be adjusted to show complete or partial address?

Reproduces how often:

Easily

Brave version (brave://version info)

1.51.95 Chromium: 112.0.5615.121 (Official Build) beta (64-bit)
--
Revision | 39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS | Windows 11 Version 22H2 (Build 22621.1555)

Version/Channel Information:

Can you reproduce this issue with the current release? N/A
Can you reproduce this issue with the beta channel? Yes
Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @sangwoo108 cc: @brave/qa-team

sangwoo108 commented 1 year ago

I believe this could be reproducible when a browser window is foreced to have narrow width with horizontal tab strip as well.

As when hiding title bar, toolbar run out of enough space as caption button's will take space, it's easier to happen. We might want to label this as feature-request and feature/tabs-bar instead.

petemill commented 1 year ago

Yeah this shouldn't be blocking, but I think we can ask @aguscruiz if there's a solution planned when the window gets this narrow...

aguscruiz commented 1 year ago

I have nothing planned yet for this scenario, but I can keep it in mind for future improvements! In fact something I was playing around with (A sort of app launcher) could help solve this, but it's just an idea at this point.

brave / brave-browser