brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.94k stars 2.35k forks source link

speaker icon displays over page favicon in vertical tab mode with "Float on mouseover" selected #30021

Closed LaurenWags closed 1 year ago

LaurenWags commented 1 year ago

Description

When vertical tabs are being used and "Float on mouseover" is selected, if a background tab is playing audio the speaker icon overlays the favicon. So, it's also not immediately obvious which tab is playing the audio.

Steps to Reproduce

  1. Have vertical tabs enabled
  2. Have "Float on mouseover" checked
  3. Have a page playing audio which is not the active tab

Actual result:

I'm using dark mode, so my speaker icon is white. Favicons with more white which have the white speaker icon over top don't look great and it's tough on some to tell which are playing audio.

Brave Talk HBO Max Netflix YouTube
1 2 3 4

Expected result:

Not sure, maybe not show the favicon and just show the speaker icon - would have to be determined by @rebron and design team

Reproduces how often:

easily

Brave version (brave://version info)

1.50.x

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

cc @rebron

aguscruiz commented 1 year ago

Design update for this issue here:

image

https://www.figma.com/file/SEwlfGQ35DZxJyQBnsgfMA/Vertical-tabs?node-id=2453%3A81256&t=kVr7b8ZQK1Fi9TOO-1

sangwoo108 commented 1 year ago

Yeah, the favicon should be hidden at least when the speaker icon is shown.

@aguscruiz , left some questions on the Figma. I'm not sure if I'm going to implement the new design right away or fix bugs first for now. It depends on the complexity of it. We'll see.

kjozwiak commented 1 year ago

The above requires 1.52.92 or higher for 1.52.x verification 👍

stephendonner commented 1 year ago

Verified PASSED using

Brave 1.52.92 Chromium: 113.0.5672.92 (Official Build) beta (x86_64)
Revision b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS macOS Version 13.4 (Build 22F62)

Steps:

  1. installed 1.52.92
  2. launched Brave
  3. loaded and played video with audio across netflix.com, hbomax.com, youtube.com, and aol.com
  4. confirmed collapsed (playing audio), collapsed (default), and expanded views
  5. unchecked Float on mouseover in brave://settings/appearance
  6. confirmed non-floated view
collapsed, playing audio collapsed, default floated non-floated view
Screenshot 2023-05-09 at 10 49 35 PM Screenshot 2023-05-09 at 10 46 54 PM Screenshot 2023-05-09 at 10 32 36 PM Screenshot 2023-05-09 at 10 51 38 PM