Closed LaurenWags closed 1 year ago
Design update for this issue here:
Yeah, the favicon should be hidden at least when the speaker icon is shown.
@aguscruiz , left some questions on the Figma. I'm not sure if I'm going to implement the new design right away or fix bugs first for now. It depends on the complexity of it. We'll see.
The above requires 1.52.92
or higher for 1.52.x
verification 👍
PASSED
usingBrave | 1.52.92 Chromium: 113.0.5672.92 (Official Build) beta (x86_64) |
---|---|
Revision | b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10} |
OS | macOS Version 13.4 (Build 22F62) |
1.52.92
netflix.com
, hbomax.com
, youtube.com
, and aol.com
collapsed (playing audio)
, collapsed (default)
, and expanded
viewsFloat on mouseover
in brave://settings/appearance
non-floated
viewcollapsed , playing audio |
collapsed , default |
floated |
non-floated view |
---|---|---|---|
Description
When vertical tabs are being used and "Float on mouseover" is selected, if a background tab is playing audio the speaker icon overlays the favicon. So, it's also not immediately obvious which tab is playing the audio.
Steps to Reproduce
Actual result:
I'm using dark mode, so my speaker icon is white. Favicons with more white which have the white speaker icon over top don't look great and it's tough on some to tell which are playing audio.
Expected result:
Not sure, maybe not show the favicon and just show the speaker icon - would have to be determined by @rebron and design team
Reproduces how often:
easily
Brave version (brave://version info)
1.50.x
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @rebron