search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.54k stars 2.27k forks source link

address bar orange auto completion, cannot change url #30031

Closed markg85 closed 1 year ago

markg85 commented 1 year ago

Hi,

This is vague to describe so i hope an image helps: image

What i typed in the above case is "exchange". The part in the address bar is that top line in the image. The part brave highlights is the second line.

So it shows me everything i need to know but it doesn't allow me to edit the url.

This is super annoying. I might want to go to that side but to some other part in the url that i happen to know about.

Couple questions:

  1. What is this orange highlight weirdness? It happens on only very few sites it seems. Many of the other sites i visit have no such thing at all.
  2. How can i disable it?

Best regards, Mark

markg85 commented 1 year ago

?? Anyone ??

markg85 commented 1 year ago

ping @kjozwiak Sorry, just pinging someone from brave on this.

I hate this feature and i really want to turn it off. What's it called and how do i get rid of it? Thanx!

jpovixwm commented 1 year ago

I have the same issue. This "feature" (more like annoyance) wasn't always there, it was introduced at some point during the last 12 months or so. Previously, you were able to hit End and the caret would go to the end of the autocompleted entry and you could then change where you want to navigate to. In the case of OP's screenshot, you could for example change the currency pair to ETH_USDT and hit enter. This is no longer possible with this new autocomplete because there's no way to edit the autocompleted entry. I may try to narrow down the version of Brave this first appeared in, if I get nothing better to do in the evening.

jpovixwm commented 1 year ago

Duplicate of #28198. This was first present in Brave v1.47.164 (Chromium v109.0.5414.74) (not including beta and nightly builds). The preceding release v1.46.153 (Chromium v108.0.5359.128) didn't do this. This can also be observed in vanilla chromium, so it doesn't really have anything to do with Brave, but it would be nice if Brave could implement a fix for this. I guess the next step would be to git bisect these two chromium revisions to pinpoint the commit that introduced this change.

markg85 commented 1 year ago

@jpovixwm Thank you for your help!

That's an interesting finding (it happening on chromium too). I did have a quick look at commits between these two chrome version https://github.com/chromium/chromium/compare/108.0.5359.128...109.0.5414.74

But github isn't suitable for that many commits (5000+). Haven't tried on the command line yet. It's probably a commit containing at least the work "omnibox" as that's what the address bar is called.

jpovixwm commented 1 year ago

Actually, this issue is more complex than I initially assumed. This feature can be seen in even older chromium builds, for example v103. (That's not to say that it first appeared in v103, I just didn't check with versions older than that) So the fact that this only surfaced in Brave after the update from chromium 108 to chromium 109 is even more puzzling. To the best of my knowledge, the situation is:

I really have no idea how to find the culprit anymore.

markg85 commented 1 year ago

Found the upstream discussion for this: https://bugs.chromium.org/p/chromium/issues/detail?id=1394443

I mentioned this in the referred issue (https://github.com/brave/brave-browser/issues/28198). Closing this one.