search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.79k stars 2.32k forks source link

Add proper error message for api `snsResolveHost` when recorded URL is invalid #30080

Open nuo-xu opened 1 year ago

nuo-xu commented 1 year ago

A user reported Brave browser cannot resolve pintol.sol. With some investigation by @supermassive that this domain has both url and ipfs records but url one is invalid. In this case, we have decided to make the api returns a proper error message indicates the reason of failing to resolve SNS is invalid recorded url. Ref: https://community.brave.com/t/ios-sns-won-t-activate-the-resolver/482023

jamesmudgett commented 1 year ago

We'll need new error copy for this case @HEagle18