brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.74k stars 2.32k forks source link

[Feature Request] Firefox Reader view functionality for Brave Speedreader #30143

Open Commandcracker opened 1 year ago

Commandcracker commented 1 year ago

Description

Would it be possible to support the same features as Firefox Reader view for Speedreader ?

Reasoning

Firefox Reader view supports far moor sites than Brave with Speedreader. Almost all News sites that I visit are not supported by Speedreader.

Some examples:

(Yes, I'm šŸ‡©šŸ‡Ŗ German šŸ˜„)

Reference Comment

@bsclifton I think it's better to err on the side of over-offering distill/reader modes and allow folks to fall back if content is rendered poorly. Generally speaking (in Firefox), Reader mode makes nearly all sites better. Additionally, Reader mode can be thought of as an accessibility feature (many sites are rendered so poorly, some are unreadable without it).

If the Brave team needs to get some data on the scope of the potential impact, could it collect 4 pieces of telemetry? (reader offered by: Brave, Firefox, Both, Neither). That data can be collected in a privacy respecting way (as URLs could be omitted entirely). It could even be reduced to rounded percentages to omit unique site visits.

Subjectively, it feels like Brave doesn't offer me a Reader view nearly as often as FF, but data could prove me wrong.

FWIW, I love the idea of reader mode being the default view of pages where its supported.

Originally posted by @kf6nux in https://github.com/brave/brave-browser/issues/11994#issuecomment-908025639

Commandcracker commented 1 year ago

Firefox Reader View could be implemented into Brave Speedreader by using Mozilla's readability library. Note: Follow their security recommendations!

Reader-view is a addon that implements readability. It might provide some reference to make the implementation easier.