[Custom Tab] Websites not opened in Brave Custom Tab Mode for Google Search and Google Discover

hffvld commented 1 year ago

Description

Websites not opened in Brave Custom Tab Mode for Google Search and Google Discover

Steps to reproduce

Launch Brave > Three Dot Menu > Settings
Open tabs in Custom Tabs > Make sure it's ON
Close Brave and type some query in Google Search > Open any link > Observe
Close the search > On the home screen swipe from left to right
Open any link > Observe

Actual result

Even when the Custom Tabs feature is enabled in Brave, and Brave is set as a default browser, links are opened in Chrome when accessing them from Google Search or Google Discover

https://github.com/brave/brave-browser/assets/128532965/d5d8d875-d62c-4a16-abcb-a59fbac746c6

Expected result

When Brave is set as the default browser and the Custom Tabs feature is enabled, all links must be opened in Custom Tab Mode via Brave

Issue reproduces how often

Easily reproduced

Version/Channel Information:

Can you reproduce this issue with the current Play Store version? Yes
Can you reproduce this issue with the current Play Store Beta version? Yes
Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

Install type (ARM, x86): ARM
Device type (Phone, Tablet, Phablet): Galaxy Tab S8 [tablet] or Pixel 7 [phone]
Android version: Android 13 and Android 14

Brave version

1.51.114 Chromium: 113.0.5672.92 (Official Build) (64-bit)

Website problems only

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Additional information

timchilds commented 1 year ago

@vlad-hoff in the Google app:

Settings -> General -> disable "open web pages in the app"

Let me know if that doesn't fix it.

hffvld commented 1 year ago

Hi @timchilds in that case links start opening in Brave in the full browser mode instead of Custom Tab Mode.

timchilds commented 1 year ago

@vlad-hoff:

(1) The Google app overrides the custom tabs setting to always open links in a Chrome web view. (2) Disabling the setting I mentioned in previous comment disables the web view and therefore opens links in the device default browser.

We did a little explainer tweet here: https://twitter.com/brave/status/1641957744511942656

We could go one step further and update the toggle copy with a link to an FAQ doc. Same as @deeppandya mentioned during triage. I'll have a think.

MrinmoyHaloi commented 8 months ago

Is there any way to open the links in brave custom tab instead of chrome custom tab?

Nemisor commented 2 weeks ago

This option no longer exists and there seems to be no equivalent. Is there some flag perhaps that might enable this again?

brave / brave-browser