Fix create_dist on Linux/macOS ASAN

[wknapik]

• https://bravesoftware.slack.com/archives/C7VLGSR55/p1683630816458149 (macos log)

  13:05:36 ../../chrome/installer/mac/third_party/bsdiff/goobspatch.c:64:3: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
  13:05:36                  sprintf(&sha1str[i * 2], "%02x", sha1[i]);
  13:05:36                  ^
  13:05:36  ../../build/mac_files/xcode_binaries/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here
  13:05:36  __deprecated_msg("This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
  13:05:36  ^
  13:05:36  ../../build/mac_files/xcode_binaries/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk/usr/include/sys/cdefs.h:215:48: note: expanded from macro '__deprecated_msg'
  13:05:36          #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
  13:05:36                                                        ^
  13:05:36  1 error generated.

• https://bravesoftware.slack.com/archives/C7VLGSR55/p1683631291438829 (linux log)

  FAILED: rpm_libGLESv2.deps 
  FAILED: rpm_brave_sandbox.deps
  FAILED: rpm_chrome_crashpad_handler.deps
  FAILED: rpm_chrome_management_service.deps
  FAILED: deb_libGLESv2.deps
  FAILED: rpm_brave.deps
  FAILED: deb_chrome_management_service.deps
  FAILED: deb_brave.deps

This works correctly on Windows

It also looks like symbols generation is disabled now with ASAN?

We haven't been running create_dist in ASAN pipelines for a while and just re-enabled it

[wknapik]

cc @rebron @bsclifton

[rebron]

cc: @goodov Can you take a look when you get a chance?

[wknapik]

Slack thread

Related https://github.com/brave/devops/issues/10027

[goodov]

why do we want to run create_dist in ASAN pipelines? this stage creates installers, archives symbols and do other unrelated to ASAN tests things.

[wknapik]

If we want to run ASAN in PRs (which we do if performance is good enough), then we wouldn't want to get rid of the create_dist step, otherwise something that breaks it might get merged. And we wouldn't get installers, etc. There's discussion about this in the linked thread and issue and it looks like most people are in favor of just not running create_dist in PRs. I think at least @mherrmann is still looking into it.

Otherwise, if we want to implement system tests and run them with ASAN, or fuzz the whole browser, we'd need at least part of what's done in create_dist to work.

Anyway, this is something that used to work (and still does on Windows).