brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.53k stars 2.27k forks source link

Cannot add custom filterlists: “Download failed” #30323

Open pr1maryuser opened 1 year ago

pr1maryuser commented 1 year ago

Description

When adding custom filterlists (pulled from https://filterlists.com/), it is unable to download them, giving me an error message of “Download failed” under “Last updated.” For the purposes of this post I’ll be using this one as an example.

Steps to Reproduce

  1. Go to filterlists.com
  2. Pick a filterlist
  3. Grab a link to the list by clicking “View” (as far as I can tell, the “Subscribe” buttons only work when you are using uBlock Origin)
  4. Go to brave://settings/shields/filters, scroll down to “Add custom filter lists”
  5. Copy/paste the link from earlier into the “Enter filter list URL” space, click “Add”
  6. The list then appears under “Custom lists,” but with the error message “Download failed” under “Last updated.”

Actual result:

image

Expected result:

The list successfully downloads and Brave subscribes to it.

Reproduces how often:

Any time I attempt to add a new list, I’ve tried a bunch of them.

Brave version (brave://version info)

Fedora Workstation 37 (Linux) Version 1.51.114 Chromium: 113.0.5672.92 (Official Build) unknown (64-bit)

(I am using the Flatpak version of Brave, which I understand is third party and not officially supported. I installed it through Brave’s official Fedora repository found here to test if the issue persisted on that version, and it did.)

Version/Channel Information:

Yes

Yes

Yes

Other Additional Information:

The issue itself is related to Shields, so no.

No.

The issue pertains to a Brave specific feature.

Miscellaneous Information:

I fully admit that I am not 100% certain that I am going through the correct steps to add custom lists, so I apologize if I am making some obvious mistake. The steps described are my best guess from searching for this topic.

AmirulAndalib commented 1 year ago

it is happening to me aswell need fix

ramprasathasokan commented 1 year ago

It's happening in this build too.

image
ramprasathasokan commented 1 year ago

@rebron please help here.

I was trying to add OISD filters.

image
wickles commented 1 year ago

I have the same problem with the Microsoft Store version on Windows 11. I managed it get it to download a filter list once or twice but otherwise it fails almost every time.

tazihad commented 12 months ago

I am facing similar issue on linux with flatpak. It's a build problem. A temporary solution is to rollback to older version. Add your custom filter and than update browser again.
This December 2022 version works. [Version 1.46.134 Chromium: 108.0.5359.94 (Official Build) unknown (64-bit)](https://brave.com/latest/)

sudo flatpak update --commit=aeeb1a93df6cfbe836965d437633c708977850a18b5e362d2c0aa8d2bd01c714 com.brave.Browser

Add your custom filter. And update flatpak again.

sudo flatpak update

Hope Brave will take over Flatpak version of Browser. Which has over 1 million Downloads.

aidan-walden commented 11 months ago

Can confirm this is also happening on the macOS version. 1.58.137 Chromium 117.0.5938.153 arm64

js-d-coder commented 1 month ago

I am facing this issue on Brave (Version 1.68.137 Chromium: 127.0.6533.100 (Official Build) (arm64)) while adding https://easylist.to/easylist/easylist.txt

jackblk commented 1 month ago

Same issue on Version 1.68.137 Chromium: 127.0.6533.100 (Official Build) (64-bit)

Tried https://easylist.to/easylist/easylist.txt, Download failed