brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.46k stars 2.26k forks source link

Vertical tab strip should self-collapse/minimize, after context-clicked (but not tab-focused) action #30398

Open stephendonner opened 1 year ago

stephendonner commented 1 year ago

Description

Vertical tab strip should self-collapse/minimize, after context-clicked (but not tab-focused) action

Steps to Reproduce

  1. install 1.53.46
  2. launch Brave
  3. open a few tabs
  4. open a tab and play video/audio (any youtube.com video)
  5. context-click on any tab
  6. chose Use Vertical Tabs
  7. click on any non-audio-playing tab, when in "minimized/collapsed" mode
  8. now, hover over the youtube.com tab and context-click
  9. choose Mute tab or Mute site
  10. mouse away from the tab strip

Actual result:

Even in Float on mouseover mode, the vertical tab strip remains expanded

stuck-floating

Expected result:

It should self-collapse after mouseout fires (this works on Linux; haven't yet checked Windows)

Reproduces how often:

Brave version (brave://version info)

Brave 1.53.46 Chromium: 114.0.5735.26 (Official Build) nightly (x86_64)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS macOS Version 11.7.6 (Build 20G1231)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

cc @rebron @sangwoo108 @brave/qa-team

rebron commented 1 year ago

@stephendonner macOS only?

stephendonner commented 1 year ago

@stephendonner macOS only?

Yeah, by all accounts, it is.

MadhaviSeelam commented 1 year ago

Couldn't reproduce in Win 11 x64


Brave | 1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (64-bit)
-- | --
Revision | c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS | Windows 11 Version 22H2 (Build 22621.1702)
``
sangwoo108 commented 1 year ago

Hum, I can't reproduce this on my Mac(Ventura). But will try finding what we can do.

stephendonner commented 1 year ago

@srirambv have you seen this?

srirambv commented 1 year ago

@stephendonner haven't seen this one on Windows/Linux