Open bkero opened 6 years ago
You might want to update https://github.com/brave/brave-browser/wiki/Linux-Development-Environment arter this gets fixed 😉
I wanted to reference this Chromium issue which is related to this problem, for posterity: https://bugs.chromium.org/p/chromium/issues/detail?id=766710
I ran into the same problems in https://github.com/brave/brave-core/pull/1078#issuecomment-454969015.
The solution, which I documented in https://github.com/brave/brave-browser/wiki/Linux-packages#build-command, is to use --official_build=true
or to omit that option entirely.
Maybe something has changed, but this trick doesn't work for me anymore 😞 I used the --official_build=true
(the full command below) and still got all these compilation errors.
npm install
npm run init
npm run create_dist Release --debug_build=false --official_build=true
And the errors are like:
[38185/38211] ACTION //chrome/installer/linux:calculate_rpm_dependencies(//build/toolchain/linux:clang_x64)
FAILED: rpm_libwidevinecdm.deps
python ../../chrome/installer/linux/rpm/calculate_package_deps.py libwidevinecdm.so rpm_libwidevinecdm.deps libwidevin
ecdm.so --distro-check
Traceback (most recent call last):
File "../../chrome/installer/linux/rpm/calculate_package_deps.py", line 34, in <module>
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
File "/usr/lib/python2.7/subprocess.py", line 394, in __init__
errread, errwrite)
File "/usr/lib/python2.7/subprocess.py", line 1047, in _execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
[38186/38211] ACTION //chrome/installer/linux:calculate_deb_dependencies(//build/toolchain/linux:clang_x64)
FAILED: deb_brave_sandbox.deps
python ../../chrome/installer/linux/debian/calculate_package_deps.py brave_sandbox ../../build/linux/debian_sid_amd64-
sysroot x64 deb_brave_sandbox.deps --distro-check
Traceback (most recent call last):
File "../../chrome/installer/linux/debian/calculate_package_deps.py", line 59, in <module>
cwd=sysroot)
File "/usr/lib/python2.7/subprocess.py", line 394, in __init__
errread, errwrite)
File "/usr/lib/python2.7/subprocess.py", line 1047, in _execute_child raise child_exception
OSError: [Errno 2] No such file or directory
[38187/38211] ACTION //chrome/installer/linux:calculate_deb_dependencies(//build/toolchain/linux:clang_x64)
FAILED: deb_brave.deps
python ../../chrome/installer/linux/debian/calculate_package_deps.py brave ../../build/linux/debian_sid_amd64-sysroot
x64 deb_brave.deps --distro-check
Traceback (most recent call last):
File "../../chrome/installer/linux/debian/calculate_package_deps.py", line 59, in <module>
cwd=sysroot)
File "/usr/lib/python2.7/subprocess.py", line 394, in __init__
errread, errwrite)
File "/usr/lib/python2.7/subprocess.py", line 1047, in _execute_child raise child_exception
OSError: [Errno 2] No such file or directory
@maximbaz can you try also passing in --skip_signing
? This is going to fail for most people (as-is) because it will try to do signing for the binaries
I think it fails before signing, due to me not having the necessary tools to create .deb
and .rpm
files.
But this actually isn't an issue for me anymore - to create an Arch Linux package I ended up using a simple npm run build Release
and then cherry-picking the necessary files from /src/out/Release
folder.
Here are the full build instructions, by the way, in case anyone is interested: PKGBUILD
@bsclifton Is the original issue (builds not working with --official-build=false
) actually fixed or did you close this based on https://github.com/brave/brave-browser/issues/305#issuecomment-512595192?
@fmarier good question... I know I have built with --official-build=false
, but I haven't tried to do create_dist
. I'll keep open until we can confirm that
Description
The build fails while doing the create_dist step with the following logs:
Steps to Reproduce
yarn run create_dist Release --debug_build=false --official_build=false --channel=beta
Actual result:
Expected result:
Reproduces how often:
Brave version (about:brave info)
Reproducible on current release:
Website problems only:
Additional Information