brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.91k stars 2.34k forks source link

Broken Rewards panel for connected user: Rewards panel shows non-connected state #30573

Open Miyayes opened 1 year ago

Miyayes commented 1 year ago

Rewards profile is connected to Uphold, and in a browser session where the Rewards panel was working fine. Suddenly it stopped working and broke.

Broken state involves:

Then rewards-internals showing no Rewards profile data:

STR

Intermittently reproducible.

I reproduced it by just going to different websites and channels, then clicking the Rewards panel really fast on each one. I was trying to go through many different creators to see their contribution banners, and then this suddenly happened.

A relaunch of the browser immediately fixed the problem.

Evidence

https://github.com/brave/brave-browser/assets/11497541/8bcbc4ef-05b8-422d-9524-0fb28409f553

image

Brave 1.53.63 Chromium: 114.0.5735.26 (Official Build) nightly (x86_64)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS macOS Version 13.4 (Build 22F66)
JavaScript V8 11.4.183.7
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36

cc: @LaurenWags @GeetaSarvadnya

Miyayes commented 1 year ago

I reproduced this again naturally in:

Brave 1.52.130 Chromium: 114.0.5735.198 (Official Build) (x86_64)
Revision c3029382d11c5f499e4fc317353a43d411a5ce1c-refs/branch-heads/5735@{#1394}
OS macOS Version 13.4.1 (Build 22F82)
zenparsing commented 1 year ago

@Miyayes #30680 (in 1.58) may help with this, to the extent that the error state should fix itself without restart.