Wallet shown chrome pages when Dapp tab is closed quickly - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.54k stars 2.27k forks source link

Wallet shown chrome pages when Dapp tab is closed quickly #30649

Open srirambv opened 1 year ago

srirambv commented 1 year ago

Description

Wallet shown chrome pages when Dapp tab is closed quickly

Steps to reproduce

Open a chrome page (chrome://version) in a tab
Open a second tab and visit solana-labs.github.io/wallet-adapter/example and connect wallet
Open a third tab and visit pwgoom.csb.app and connect wallet
Keep the phone idle so wallet is auto-locked
Quit browser and restart
Quickly close both tabs containing dapps
About Brave page shows the wallet connect notification and icon
Unlock wallet able to open wallet on chrome pages

Actual result

https://github.com/brave/brave-browser/assets/17010094/536cf59d-0c0e-43dd-84b1-1a1cd8807865

Expected result

No Wallet icon on Chrome page

Issue reproduces how often

Happened once

Version/Channel Information:

Can you reproduce this issue with the current Play Store version? NA but happened on RC build
Can you reproduce this issue with the current Play Store Beta version? Not checked
Can you reproduce this issue with the current Play Store Nightly version? Not checked

Device details

Install type (ARM, x86): ARM
Device type (Phone, Tablet, Phablet): Phone
Android version: 13

Brave version

1.52.113

Website problems only

Does the issue resolve itself when disabling Brave Shields? NA
Does the issue resolve itself when disabling Brave Rewards?NA
Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Pavneet-Sing @SergeyZhukovsky

Pavneet-Sing commented 1 year ago

Question: Should we also add a check against brave://version/? This could break web wallet pages (swaps) like chrome://wallet/swaps Discussion thread