brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.69k stars 2.31k forks source link

Migrate to RTK for querying balances #30779

Closed onyb closed 1 year ago

onyb commented 1 year ago
Community https://community.brave.com/t/macos-computer-crashes-when-trying-to-send-crypto-with-brave-wallet/485399/3

Some users have been reporting very high CPU usage since at least 1.51.x, but it's been a major problem all along. https://github.com/brave/brave-core/pull/18735 brings some significant performance improvements. We would like to extend this work beyond the panel to speed up the wallet page.

The problem is particularly bad when there a lot of accounts and custom networks. Since we refresh balances periodically, this leads to spikes in CPU usage like this:

image

Definition of done

srirambv commented 1 year ago

Verification passed on

Brave 1.58.109 Chromium: 116.0.5845.163 (Official Build) beta (64-bit)
Revision a4ad1fcdb550daf076384dbb280ae944274b3d35
OS Windows 11 Version 22H2 (Build 22621.2215)

https://github.com/brave/brave-browser/assets/17010094/e75f06e0-5541-4d9b-b086-65274c736942