brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.67k stars 2.31k forks source link

unexpected country can be highlighted (not selected) in country drop down when joining Rewards #30820

Open LaurenWags opened 1 year ago

LaurenWags commented 1 year ago

Description

See https://bravesoftware.slack.com/archives/CNH9Q6REV/p1683835027949059.

When joining rewards (at least in the US) and clicking on the "Select country" element, if you click towards the top of the element when the list is expanded "United States" is highlighted and selected.

If you click towards the bottom of the element, "United States" is selected, but "Uruguay" is highlighted. This is a little confusing.

Possibly related to https://github.com/brave/brave-browser/issues/29606.

Steps to Reproduce

pre-req: have region set to US

  1. Clean profile 1.53.x
  2. Click on BAT logo
  3. Select "Start using Brave Rewards"
  4. On the country selection screen, click on "Select country" but note where you click on the element (towards the top or bottom) to see the issue.

Actual result:

Screen Shot 2023-05-11 at 2 45 43 PM

Expected result:

Screenshot 2023-06-05 at 11 04 48 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.53.81 Chromium: 114.0.5735.90 (Official Build) beta (x86_64)
-- | --
Revision | 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}
OS | macOS Version 13.4 (Build 22F66)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

cc @Miyayes

Miyayes commented 1 year ago

There may not be an obvious way to actually fix this.