Make NTP background images service available to iOS

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.85k stars 2.34k forks source link

Make NTP background images service available to iOS #30871

Closed kylehickinson closed 1 year ago

kylehickinson commented 1 year ago

Description

The ntp_background_images component needs to be updated to be available for iOS to wrap and use in brave-ios

Test Case

Sanity test background images/sponsored images on desktop/android. iOS will be tested in a later PR

kjozwiak commented 1 year ago

The above requires 1.53.96 or higher for 1.53.x verification 👍 iOS will be verified via TF once we get builds that can pull/update NTP images from the component updater. For the above, just ensure that NTP is still working on Desktop & Android.

GeetaSarvadnya commented 1 year ago

Verification PASSED on

Brave | 1.53.99 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Windows 10 Version 22H2 (Build 19045.3086)

Using the STR/Cases outlined via https://github.com/brave/brave-browser/issues/30871#issue-1744611079, ensured that both NTP & NTP SI images were being displayed/working as expected.

[Note: wait until NTP and NTP SI components downloaded via brave://components after Brave launch]

Confirmed that new background image is displayed when a new tab is opened
Confirmed that the background images in NTP's are not repeated
Confirmed that NTP SI is displayed at 2nd, 4th and 8th tabs so on... as expected.

https://drive.google.com/file/d/1wjXwXYgaqCPcXTNdZ3bbLsIWdGnpSHLn/view?usp=sharing

hffvld commented 1 year ago

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 UPB3.230519.008 release-keys]
Brave build: 1.53.102
Chromium: 114.0.5735.133 (Official Build) (64-bit)
Revision: fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}

STEPS:

Launch Brave
Open NTP multiple times

ACTUAL RESULTS:

Verified that NTP image is displayed as expected
Verified that NTP SI image is displayed as expected
Verified that the user is able to open URL by tapping NTP SI
Verified that a new background image is displayed when a new tab is opened
Verified that the background images in NTP's are not repeated
Verified that NTP SI is displayed at 2nd, 4th and 8th tabs so on... as expected

https://github.com/brave/brave-browser/assets/128532965/11b7987a-dc03-41e8-a9fa-fc8db4514128